All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 12/13] drm/i915: Use a plain old int for the cdclk/mdclk ratio
Date: Wed, 27 Mar 2024 19:45:43 +0200	[thread overview]
Message-ID: <20240327174544.983-13-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240327174544.983-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

No point in throwing around u8 when we're dealing with
just an integer. Use a plain old boring 'int'.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c   | 6 +++---
 drivers/gpu/drm/i915/display/intel_cdclk.h   | 4 ++--
 drivers/gpu/drm/i915/display/skl_watermark.c | 6 ++++--
 drivers/gpu/drm/i915/display/skl_watermark.h | 6 ++++--
 4 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 66c161d7b485..5cba0d08189b 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1893,8 +1893,8 @@ static u32 xe2lpd_mdclk_source_sel(struct drm_i915_private *i915)
 	return MDCLK_SOURCE_SEL_CD2XCLK;
 }
 
-u8 intel_mdclk_cdclk_ratio(struct drm_i915_private *i915,
-			   const struct intel_cdclk_config *cdclk_config)
+int intel_mdclk_cdclk_ratio(struct drm_i915_private *i915,
+			    const struct intel_cdclk_config *cdclk_config)
 {
 	if (mdclk_source_is_cdclk_pll(i915))
 		return DIV_ROUND_UP(cdclk_config->vco, cdclk_config->cdclk);
@@ -3321,7 +3321,7 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state)
 
 	if (intel_mdclk_cdclk_ratio(dev_priv, &old_cdclk_state->actual) !=
 	    intel_mdclk_cdclk_ratio(dev_priv, &new_cdclk_state->actual)) {
-		u8 ratio = intel_mdclk_cdclk_ratio(dev_priv, &new_cdclk_state->actual);
+		int ratio = intel_mdclk_cdclk_ratio(dev_priv, &new_cdclk_state->actual);
 
 		ret = intel_dbuf_state_set_mdclk_cdclk_ratio(state, ratio);
 		if (ret)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.h b/drivers/gpu/drm/i915/display/intel_cdclk.h
index 5d4faf401774..cfdcdec07a4d 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.h
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.h
@@ -67,8 +67,8 @@ void intel_update_cdclk(struct drm_i915_private *dev_priv);
 u32 intel_read_rawclk(struct drm_i915_private *dev_priv);
 bool intel_cdclk_clock_changed(const struct intel_cdclk_config *a,
 			       const struct intel_cdclk_config *b);
-u8 intel_mdclk_cdclk_ratio(struct drm_i915_private *i915,
-			   const struct intel_cdclk_config *cdclk_config);
+int intel_mdclk_cdclk_ratio(struct drm_i915_private *i915,
+			    const struct intel_cdclk_config *cdclk_config);
 bool intel_cdclk_is_decreasing_later(struct intel_atomic_state *state);
 void intel_set_cdclk_pre_plane_update(struct intel_atomic_state *state);
 void intel_set_cdclk_post_plane_update(struct intel_atomic_state *state);
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index ca0f1f89e6d9..1b48009efe2b 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -3616,7 +3616,8 @@ static void intel_mbus_dbox_update(struct intel_atomic_state *state)
 	}
 }
 
-int intel_dbuf_state_set_mdclk_cdclk_ratio(struct intel_atomic_state *state, u8 ratio)
+int intel_dbuf_state_set_mdclk_cdclk_ratio(struct intel_atomic_state *state,
+					   int ratio)
 {
 	struct intel_dbuf_state *dbuf_state;
 
@@ -3629,7 +3630,8 @@ int intel_dbuf_state_set_mdclk_cdclk_ratio(struct intel_atomic_state *state, u8
 	return intel_atomic_lock_global_state(&dbuf_state->base);
 }
 
-void intel_dbuf_mdclk_cdclk_ratio_update(struct drm_i915_private *i915, u8 ratio, bool joined_mbus)
+void intel_dbuf_mdclk_cdclk_ratio_update(struct drm_i915_private *i915,
+					 int ratio, bool joined_mbus)
 {
 	enum dbuf_slice slice;
 
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.h b/drivers/gpu/drm/i915/display/skl_watermark.h
index 3323a1d973f9..ef1a008466be 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.h
+++ b/drivers/gpu/drm/i915/display/skl_watermark.h
@@ -74,11 +74,13 @@ intel_atomic_get_dbuf_state(struct intel_atomic_state *state);
 	to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->display.dbuf.obj))
 
 int intel_dbuf_init(struct drm_i915_private *i915);
-int intel_dbuf_state_set_mdclk_cdclk_ratio(struct intel_atomic_state *state, u8 ratio);
+int intel_dbuf_state_set_mdclk_cdclk_ratio(struct intel_atomic_state *state,
+					   int ratio);
 
 void intel_dbuf_pre_plane_update(struct intel_atomic_state *state);
 void intel_dbuf_post_plane_update(struct intel_atomic_state *state);
-void intel_dbuf_mdclk_cdclk_ratio_update(struct drm_i915_private *i915, u8 ratio, bool joined_mbus);
+void intel_dbuf_mdclk_cdclk_ratio_update(struct drm_i915_private *i915,
+					 int ratio, bool joined_mbus);
 void intel_dbuf_mbus_pre_ddb_update(struct intel_atomic_state *state);
 void intel_dbuf_mbus_post_ddb_update(struct intel_atomic_state *state);
 
-- 
2.43.2


  parent reply	other threads:[~2024-03-27 17:46 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 17:45 [PATCH 00/13] drm/i915: Implemnt vblank sycnhronized mbus joining changes Ville Syrjala
2024-03-27 17:45 ` [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active Ville Syrjala
2024-03-28  9:16   ` Murthy, Arun R
2024-03-28 12:32     ` Ville Syrjälä
2024-03-28 11:35   ` Shankar, Uma
2024-03-29 15:29   ` Gustavo Sousa
2024-04-03 15:51     ` Ville Syrjälä
2024-03-27 17:45 ` [PATCH 02/13] drm/i915/cdclk: Fix voltage_level programming edge case Ville Syrjala
2024-03-28 11:40   ` Shankar, Uma
2024-03-29 17:04   ` Gustavo Sousa
2024-04-02 14:56     ` Ville Syrjälä
2024-03-27 17:45 ` [PATCH 03/13] drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacks Ville Syrjala
2024-03-28 11:48   ` Shankar, Uma
2024-03-27 17:45 ` [PATCH 04/13] drm/i915/cdclk: Indicate whether CDCLK change happens during pre or post plane update Ville Syrjala
2024-03-28 11:51   ` Shankar, Uma
2024-03-29 17:14   ` Gustavo Sousa
2024-03-27 17:45 ` [PATCH 05/13] drm/i915: Loop over all active pipes in intel_mbus_dbox_update Ville Syrjala
2024-03-28 11:53   ` Shankar, Uma
2024-03-27 17:45 ` [PATCH 06/13] drm/i915: Relocate intel_mbus_dbox_update() Ville Syrjala
2024-03-28 11:54   ` Shankar, Uma
2024-03-29 18:28   ` Gustavo Sousa
2024-03-27 17:45 ` [PATCH 07/13] drm/i915: Extract intel_dbuf_mbus_join_update() Ville Syrjala
2024-03-28 11:57   ` Shankar, Uma
2024-03-29 18:29   ` Gustavo Sousa
2024-03-27 17:45 ` [PATCH 08/13] drm/i915: Extract intel_dbuf_mdclk_min_tracker_update() Ville Syrjala
2024-03-28 12:01   ` Shankar, Uma
2024-03-29 18:31   ` Gustavo Sousa
2024-03-27 17:45 ` [PATCH 09/13] drm/i915: Add debugs for mbus joining and dbuf ratio programming Ville Syrjala
2024-03-28 12:04   ` Shankar, Uma
2024-03-29 18:32   ` Gustavo Sousa
2024-03-27 17:45 ` [PATCH 10/13] drm/i915: Use old mbus_join value when increasing CDCLK Ville Syrjala
2024-03-28 12:07   ` Shankar, Uma
2024-03-27 17:45 ` [PATCH 11/13] drm/i915: Implement vblank synchronized MBUS join changes Ville Syrjala
2024-03-28 16:08   ` Shankar, Uma
2024-03-29 18:15   ` Gustavo Sousa
2024-04-02 14:25     ` Ville Syrjälä
2024-03-27 17:45 ` Ville Syrjala [this message]
2024-03-28 16:09   ` [PATCH 12/13] drm/i915: Use a plain old int for the cdclk/mdclk ratio Shankar, Uma
2024-03-29 18:23   ` Gustavo Sousa
2024-04-02 14:49     ` Ville Syrjälä
2024-03-27 17:45 ` [PATCH 13/13] drm/i915: Optimize out redundant dbuf slice updates Ville Syrjala
2024-03-28 16:12   ` Shankar, Uma
2024-03-27 22:44 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Implemnt vblank sycnhronized mbus joining changes Patchwork
2024-03-28 14:50 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-28 15:58 ` Patchwork
2024-03-28 16:15 ` ✓ Fi.CI.IGT: " Patchwork
2024-03-28 16:16 ` [PATCH 00/13] " Shankar, Uma
2024-03-28 18:35 ` ✓ Fi.CI.IGT: success for " Patchwork
2024-03-28 20:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-29  4:42 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev2) Patchwork
2024-03-29  5:00 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-30  2:41 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327174544.983-13-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.