From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Armin Wolf <W_Armin@gmx.de>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous improvements
Date: Wed, 27 Mar 2024 23:52:08 +0200 [thread overview]
Message-ID: <20240327215208.649020-1-andy.shevchenko@gmail.com> (raw)
There is a mix of a few improvements to the driver.
I have done this instead of review, so it can quickly be
folded into the original code (partially or fully).
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/platform/x86/quickstart.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
index ba3a7a25dda70..f686942662ccc 100644
--- a/drivers/platform/x86/quickstart.c
+++ b/drivers/platform/x86/quickstart.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * quickstart.c - ACPI Direct App Launch driver
+ * ACPI Direct App Launch driver
*
* Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>
* Copyright (C) 2022 Arvid Norlander <lkml@vorapal.se>
@@ -10,15 +10,18 @@
* <https://archive.org/details/microsoft-acpi-dirapplaunch>
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
#include <linux/acpi.h>
+#include <linux/device.h>
+#include <linux/errno.h>
#include <linux/init.h>
#include <linux/input.h>
#include <linux/input/sparse-keymap.h>
-#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/pm_wakeup.h>
+#include <linux/printk.h>
+#include <linux/slab.h>
#include <linux/sysfs.h>
#include <linux/types.h>
@@ -165,7 +168,8 @@ static int quickstart_probe(struct platform_device *pdev)
data->dev = &pdev->dev;
dev_set_drvdata(&pdev->dev, data);
- /* We have to initialize the device wakeup before evaluating GHID because
+ /*
+ * We have to initialize the device wakeup before evaluating GHID because
* doing so will notify the device if the button was used to wake the machine
* from S5.
*/
@@ -202,7 +206,7 @@ static int quickstart_probe(struct platform_device *pdev)
}
static const struct acpi_device_id quickstart_device_ids[] = {
- { "PNP0C32", 0 },
+ { "PNP0C32" },
{ }
};
MODULE_DEVICE_TABLE(acpi, quickstart_device_ids);
--
2.44.0
next reply other threads:[~2024-03-27 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 21:52 Andy Shevchenko [this message]
2024-03-27 23:35 ` [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous improvements Armin Wolf
2024-03-28 8:50 ` Andy Shevchenko
2024-03-29 0:23 ` Armin Wolf
2024-03-29 17:43 ` Andy Shevchenko
2024-04-08 9:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327215208.649020-1-andy.shevchenko@gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.