From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Luigi311 <git@luigi311.com>, Ondrej Jirman <megi@xff.cz> Subject: [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio Date: Wed, 27 Mar 2024 17:17:08 -0600 [thread overview] Message-ID: <20240327231710.53188-23-git@luigi311.com> (raw) In-Reply-To: <20240327231710.53188-1-git@luigi311.com> From: Luigi311 <git@luigi311.com> On some boards powerdown signal needs to be deasserted for this sensor to be enabled. Signed-off-by: Ondrej Jirman <megi@xff.cz> --- .../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ++++ drivers/media/i2c/imx258.c | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index c7856de15ba3..0414085bf22f 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -35,6 +35,10 @@ properties: reg: maxItems: 1 + powerdown-gpios: + description: |- + Reference to the GPIO connected to the PWDN pin, if any. + reset-gpios: description: |- Reference to the GPIO connected to the XCLR pin, if any. diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index c559a06bf180..d8c51d5f04e0 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -686,6 +686,8 @@ struct imx258 { unsigned int lane_mode_idx; unsigned int csi2_flags; + struct gpio_desc *powerdown_gpio; + /* * Mutex for serialized access: * Protect sensor module set pad format and start/stop streaming safely. @@ -1220,6 +1222,8 @@ static int imx258_power_on(struct device *dev) struct imx258 *imx258 = to_imx258(sd); int ret; + gpiod_set_value_cansleep(imx258->powerdown_gpio, 0); + ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES, imx258->supplies); if (ret) { @@ -1231,6 +1235,7 @@ static int imx258_power_on(struct device *dev) ret = clk_prepare_enable(imx258->clk); if (ret) { dev_err(dev, "failed to enable clock\n"); + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); } @@ -1245,6 +1250,8 @@ static int imx258_power_off(struct device *dev) clk_disable_unprepare(imx258->clk); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); + return 0; } @@ -1548,6 +1555,12 @@ static int imx258_probe(struct i2c_client *client) if (!imx258->variant_cfg) imx258->variant_cfg = &imx258_cfg; + /* request optional power down pin */ + imx258->powerdown_gpio = devm_gpiod_get_optional(&client->dev, "powerdown", + GPIOD_OUT_HIGH); + if (IS_ERR(imx258->powerdown_gpio)) + return PTR_ERR(imx258->powerdown_gpio); + /* Initialize subdev */ v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); -- 2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Luigi311 <git@luigi311.com>, Ondrej Jirman <megi@xff.cz> Subject: [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio Date: Wed, 27 Mar 2024 17:17:08 -0600 [thread overview] Message-ID: <20240327231710.53188-23-git@luigi311.com> (raw) In-Reply-To: <20240327231710.53188-1-git@luigi311.com> From: Luigi311 <git@luigi311.com> On some boards powerdown signal needs to be deasserted for this sensor to be enabled. Signed-off-by: Ondrej Jirman <megi@xff.cz> --- .../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ++++ drivers/media/i2c/imx258.c | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index c7856de15ba3..0414085bf22f 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -35,6 +35,10 @@ properties: reg: maxItems: 1 + powerdown-gpios: + description: |- + Reference to the GPIO connected to the PWDN pin, if any. + reset-gpios: description: |- Reference to the GPIO connected to the XCLR pin, if any. diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index c559a06bf180..d8c51d5f04e0 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -686,6 +686,8 @@ struct imx258 { unsigned int lane_mode_idx; unsigned int csi2_flags; + struct gpio_desc *powerdown_gpio; + /* * Mutex for serialized access: * Protect sensor module set pad format and start/stop streaming safely. @@ -1220,6 +1222,8 @@ static int imx258_power_on(struct device *dev) struct imx258 *imx258 = to_imx258(sd); int ret; + gpiod_set_value_cansleep(imx258->powerdown_gpio, 0); + ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES, imx258->supplies); if (ret) { @@ -1231,6 +1235,7 @@ static int imx258_power_on(struct device *dev) ret = clk_prepare_enable(imx258->clk); if (ret) { dev_err(dev, "failed to enable clock\n"); + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); } @@ -1245,6 +1250,8 @@ static int imx258_power_off(struct device *dev) clk_disable_unprepare(imx258->clk); regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); + gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); + return 0; } @@ -1548,6 +1555,12 @@ static int imx258_probe(struct i2c_client *client) if (!imx258->variant_cfg) imx258->variant_cfg = &imx258_cfg; + /* request optional power down pin */ + imx258->powerdown_gpio = devm_gpiod_get_optional(&client->dev, "powerdown", + GPIOD_OUT_HIGH); + if (IS_ERR(imx258->powerdown_gpio)) + return PTR_ERR(imx258->powerdown_gpio); + /* Initialize subdev */ v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-27 23:23 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-27 23:16 [PATCH 00/23] v2: imx258 improvement series git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 01/23] media: i2c: imx258: Remove unused defines git 2024-03-27 23:16 ` git 2024-03-28 7:42 ` Krzysztof Kozlowski 2024-03-28 7:42 ` Krzysztof Kozlowski 2024-03-27 23:16 ` [PATCH 02/23] media: i2c: imx258: Make image geometry meet sensor requirements git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 03/23] media: i2c: imx258: Disable digital cropping on binned modes git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 04/23] media: i2c: imx258: Remove redundant I2C writes git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 05/23] media: i2c: imx258: Add regulator control git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 06/23] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 07/23] media: i2c: imx258: Split out common registers from the mode based ones git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 08/23] media: i2c: imx258: Add support for 24MHz clock git 2024-03-27 23:16 ` git 2024-03-28 8:09 ` Sakari Ailus 2024-03-28 8:09 ` Sakari Ailus 2024-03-28 17:55 ` Luigi311 2024-03-28 17:55 ` Luigi311 2024-03-28 23:03 ` Luigi311 2024-03-28 23:03 ` Luigi311 2024-04-04 8:03 ` Sakari Ailus 2024-04-04 8:03 ` Sakari Ailus 2024-03-27 23:16 ` [PATCH 09/23] media: i2c: imx258: Add support for running on 2 CSI data lanes git 2024-03-27 23:16 ` git 2024-03-28 8:19 ` Sakari Ailus 2024-03-28 8:19 ` Sakari Ailus 2024-03-28 23:42 ` Luigi311 2024-03-28 23:42 ` Luigi311 2024-03-29 19:10 ` Luigi311 2024-03-29 19:10 ` Luigi311 2024-03-27 23:16 ` [PATCH 10/23] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 11/23] media: i2c: imx258: Add get_selection for pixel array information git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 12/23] media: i2c: imx258: Allow configuration of clock lane behaviour git 2024-03-27 23:16 ` git 2024-03-27 23:16 ` [PATCH 13/23] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git 2024-03-27 23:16 ` git 2024-03-27 23:17 ` [PATCH 14/23] media: i2c: imx258: Issue reset before starting streaming git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` [PATCH 15/23] media: i2c: imx258: Set pixel_rate range to the same as the value git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` [PATCH 16/23] media: i2c: imx258: Support faster pixel rate on binned modes git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` [PATCH 17/23] dt-bindings: media: imx258: Rename to include vendor prefix git 2024-03-27 23:17 ` git 2024-03-27 23:47 ` Conor Dooley 2024-03-27 23:47 ` Conor Dooley 2024-03-28 0:57 ` git 2024-03-28 0:57 ` git 2024-03-28 8:52 ` Kieran Bingham 2024-03-28 8:52 ` Kieran Bingham 2024-03-28 10:15 ` Conor Dooley 2024-03-28 10:15 ` Conor Dooley 2024-03-28 16:15 ` Luigi311 2024-03-28 16:15 ` Luigi311 2024-03-27 23:17 ` [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings git 2024-03-27 23:17 ` git 2024-03-28 0:44 ` Rob Herring 2024-03-28 0:44 ` Rob Herring 2024-03-28 7:47 ` Krzysztof Kozlowski 2024-03-28 7:47 ` Krzysztof Kozlowski 2024-03-28 17:05 ` Luigi311 2024-03-28 17:05 ` Luigi311 2024-03-28 17:06 ` Krzysztof Kozlowski 2024-03-28 17:06 ` Krzysztof Kozlowski 2024-03-28 18:55 ` Rob Herring 2024-03-28 18:55 ` Rob Herring 2024-03-28 19:16 ` Luigi311 2024-03-28 19:16 ` Luigi311 2024-03-28 20:46 ` Rob Herring 2024-03-28 20:46 ` Rob Herring 2024-03-28 21:02 ` Luigi311 2024-03-28 21:02 ` Luigi311 2024-03-28 20:05 ` kernel test robot 2024-03-28 20:05 ` kernel test robot 2024-03-30 0:30 ` kernel test robot 2024-03-30 0:30 ` kernel test robot 2024-03-30 20:59 ` kernel test robot 2024-03-30 20:59 ` kernel test robot 2024-03-27 23:17 ` [PATCH 19/23] media: i2c: imx258: Change register settings for variants of the sensor git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` [PATCH 20/23] media: i2c: imx258: Make HFLIP and VFLIP controls writable git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` [PATCH 21/23] drivers: media: i2c: imx258: Use macros git 2024-03-27 23:17 ` git 2024-03-27 23:17 ` git [this message] 2024-03-27 23:17 ` [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio git 2024-03-28 20:48 ` Rob Herring 2024-03-28 20:48 ` Rob Herring 2024-03-28 21:11 ` Luigi311 2024-03-28 21:11 ` Luigi311 2024-04-02 14:28 ` Dan Carpenter 2024-04-02 14:28 ` Dan Carpenter 2024-03-27 23:17 ` [PATCH 23/23] drivers: media: i2c: imx258: Add support for reset gpio git 2024-03-27 23:17 ` git 2024-03-28 7:43 ` [PATCH 00/23] v2: imx258 improvement series Krzysztof Kozlowski 2024-03-28 7:43 ` Krzysztof Kozlowski 2024-03-30 3:51 ` Dang Huynh 2024-03-30 3:51 ` Dang Huynh 2024-03-30 6:37 ` Luigi311 2024-03-30 6:37 ` Luigi311 2024-04-01 6:42 [PATCH 22/23] drivers: media: i2c: imx258: Add support for powerdown gpio kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240327231710.53188-23-git@luigi311.com \ --to=git@luigi311.com \ --cc=conor+dt@kernel.org \ --cc=dave.stevenson@raspberrypi.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=imx@lists.linux.dev \ --cc=jacopo.mondi@ideasonboard.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=megi@xff.cz \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sakari.ailus@linux.intel.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.