All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@lists.linux.dev, Mike Snitzer <snitzer@redhat.com>,
	linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v3 27/30] block: Replace zone_wlock debugfs entry with zone_wplugs entry
Date: Thu, 28 Mar 2024 09:44:06 +0900	[thread overview]
Message-ID: <20240328004409.594888-28-dlemoal@kernel.org> (raw)
In-Reply-To: <20240328004409.594888-1-dlemoal@kernel.org>

In preparation to completely remove zone write locking, replace the
"zone_wlock" mq-debugfs entry that was listing zones that are
write-locked with the zone_wplugs entry which lists the zones that
currently have a write plug allocated.

The write plug information provided is: the zone number, the zone write
plug flags, the zone write plug write pointer offset and the number of
BIOs currently waiting for execution in the zone write plug BIO list.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 block/blk-mq-debugfs.c |  2 +-
 block/blk-mq-debugfs.h |  4 ++--
 block/blk-zoned.c      | 31 ++++++++++++++++++++++++-------
 3 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 94668e72ab09..ca1f2b9422d5 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -160,7 +160,7 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_queue_attrs[] = {
 	{ "requeue_list", 0400, .seq_ops = &queue_requeue_list_seq_ops },
 	{ "pm_only", 0600, queue_pm_only_show, NULL },
 	{ "state", 0600, queue_state_show, queue_state_write },
-	{ "zone_wlock", 0400, queue_zone_wlock_show, NULL },
+	{ "zone_wplugs", 0400, queue_zone_wplugs_show, NULL },
 	{ },
 };
 
diff --git a/block/blk-mq-debugfs.h b/block/blk-mq-debugfs.h
index 3ebe2c29b624..c80e453e3014 100644
--- a/block/blk-mq-debugfs.h
+++ b/block/blk-mq-debugfs.h
@@ -84,9 +84,9 @@ static inline void blk_mq_debugfs_unregister_rqos(struct rq_qos *rqos)
 #endif
 
 #if defined(CONFIG_BLK_DEV_ZONED) && defined(CONFIG_BLK_DEBUG_FS)
-int queue_zone_wlock_show(void *data, struct seq_file *m);
+int queue_zone_wplugs_show(void *data, struct seq_file *m);
 #else
-static inline int queue_zone_wlock_show(void *data, struct seq_file *m)
+static inline int queue_zone_wplugs_show(void *data, struct seq_file *m)
 {
 	return 0;
 }
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 93aa994824d1..d540688c30f9 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -1894,17 +1894,34 @@ EXPORT_SYMBOL_GPL(blk_revalidate_disk_zones);
 
 #ifdef CONFIG_BLK_DEBUG_FS
 
-int queue_zone_wlock_show(void *data, struct seq_file *m)
+int queue_zone_wplugs_show(void *data, struct seq_file *m)
 {
 	struct request_queue *q = data;
-	unsigned int i;
+	struct gendisk *disk = q->disk;
+	struct blk_zone_wplug *zwplug;
+	unsigned int zwp_wp_offset, zwp_flags;
+	unsigned int zwp_zone_no, zwp_ref;
+	unsigned int zwp_bio_list_size, i;
+	unsigned long flags;
 
-	if (!q->disk->seq_zones_wlock)
-		return 0;
+	rcu_read_lock();
+	for (i = 0; i < disk_zone_wplugs_hash_size(disk); i++) {
+		hlist_for_each_entry_rcu(zwplug,
+					 &disk->zone_wplugs_hash[i], node) {
+			spin_lock_irqsave(&zwplug->lock, flags);
+			zwp_zone_no = zwplug->zone_no;
+			zwp_flags = zwplug->flags;
+			zwp_ref = atomic_read(&zwplug->ref);
+			zwp_wp_offset = zwplug->wp_offset;
+			zwp_bio_list_size = bio_list_size(&zwplug->bio_list);
+			spin_unlock_irqrestore(&zwplug->lock, flags);
 
-	for (i = 0; i < q->disk->nr_zones; i++)
-		if (test_bit(i, q->disk->seq_zones_wlock))
-			seq_printf(m, "%u\n", i);
+			seq_printf(m, "%u 0x%x %u %u %u\n",
+				   zwp_zone_no, zwp_flags, zwp_ref,
+				   zwp_wp_offset, zwp_bio_list_size);
+		}
+	}
+	rcu_read_unlock();
 
 	return 0;
 }
-- 
2.44.0


  parent reply	other threads:[~2024-03-28  0:44 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  0:43 [PATCH v3 00/30] Zone write plugging Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 01/30] block: Do not force full zone append completion in req_bio_endio() Damien Le Moal
2024-03-28  4:10   ` Christoph Hellwig
2024-03-28 18:14   ` Bart Van Assche
2024-03-28 22:43     ` Damien Le Moal
2024-03-28 23:03       ` Jens Axboe
2024-03-28  0:43 ` [PATCH v3 02/30] block: Restore sector of flush requests Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 03/30] block: Remove req_bio_endio() Damien Le Moal
2024-03-28  4:13   ` Christoph Hellwig
2024-03-28 21:28   ` Bart Van Assche
2024-03-28 22:42     ` Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 04/30] block: Introduce blk_zone_update_request_bio() Damien Le Moal
2024-03-28  4:14   ` Christoph Hellwig
2024-03-28  5:20     ` Damien Le Moal
2024-03-28  5:42       ` Christoph Hellwig
2024-03-28  5:54         ` Damien Le Moal
2024-03-28 21:31   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 05/30] block: Introduce bio_straddles_zones() and bio_offset_from_zone_start() Damien Le Moal
2024-03-28 21:32   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 06/30] block: Allow using bio_attempt_back_merge() internally Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 07/30] block: Remember zone capacity when revalidating zones Damien Le Moal
2024-03-28 21:38   ` Bart Van Assche
2024-03-28 22:40     ` Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 08/30] block: Introduce zone write plugging Damien Le Moal
2024-03-28  4:48   ` Christoph Hellwig
2024-03-28 22:20   ` Bart Van Assche
2024-03-28 22:38     ` Damien Le Moal
2024-03-29 18:20       ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 09/30] block: Pre-allocate zone write plugs Damien Le Moal
2024-03-28  4:30   ` Christoph Hellwig
2024-03-28  5:28     ` Damien Le Moal
2024-03-28  5:46       ` Christoph Hellwig
2024-03-28  6:02         ` Damien Le Moal
2024-03-28  6:03           ` Christoph Hellwig
2024-03-28  6:18             ` Damien Le Moal
2024-03-28  6:22               ` Christoph Hellwig
2024-03-28  6:33                 ` Damien Le Moal
2024-03-28  6:38                   ` Christoph Hellwig
2024-03-28  6:51                     ` Damien Le Moal
2024-03-28  6:52                       ` Christoph Hellwig
2024-03-28  6:53                         ` Damien Le Moal
2024-03-28 22:25     ` Bart Van Assche
2024-03-28 22:29   ` Bart Van Assche
2024-03-28 22:33     ` Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 10/30] block: Fake max open zones limit when there is no limit Damien Le Moal
2024-03-28  4:49   ` Christoph Hellwig
2024-03-29 20:37   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 11/30] block: Allow zero value of max_zone_append_sectors queue limit Damien Le Moal
2024-03-28  4:49   ` Christoph Hellwig
2024-03-29 20:50   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 12/30] block: Implement zone append emulation Damien Le Moal
2024-03-28  4:50   ` Christoph Hellwig
2024-03-29 21:22   ` Bart Van Assche
2024-03-29 21:26   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 13/30] block: Allow BIO-based drivers to use blk_revalidate_disk_zones() Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 14/30] dm: Use the block layer zone append emulation Damien Le Moal
2024-03-28  0:43 ` [PATCH v3 15/30] scsi: sd: " Damien Le Moal
2024-03-28  4:50   ` Christoph Hellwig
2024-03-28 10:49   ` Johannes Thumshirn
2024-03-29 21:27   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 16/30] ublk_drv: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature Damien Le Moal
2024-03-28  4:50   ` Christoph Hellwig
2024-03-29 21:28   ` Bart Van Assche
2024-03-28  0:43 ` [PATCH v3 17/30] null_blk: " Damien Le Moal
2024-03-28  4:51   ` Christoph Hellwig
2024-03-29 21:29   ` Bart Van Assche
2024-04-02  6:43   ` Chaitanya Kulkarni
2024-03-28  0:43 ` [PATCH v3 18/30] null_blk: Introduce zone_append_max_sectors attribute Damien Le Moal
2024-03-28  4:51   ` Christoph Hellwig
2024-03-29 21:35   ` Bart Van Assche
2024-03-30  0:33     ` Damien Le Moal
2024-04-02  6:44   ` Chaitanya Kulkarni
2024-03-28  0:43 ` [PATCH v3 19/30] null_blk: Introduce fua attribute Damien Le Moal
2024-03-28  4:52   ` Christoph Hellwig
2024-03-29 21:36   ` Bart Van Assche
2024-04-02  6:42   ` Chaitanya Kulkarni
2024-03-28  0:43 ` [PATCH v3 20/30] nvmet: zns: Do not reference the gendisk conv_zones_bitmap Damien Le Moal
2024-04-02  6:45   ` Chaitanya Kulkarni
2024-03-28  0:44 ` [PATCH v3 21/30] block: Remove BLK_STS_ZONE_RESOURCE Damien Le Moal
2024-03-29 21:37   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 22/30] block: Simplify blk_revalidate_disk_zones() interface Damien Le Moal
2024-03-29 21:41   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 23/30] block: mq-deadline: Remove support for zone write locking Damien Le Moal
2024-03-28  4:52   ` Christoph Hellwig
2024-03-29 21:43   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 24/30] block: Remove elevator required features Damien Le Moal
2024-03-29 21:44   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 25/30] block: Do not check zone type in blk_check_zone_append() Damien Le Moal
2024-03-29 21:45   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 26/30] block: Move zone related debugfs attribute to blk-zoned.c Damien Le Moal
2024-03-28  4:52   ` Christoph Hellwig
2024-03-29 19:00   ` Bart Van Assche
2024-03-28  0:44 ` Damien Le Moal [this message]
2024-03-28  4:53   ` [PATCH v3 27/30] block: Replace zone_wlock debugfs entry with zone_wplugs entry Christoph Hellwig
2024-03-29 18:54   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 28/30] block: Remove zone write locking Damien Le Moal
2024-03-29 18:57   ` Bart Van Assche
2024-03-28  0:44 ` [PATCH v3 29/30] block: Do not force select mq-deadline with CONFIG_BLK_DEV_ZONED Damien Le Moal
2024-03-28  4:53   ` Christoph Hellwig
2024-03-28  0:44 ` [PATCH v3 30/30] block: Do not special-case plugging of zone write operations Damien Le Moal
2024-03-28  4:54   ` Christoph Hellwig
2024-03-28  6:43     ` Damien Le Moal
2024-03-28  6:51       ` Christoph Hellwig
2024-03-28  6:54         ` Damien Le Moal
2024-03-29 18:58   ` Bart Van Assche
2024-03-28 23:05 ` (subset) [PATCH v3 00/30] Zone write plugging Jens Axboe
2024-03-28 23:13   ` Damien Le Moal
2024-03-28 23:27     ` Jens Axboe
2024-03-28 23:33       ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328004409.594888-28-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.