All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Herdler <herdler@nurfuerspam.de>
To: hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, smoch@web.de, tmn505@gmail.com,
	vinschen@redhat.com
Subject: [PATCH 09/11] media: ttpci: checkpatch fixes: miscellaneous
Date: Thu, 28 Mar 2024 03:05:20 +0100	[thread overview]
Message-ID: <20240328020522.50995-10-herdler@nurfuerspam.de> (raw)
In-Reply-To: <20240328020522.50995-1-herdler@nurfuerspam.de>

This patch fixes the following checkpatch warnings:

WARNING:RETURN_VOID: void function return statements are not generally useful
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon


Signed-off-by: Stefan Herdler <herdler@nurfuerspam.de>
---

 drivers/media/pci/ttpci/budget.c | 1 -
 drivers/media/pci/ttpci/budget.h | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/pci/ttpci/budget.c b/drivers/media/pci/ttpci/budget.c
index f14b90de6..50fce65ce 100644
--- a/drivers/media/pci/ttpci/budget.c
+++ b/drivers/media/pci/ttpci/budget.c
@@ -781,7 +781,6 @@ static void frontend_init(struct budget *budget)
 	printk("budget: Frontend registration failed!\n");
 	dvb_frontend_detach(budget->dvb_frontend);
 	budget->dvb_frontend = NULL;
-	return;
 }

 static int budget_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_data *info)
diff --git a/drivers/media/pci/ttpci/budget.h b/drivers/media/pci/ttpci/budget.h
index 4579243c2..ae6de6a19 100644
--- a/drivers/media/pci/ttpci/budget.h
+++ b/drivers/media/pci/ttpci/budget.h
@@ -89,7 +89,7 @@ static struct budget_info x_var ## _info = { \
 	.type = x_type };	\
 static struct saa7146_pci_extension_data x_var = { \
 	.ext_priv = &x_var ## _info, \
-	.ext = &budget_extension };
+	.ext = &budget_extension }

 #define BUDGET_TT		   0
 #define BUDGET_TT_HW_DISEQC	   1
--
2.34.0


  parent reply	other threads:[~2024-03-28  2:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  2:05 [PATCH 00/11] media: ttpci: make checkpatch happy Stefan Herdler
2024-03-28  2:05 ` [PATCH 01/11] media: ttpci: checkpatch fixes: whitespace and newlines Stefan Herdler
2024-03-28  2:05 ` [PATCH 02/11] media: ttpci: checkpatch fixes: whitespace Stefan Herdler
2024-03-28  2:05 ` [PATCH 03/11] media: ttpci: checkpatch fixes: comments Stefan Herdler
2024-03-28  2:05 ` [PATCH 04/11] media: ttpci: checkpatch fixes: braces Stefan Herdler
2024-04-08 14:47   ` Hans Verkuil
2024-03-28  2:05 ` [PATCH 05/11] media: ttpci: checkpatch fixes: export_symbol Stefan Herdler
2024-03-28  2:05 ` [PATCH 06/11] media: ttpci: checkpatch fixes: assign_in_if Stefan Herdler
2024-03-28  2:05 ` [PATCH 07/11] media: ttpci: checkpatch fixes: trailing_statements Stefan Herdler
2024-03-28  2:05 ` [PATCH 08/11] media: ttpci: checkpatch fixes: constant_comparsation Stefan Herdler
2024-03-28  2:05 ` Stefan Herdler [this message]
2024-03-28  2:05 ` [PATCH 10/11] media: ttpci: checkpatch fixes: logging Stefan Herdler
2024-03-28  2:05 ` [PATCH 11/11] media: ttpci: checkpatch fixes: msleep Stefan Herdler
2024-04-08 14:53   ` Hans Verkuil
2024-04-08 14:54 ` [PATCH 00/11] media: ttpci: make checkpatch happy Hans Verkuil
2024-04-12 21:59   ` Stefan Herdler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328020522.50995-10-herdler@nurfuerspam.de \
    --to=herdler@nurfuerspam.de \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=smoch@web.de \
    --cc=tmn505@gmail.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.