All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Animesh Manna" <animesh.manna@intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 01/19] drm/i915/psr: Add some documentation of variables used in psr code
Date: Tue,  2 Apr 2024 12:49:53 +0300	[thread overview]
Message-ID: <20240402095011.200558-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240402095011.200558-1-jouni.hogander@intel.com>

We are adding more boolean variable into intel_psr and intel_crtc_state
structs. Add some documentation about these for sake of clarity.

v2: Modify has_psr +  has_panel_replay to mean panel replay

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index eef62983e9db..45d13e042ade 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -171,6 +171,22 @@
  *
  * The rest of the bits are more self-explanatory and/or
  * irrelevant for normal operation.
+ *
+ * Description of intel_crtc_state variables. has_psr, has_panel_replay and
+ * has_sel_update:
+ *
+ *  has_psr (alone):					PSR1
+ *  has_psr + has_sel_update:				PSR2
+ *  has_psr + has_panel_replay:				Panel Replay
+ *  has_psr + has_panel_replay + has_sel_update:	Panel Replay Selective Update
+ *
+ * Description of some intel_psr varibles. enabled, panel_replay_enabled,
+ * sel_update_enabled
+ *
+ *  enabled (alone):						PSR1
+ *  enabled + sel_update_enabled:				PSR2
+ *  enabled + panel_replay_enabled:				Panel Replay
+ *  enabled + panel_replay_enabled + sel_update_enabled:	Panel Replay SU
  */
 
 #define CAN_PSR(intel_dp) ((intel_dp)->psr.sink_support && \
-- 
2.34.1


  reply	other threads:[~2024-04-02  9:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02  9:49 [PATCH v4 00/19] Panel replay selective update support Jouni Högander
2024-04-02  9:49 ` Jouni Högander [this message]
2024-04-02  9:49 ` [PATCH v4 02/19] drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well Jouni Högander
2024-04-02  9:49 ` [PATCH v4 03/19] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay Jouni Högander
2024-04-02  9:49 ` [PATCH v4 04/19] drm/i915/psr: Do not update phy power state in case of non-eDP " Jouni Högander
2024-04-02  9:49 ` [PATCH v4 05/19] drm/i915/psr: Check possible errors for panel replay as well Jouni Högander
2024-04-02  9:49 ` [PATCH v4 06/19] drm/i915/psr: Do not write registers/bits not applicable for panel replay Jouni Högander
2024-04-02  9:49 ` [PATCH v4 07/19] drm/i915/psr: Call intel_psr_init_dpcd in intel_dp_detect Jouni Högander
2024-04-02  9:50 ` [PATCH v4 08/19] drm/i915/psr: Unify panel replay enable/disable sink Jouni Högander
2024-04-02  9:50 ` [PATCH v4 09/19] drm/i915/psr: Panel replay has to be enabled before link training Jouni Högander
2024-04-02  9:50 ` [PATCH v4 10/19] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-04-02  9:50 ` [PATCH v4 11/19] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-04-02  9:50 ` [PATCH v4 12/19] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-04-02  9:50 ` [PATCH v4 13/19] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-04-02  9:50 ` [PATCH v4 14/19] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-04-02  9:50 ` [PATCH v4 15/19] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status Jouni Högander
2024-04-02  9:50 ` [PATCH v4 16/19] drm/i915/psr: Do not apply workarounds in case of panel replay Jouni Högander
2024-04-02  9:50 ` [PATCH v4 17/19] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-04-02  9:50 ` [PATCH v4 18/19] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-04-02  9:50 ` [PATCH v4 19/19] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-04-02 11:57 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev4) Patchwork
2024-04-02 11:58 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-02 12:07 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402095011.200558-2-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.