All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@lists.linux.dev, Mike Snitzer <snitzer@redhat.com>,
	linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v4 24/28] block: Move zone related debugfs attribute to blk-zoned.c
Date: Tue,  2 Apr 2024 21:39:03 +0900	[thread overview]
Message-ID: <20240402123907.512027-25-dlemoal@kernel.org> (raw)
In-Reply-To: <20240402123907.512027-1-dlemoal@kernel.org>

block/blk-mq-debugfs-zone.c contains a single debugfs attribute
function. Defining this outside of block/blk-zoned.c does not really
help in any way, so move this zone related debugfs attribute to
block/blk-zoned.c and delete block/blk-mq-debugfs-zone.c.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
 block/Kconfig                |  4 ----
 block/Makefile               |  1 -
 block/blk-mq-debugfs-zoned.c | 22 ----------------------
 block/blk-mq-debugfs.h       |  2 +-
 block/blk-zoned.c            | 20 ++++++++++++++++++++
 5 files changed, 21 insertions(+), 28 deletions(-)
 delete mode 100644 block/blk-mq-debugfs-zoned.c

diff --git a/block/Kconfig b/block/Kconfig
index 1de4682d48cc..9f647149fbee 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -198,10 +198,6 @@ config BLK_DEBUG_FS
 	Unless you are building a kernel for a tiny system, you should
 	say Y here.
 
-config BLK_DEBUG_FS_ZONED
-       bool
-       default BLK_DEBUG_FS && BLK_DEV_ZONED
-
 config BLK_SED_OPAL
 	bool "Logic for interfacing with Opal enabled SEDs"
 	depends on KEYS
diff --git a/block/Makefile b/block/Makefile
index 46ada9dc8bbf..168150b9c510 100644
--- a/block/Makefile
+++ b/block/Makefile
@@ -33,7 +33,6 @@ obj-$(CONFIG_BLK_MQ_VIRTIO)	+= blk-mq-virtio.o
 obj-$(CONFIG_BLK_DEV_ZONED)	+= blk-zoned.o
 obj-$(CONFIG_BLK_WBT)		+= blk-wbt.o
 obj-$(CONFIG_BLK_DEBUG_FS)	+= blk-mq-debugfs.o
-obj-$(CONFIG_BLK_DEBUG_FS_ZONED)+= blk-mq-debugfs-zoned.o
 obj-$(CONFIG_BLK_SED_OPAL)	+= sed-opal.o
 obj-$(CONFIG_BLK_PM)		+= blk-pm.o
 obj-$(CONFIG_BLK_INLINE_ENCRYPTION)	+= blk-crypto.o blk-crypto-profile.o \
diff --git a/block/blk-mq-debugfs-zoned.c b/block/blk-mq-debugfs-zoned.c
deleted file mode 100644
index a77b099c34b7..000000000000
--- a/block/blk-mq-debugfs-zoned.c
+++ /dev/null
@@ -1,22 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copyright (C) 2017 Western Digital Corporation or its affiliates.
- */
-
-#include <linux/blkdev.h>
-#include "blk-mq-debugfs.h"
-
-int queue_zone_wlock_show(void *data, struct seq_file *m)
-{
-	struct request_queue *q = data;
-	unsigned int i;
-
-	if (!q->disk->seq_zones_wlock)
-		return 0;
-
-	for (i = 0; i < q->disk->nr_zones; i++)
-		if (test_bit(i, q->disk->seq_zones_wlock))
-			seq_printf(m, "%u\n", i);
-
-	return 0;
-}
diff --git a/block/blk-mq-debugfs.h b/block/blk-mq-debugfs.h
index 9c7d4b6117d4..3ebe2c29b624 100644
--- a/block/blk-mq-debugfs.h
+++ b/block/blk-mq-debugfs.h
@@ -83,7 +83,7 @@ static inline void blk_mq_debugfs_unregister_rqos(struct rq_qos *rqos)
 }
 #endif
 
-#ifdef CONFIG_BLK_DEBUG_FS_ZONED
+#if defined(CONFIG_BLK_DEV_ZONED) && defined(CONFIG_BLK_DEBUG_FS)
 int queue_zone_wlock_show(void *data, struct seq_file *m);
 #else
 static inline int queue_zone_wlock_show(void *data, struct seq_file *m)
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index b0fafbb5b3f9..8ba05d468604 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -22,6 +22,7 @@
 
 #include "blk.h"
 #include "blk-mq-sched.h"
+#include "blk-mq-debugfs.h"
 
 #define ZONE_COND_NAME(name) [BLK_ZONE_COND_##name] = #name
 static const char *const zone_cond_name[] = {
@@ -1819,3 +1820,22 @@ int blk_revalidate_disk_zones(struct gendisk *disk)
 	return ret;
 }
 EXPORT_SYMBOL_GPL(blk_revalidate_disk_zones);
+
+#ifdef CONFIG_BLK_DEBUG_FS
+
+int queue_zone_wlock_show(void *data, struct seq_file *m)
+{
+	struct request_queue *q = data;
+	unsigned int i;
+
+	if (!q->disk->seq_zones_wlock)
+		return 0;
+
+	for (i = 0; i < q->disk->nr_zones; i++)
+		if (test_bit(i, q->disk->seq_zones_wlock))
+			seq_printf(m, "%u\n", i);
+
+	return 0;
+}
+
+#endif
-- 
2.44.0


  parent reply	other threads:[~2024-04-02 12:39 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 12:38 [PATCH v4 00/28] Zone write plugging Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 01/28] block: Restore sector of flush requests Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 02/28] block: Remove req_bio_endio() Damien Le Moal
2024-04-02 18:02   ` Hannes Reinecke
2024-04-02 12:38 ` [PATCH v4 03/28] block: Introduce blk_zone_update_request_bio() Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 04/28] block: Introduce bio_straddles_zones() and bio_offset_from_zone_start() Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 05/28] block: Allow using bio_attempt_back_merge() internally Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 06/28] block: Remember zone capacity when revalidating zones Damien Le Moal
2024-04-02 18:04   ` Hannes Reinecke
2024-04-02 12:38 ` [PATCH v4 07/28] block: Introduce zone write plugging Damien Le Moal
2024-04-02 16:12   ` Christoph Hellwig
2024-04-02 23:38     ` Damien Le Moal
2024-04-03  1:01       ` Jens Axboe
2024-04-03  1:02         ` Damien Le Moal
2024-04-02 18:26   ` Hannes Reinecke
2024-04-03  0:33     ` Damien Le Moal
2024-04-03  4:23   ` kernel test robot
2024-04-02 12:38 ` [PATCH v4 08/28] block: Fake max open zones limit when there is no limit Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 09/28] block: Allow zero value of max_zone_append_sectors queue limit Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 10/28] block: Implement zone append emulation Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 11/28] block: Allow BIO-based drivers to use blk_revalidate_disk_zones() Damien Le Moal
2024-04-03  6:41   ` Hannes Reinecke
2024-04-02 12:38 ` [PATCH v4 12/28] dm: Use the block layer zone append emulation Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 13/28] scsi: sd: " Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 14/28] ublk_drv: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 15/28] null_blk: " Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 16/28] null_blk: Introduce zone_append_max_sectors attribute Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 17/28] null_blk: Introduce fua attribute Damien Le Moal
2024-04-03  3:56   ` Chaitanya Kulkarni
2024-04-03  3:58     ` Damien Le Moal
2024-04-03  4:43       ` Christoph Hellwig
2024-04-02 12:38 ` [PATCH v4 18/28] nvmet: zns: Do not reference the gendisk conv_zones_bitmap Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 19/28] block: Remove BLK_STS_ZONE_RESOURCE Damien Le Moal
2024-04-02 12:38 ` [PATCH v4 20/28] block: Simplify blk_revalidate_disk_zones() interface Damien Le Moal
2024-04-02 12:39 ` [PATCH v4 21/28] block: mq-deadline: Remove support for zone write locking Damien Le Moal
2024-04-02 12:39 ` [PATCH v4 22/28] block: Remove elevator required features Damien Le Moal
2024-04-02 12:39 ` [PATCH v4 23/28] block: Do not check zone type in blk_check_zone_append() Damien Le Moal
2024-04-02 12:39 ` Damien Le Moal [this message]
2024-04-02 12:39 ` [PATCH v4 25/28] block: Replace zone_wlock debugfs entry with zone_wplugs entry Damien Le Moal
2024-04-03  6:43   ` Hannes Reinecke
2024-04-02 12:39 ` [PATCH v4 26/28] block: Remove zone write locking Damien Le Moal
2024-04-02 16:03   ` Christoph Hellwig
2024-04-03  6:43   ` Hannes Reinecke
2024-04-02 12:39 ` [PATCH v4 27/28] block: Do not force select mq-deadline with CONFIG_BLK_DEV_ZONED Damien Le Moal
2024-04-02 12:39 ` [PATCH v4 28/28] block: Do not special-case plugging of zone write operations Damien Le Moal
2024-04-03  8:15 ` [PATCH v4 00/28] Zone write plugging Hans Holmberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402123907.512027-25-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.