All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Animesh Manna" <animesh.manna@intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>,
	"Kunal Joshi" <kunal1.joshi@intel.com>
Subject: [PATCH v5 19/19] drm/i915/psr: Add panel replay sel update support to debugfs interface
Date: Wed,  3 Apr 2024 12:00:13 +0300	[thread overview]
Message-ID: <20240403090013.54296-20-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240403090013.54296-1-jouni.hogander@intel.com>

Add panel replay selective update support to debugfs status interface. In
case of sink supporting panel replay we will print out:

Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes

and PSR mode will look like this if printing out enabled panel replay
selective update:

PSR mode: Panel Replay Selective Update Enabled

Current PSR and panel replay printouts remain same.

Cc: Kunal Joshi <kunal1.joshi@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 50bb3739d197..3d564276273d 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -3564,7 +3564,9 @@ static int intel_psr_status(struct seq_file *m, struct intel_dp *intel_dp)
 
 	if (psr->sink_support)
 		seq_printf(m, " [0x%02x]", intel_dp->psr_dpcd[0]);
-	seq_printf(m, ", Panel Replay = %s\n", str_yes_no(psr->sink_panel_replay_support));
+	seq_printf(m, ", Panel Replay = %s", str_yes_no(psr->sink_panel_replay_support));
+	seq_printf(m, ", Panel Replay Selective Update = %s\n",
+		   str_yes_no(psr->sink_panel_replay_su_support));
 
 	if (!(psr->sink_support || psr->sink_panel_replay_support))
 		return 0;
@@ -3573,9 +3575,10 @@ static int intel_psr_status(struct seq_file *m, struct intel_dp *intel_dp)
 	mutex_lock(&psr->lock);
 
 	if (psr->panel_replay_enabled)
-		status = "Panel Replay Enabled";
+		status = psr->sel_update_enabled ? "Panel Replay Selective Update Enabled" :
+			"Panel Replay Enabled";
 	else if (psr->enabled)
-		status = psr->sel_update_enabled ? "PSR2 enabled" : "PSR1 enabled";
+		status = psr->sel_update_enabled ? "PSR2" : "PSR1";
 	else
 		status = "disabled";
 	seq_printf(m, "PSR mode: %s\n", status);
-- 
2.34.1


  parent reply	other threads:[~2024-04-03  9:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03  8:59 [PATCH v5 00/19] Panel replay selective update support Jouni Högander
2024-04-03  8:59 ` [PATCH v5 01/19] drm/i915/psr: Add some documentation of variables used in psr code Jouni Högander
2024-04-03  8:59 ` [PATCH v5 02/19] drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well Jouni Högander
2024-04-03  8:59 ` [PATCH v5 03/19] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay Jouni Högander
2024-04-03  8:59 ` [PATCH v5 04/19] drm/i915/psr: Do not update phy power state in case of non-eDP " Jouni Högander
2024-04-05 11:00   ` Manna, Animesh
2024-04-03  8:59 ` [PATCH v5 05/19] drm/i915/psr: Check possible errors for panel replay as well Jouni Högander
2024-04-03  9:00 ` [PATCH v5 06/19] drm/i915/psr: Do not write registers/bits not applicable for panel replay Jouni Högander
2024-04-05 11:03   ` Manna, Animesh
2024-04-03  9:00 ` [PATCH v5 07/19] drm/i915/psr: Call intel_psr_init_dpcd in intel_dp_detect Jouni Högander
2024-04-05  9:58   ` Manna, Animesh
2024-04-03  9:00 ` [PATCH v5 08/19] drm/i915/psr: Unify panel replay enable/disable sink Jouni Högander
2024-04-05 11:06   ` Manna, Animesh
2024-04-03  9:00 ` [PATCH v5 09/19] drm/i915/psr: Panel replay has to be enabled before link training Jouni Högander
2024-04-03  9:00 ` [PATCH v5 10/19] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-04-03  9:00 ` [PATCH v5 11/19] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-04-03  9:00 ` [PATCH v5 12/19] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-04-03  9:00 ` [PATCH v5 13/19] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-04-03  9:00 ` [PATCH v5 14/19] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-04-03  9:00 ` [PATCH v5 15/19] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status Jouni Högander
2024-04-03  9:00 ` [PATCH v5 16/19] drm/i915/psr: Do not apply workarounds in case of panel replay Jouni Högander
2024-04-03  9:00 ` [PATCH v5 17/19] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-04-03  9:00 ` [PATCH v5 18/19] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-04-03  9:00 ` Jouni Högander [this message]
2024-04-03  9:46 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev5) Patchwork
2024-04-03  9:46 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-03  9:52 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-03 16:33 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403090013.54296-20-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.