From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
alexandre.torgue@foss.st.com, andrew@lunn.ch, cjubran@nvidia.com,
corbet@lwn.net, davem@davemloft.net, dtatulea@nvidia.com,
edumazet@google.com, gal@nvidia.com, hkallweit1@gmail.com,
jacob.e.keller@intel.com, jiri@resnulli.us, joabreu@synopsys.com,
justinstitt@google.com, kory.maincent@bootlin.com,
kuba@kernel.org, leon@kernel.org, liuhangbin@gmail.com,
maxime.chevallier@bootlin.com, pabeni@redhat.com,
paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
rdunlap@infradead.org, richardcochran@gmail.com,
saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev,
vladimir.oltean@nxp.com, wojciech.drewek@intel.com,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH net-next v2 5/6] netlink: specs: ethtool: add header-flags enumeration
Date: Wed, 3 Apr 2024 14:28:43 -0700 [thread overview]
Message-ID: <20240403212931.128541-6-rrameshbabu@nvidia.com> (raw)
In-Reply-To: <20240403212931.128541-1-rrameshbabu@nvidia.com>
Enable specifying header flags using enumerated entries in the spec file
rather than raw flag values.
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
---
Documentation/netlink/specs/ethtool.yaml | 5 +++++
include/uapi/linux/ethtool_netlink.h | 11 +++++------
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index f5aa1e7f3383..bae3bb013787 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -16,6 +16,10 @@ definitions:
name: stringset
type: enum
entries: []
+ -
+ name: header-flags
+ type: flags
+ entries: [ compact-bitset, omit-reply, stats ]
attribute-sets:
-
@@ -30,6 +34,7 @@ attribute-sets:
-
name: flags
type: u32
+ enum: header-flags
-
name: bitset-bit
diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 8dfd714c2308..34a4a64262b2 100644
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -117,12 +117,11 @@ enum {
/* request header */
-/* use compact bitsets in reply */
-#define ETHTOOL_FLAG_COMPACT_BITSETS (1 << 0)
-/* provide optional reply for SET or ACT requests */
-#define ETHTOOL_FLAG_OMIT_REPLY (1 << 1)
-/* request statistics, if supported by the driver */
-#define ETHTOOL_FLAG_STATS (1 << 2)
+enum ethtool_header_flags {
+ ETHTOOL_FLAG_COMPACT_BITSETS = 1 << 0, /* use compact bitsets in reply */
+ ETHTOOL_FLAG_OMIT_REPLY = 1 << 1, /* provide optional reply for SET or ACT requests */
+ ETHTOOL_FLAG_STATS = 1 << 2, /* request statistics, if supported by the driver */
+};
#define ETHTOOL_FLAG_ALL (ETHTOOL_FLAG_COMPACT_BITSETS | \
ETHTOOL_FLAG_OMIT_REPLY | \
--
2.42.0
next prev parent reply other threads:[~2024-04-03 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 21:28 [PATCH net-next v2 0/6] ethtool HW timestamping statistics Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 1/6] ethtool: add interface to read Tx hardware " Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 2/6] net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port timestamping CQ Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 3/6] net/mlx5e: Introduce timestamps statistic counter for Tx DMA layer Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 4/6] net/mlx5e: Implement ethtool hardware timestamping statistics Rahul Rameshbabu
2024-04-03 21:28 ` Rahul Rameshbabu [this message]
2024-04-03 21:28 ` [PATCH RFC v2 5/6] tools: ynl: ethtool.py: Make tool invokable from any CWD Rahul Rameshbabu
2024-04-03 21:34 ` Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 6/6] tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get operation Rahul Rameshbabu
2024-04-06 6:10 ` [PATCH net-next v2 0/6] ethtool HW timestamping statistics patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403212931.128541-6-rrameshbabu@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=saeed@kernel.org \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.