All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Vidya Srinivas <vidya.srinivas@intel.com>,
	Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH v2 04/17] drm/i915: Disable live M/N updates when using bigjoiner
Date: Fri,  5 Apr 2024 00:34:28 +0300	[thread overview]
Message-ID: <20240404213441.17637-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240404213441.17637-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

All joined pipes share the same transcoder/timing generator.
Currently we just do the commits per-pipe, which doesn't really
work if we need to change the timings at the same time. For
now just disable live M/N updates when bigjoiner is needed.

Tested-by: Vidya Srinivas <vidya.srinivas@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 8b67cd62f188..4552005caae2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2752,7 +2752,11 @@ intel_dp_drrs_compute_config(struct intel_connector *connector,
 		intel_panel_downclock_mode(connector, &pipe_config->hw.adjusted_mode);
 	int pixel_clock;
 
-	if (has_seamless_m_n(connector))
+	/*
+	 * FIXME all joined pipes share the same transcoder.
+	 * Need to account for that when updating M/N live.
+	 */
+	if (has_seamless_m_n(connector) && !pipe_config->bigjoiner_pipes)
 		pipe_config->update_m_n = true;
 
 	if (!can_enable_drrs(connector, pipe_config, downclock_mode)) {
-- 
2.43.2


  parent reply	other threads:[~2024-04-04 21:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 21:34 [PATCH v2 00/17] drm/i915: Bigjoiner modeset sequence redesign and MST support Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 01/17] drm/i915: Update pipes in reverse order for bigjoiner Ville Syrjala
2024-04-05 12:56   ` Murthy, Arun R
2024-04-08 12:46     ` Ville Syrjälä
2024-04-05 13:42   ` Kulkarni, Vandita
2024-04-05 19:45     ` Ville Syrjälä
2024-04-04 21:34 ` [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used Ville Syrjala
2024-04-05  6:58   ` Hogander, Jouni
2024-04-05 12:58     ` Murthy, Arun R
2024-04-05 13:00     ` Murthy, Arun R
2024-04-05 15:45       ` Murthy, Arun R
2024-04-05 19:34     ` Ville Syrjälä
2024-04-08  5:09       ` Hogander, Jouni
2024-04-04 21:34 ` [PATCH v2 03/17] drm/i915: Disable port sync " Ville Syrjala
2024-04-04 21:34 ` Ville Syrjala [this message]
2024-04-04 21:34 ` [PATCH v2 05/17] drm/i915/vrr: Disable VRR when using bigjoiner Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 06/17] drm/i915: Fix intel_modeset_pipe_config_late() for bigjoiner Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 07/17] drm/i915: s/intel_dp_can_bigjoiner()/intel_dp_has_bigjoiner()/ Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 08/17] drm/i915: Extract intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 09/17] drm/i915/mst: Check intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 10/17] drm/i915: Pass connector to intel_dp_need_bigjoiner() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 11/17] drm/i915: Introduce intel_crtc_joined_pipe_mask() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 12/17] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 13/17] drm/i915: Utilize intel_crtc_joined_pipe_mask() more Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 14/17] drm/i915: Handle joined pipes inside hsw_crtc_disable() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 15/17] drm/i915: Handle joined pipes inside hsw_crtc_enable() Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 16/17] drm/i915/mst: Add bigjoiner handling to MST modeset sequence Ville Syrjala
2024-04-04 21:34 ` [PATCH v2 17/17] drm/i915: Allow bigjoiner for MST Ville Syrjala
2024-04-04 22:16 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev2) Patchwork
2024-04-04 22:16 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-04 22:25 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-05  1:46 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev3) Patchwork
2024-04-05  1:46 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-05  1:51 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-05 14:25 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404213441.17637-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vidya.srinivas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.