From: Krzysztof Kozlowski <krzk@kernel.org> To: Conor Dooley <conor@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lars Povlsen <lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Daniel Machon <daniel.machon@microchip.com>, UNGLinuxDriver@microchip.com, Bjarni Jonasson <bjarni.jonasson@microchip.com>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: horatiu.vultur@microchip.com, steen.hegelund@microchip.com, Krzysztof Kozlowski <krzk@kernel.org> Subject: [RFT PATCH v2 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Date: Fri, 5 Apr 2024 21:04:18 +0200 [thread overview] Message-ID: <20240405190419.74162-9-krzk@kernel.org> (raw) In-Reply-To: <20240405190419.74162-1-krzk@kernel.org> Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Then in commit d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch node") one SPI mux was removed, while keeping the SPI NOR flash node. This still leaves duplicated SPI nodes under same chip select 0, reported by dtc W=1 warnings: sparx5_pcb134_board.dtsi:277.10-281.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Steen Hegelund confirmed that in fact there is a SPI mux, thus remove the duplicated node without the mux. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Not tested on hardware Changes in v2: 1. Remove SPI node without mux. --- arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index f165a409bc1d..2c5574734c9e 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -272,15 +272,6 @@ gpio@1 { }; }; -&spi0 { - status = "okay"; - flash@0 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0>; - }; -}; - &spi0 { status = "okay"; spi@0 { -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Conor Dooley <conor@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lars Povlsen <lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Daniel Machon <daniel.machon@microchip.com>, UNGLinuxDriver@microchip.com, Bjarni Jonasson <bjarni.jonasson@microchip.com>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: horatiu.vultur@microchip.com, steen.hegelund@microchip.com, Krzysztof Kozlowski <krzk@kernel.org> Subject: [RFT PATCH v2 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Date: Fri, 5 Apr 2024 21:04:18 +0200 [thread overview] Message-ID: <20240405190419.74162-9-krzk@kernel.org> (raw) In-Reply-To: <20240405190419.74162-1-krzk@kernel.org> Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Then in commit d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch node") one SPI mux was removed, while keeping the SPI NOR flash node. This still leaves duplicated SPI nodes under same chip select 0, reported by dtc W=1 warnings: sparx5_pcb134_board.dtsi:277.10-281.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Steen Hegelund confirmed that in fact there is a SPI mux, thus remove the duplicated node without the mux. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Not tested on hardware Changes in v2: 1. Remove SPI node without mux. --- arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index f165a409bc1d..2c5574734c9e 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -272,15 +272,6 @@ gpio@1 { }; }; -&spi0 { - status = "okay"; - flash@0 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0>; - }; -}; - &spi0 { status = "okay"; spi@0 { -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-05 19:05 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-05 19:04 [PATCH v2 01/10] arm64: dts: microchip: sparx5: fix mdio reg Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 02/10] arm64: dts: microchip: sparx5: correct serdes unit address Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 03/10] arm64: dts: microchip: sparx5_pcb134: add missing I2C mux unit addresses Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 04/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C mux node name with bindings Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-11 18:27 ` Rob Herring 2024-04-11 18:27 ` Rob Herring 2024-04-11 19:06 ` Krzysztof Kozlowski 2024-04-11 19:06 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 06/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 07/10] arm64: dts: microchip: sparx5_pcb134: drop LED unit addresses Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` [PATCH v2 08/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski [this message] 2024-04-05 19:04 ` [RFT PATCH v2 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Krzysztof Kozlowski 2024-04-08 8:44 ` Steen Hegelund 2024-04-08 8:44 ` Steen Hegelund 2024-04-05 19:04 ` [RFT PATCH v2 10/10] arm64: dts: microchip: sparx5_pcb135: " Krzysztof Kozlowski 2024-04-05 19:04 ` Krzysztof Kozlowski 2024-04-08 8:45 ` Steen Hegelund 2024-04-08 8:45 ` Steen Hegelund 2024-04-08 16:00 ` [PATCH v2 01/10] arm64: dts: microchip: sparx5: fix mdio reg Conor Dooley 2024-04-08 16:00 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240405190419.74162-9-krzk@kernel.org \ --to=krzk@kernel.org \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=bjarni.jonasson@microchip.com \ --cc=claudiu.beznea@tuxon.dev \ --cc=conor@kernel.org \ --cc=daniel.machon@microchip.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=horatiu.vultur@microchip.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lars.povlsen@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.