All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@lists.linux.dev, Mike Snitzer <snitzer@redhat.com>,
	linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v7 15/28] null_blk: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature
Date: Mon,  8 Apr 2024 10:41:15 +0900	[thread overview]
Message-ID: <20240408014128.205141-16-dlemoal@kernel.org> (raw)
In-Reply-To: <20240408014128.205141-1-dlemoal@kernel.org>

With zone write plugging enabled at the block layer level, a zoned
device can only ever see at most a single write operation per zone.
There is thus no need to request a block scheduler with strick per-zone
sequential write ordering control through the ELEVATOR_F_ZBD_SEQ_WRITE
feature. Removing this allows using a zoned null_blk device with any
scheduler, including "none".

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Tested-by: Hans Holmberg <hans.holmberg@wdc.com>
Tested-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 drivers/block/null_blk/zoned.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c
index 1689e2584104..8e217f8fadcd 100644
--- a/drivers/block/null_blk/zoned.c
+++ b/drivers/block/null_blk/zoned.c
@@ -165,7 +165,6 @@ int null_register_zoned_dev(struct nullb *nullb)
 	struct request_queue *q = nullb->q;
 
 	blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, q);
-	blk_queue_required_elevator_features(q, ELEVATOR_F_ZBD_SEQ_WRITE);
 	nullb->disk->nr_zones = bdev_nr_zones(nullb->disk->part0);
 	return blk_revalidate_disk_zones(nullb->disk, NULL);
 }
-- 
2.44.0


  parent reply	other threads:[~2024-04-08  1:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  1:41 [PATCH v7 00/28] Zone write plugging Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 01/28] block: Restore sector of flush requests Damien Le Moal
2024-04-08 15:42   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 02/28] block: Remove req_bio_endio() Damien Le Moal
2024-04-08 15:46   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 03/28] block: Introduce blk_zone_update_request_bio() Damien Le Moal
2024-04-08 15:47   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 04/28] block: Introduce bio_straddles_zones() and bio_offset_from_zone_start() Damien Le Moal
2024-04-08 15:50   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 05/28] block: Allow using bio_attempt_back_merge() internally Damien Le Moal
2024-04-08 15:51   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 06/28] block: Remember zone capacity when revalidating zones Damien Le Moal
2024-04-08 15:53   ` Johannes Thumshirn
2024-04-08  1:41 ` [PATCH v7 07/28] block: Introduce zone write plugging Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 08/28] block: Fake max open zones limit when there is no limit Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 09/28] block: Allow zero value of max_zone_append_sectors queue limit Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 10/28] block: Implement zone append emulation Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 11/28] block: Allow BIO-based drivers to use blk_revalidate_disk_zones() Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 12/28] dm: Use the block layer zone append emulation Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 13/28] scsi: sd: " Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 14/28] ublk_drv: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature Damien Le Moal
2024-04-08  1:41 ` Damien Le Moal [this message]
2024-04-08  1:41 ` [PATCH v7 16/28] null_blk: Introduce zone_append_max_sectors attribute Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 17/28] null_blk: Introduce fua attribute Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 18/28] nvmet: zns: Do not reference the gendisk conv_zones_bitmap Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 19/28] block: Remove BLK_STS_ZONE_RESOURCE Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 20/28] block: Simplify blk_revalidate_disk_zones() interface Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 21/28] block: mq-deadline: Remove support for zone write locking Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 22/28] block: Remove elevator required features Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 23/28] block: Do not check zone type in blk_check_zone_append() Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 24/28] block: Move zone related debugfs attribute to blk-zoned.c Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 25/28] block: Replace zone_wlock debugfs entry with zone_wplugs entry Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 26/28] block: Remove zone write locking Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 27/28] block: Do not force select mq-deadline with CONFIG_BLK_DEV_ZONED Damien Le Moal
2024-04-08  1:41 ` [PATCH v7 28/28] block: Do not special-case plugging of zone write operations Damien Le Moal
2024-04-08  6:02 ` [PATCH v7 00/28] Zone write plugging Christoph Hellwig
2024-04-12  0:19 ` Damien Le Moal
2024-04-17 14:45 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408014128.205141-16-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.