From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Yasunari Takiguchi <Yasunari.Takiguchi@sony.com>,
Jean-Christophe Trotin <jean-christophe.trotin@foss.st.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 3/6] media: platform: sti: hva: clk_unprepare unconditionally
Date: Wed, 10 Apr 2024 21:54:40 +0000 [thread overview]
Message-ID: <20240410-smatch-v1-3-785d009a852b@chromium.org> (raw)
In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org>
hva->clk cannot be NULL at this point. Simplify the code and make smatch
happy:
drivers/media/platform/st/sti/hva/hva-hw.c:412 hva_hw_probe() warn: 'hva->clk' from clk_prepare() not released on lines: 412
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/st/sti/hva/hva-hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/st/sti/hva/hva-hw.c b/drivers/media/platform/st/sti/hva/hva-hw.c
index fe4ea2e7f37e3..fcb18fb52fdd7 100644
--- a/drivers/media/platform/st/sti/hva/hva-hw.c
+++ b/drivers/media/platform/st/sti/hva/hva-hw.c
@@ -406,8 +406,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva)
err_disable:
pm_runtime_disable(dev);
err_clk:
- if (hva->clk)
- clk_unprepare(hva->clk);
+ clk_unprepare(hva->clk);
return ret;
}
--
2.44.0.478.gd926399ef9-goog
next prev parent reply other threads:[~2024-04-10 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 21:54 [PATCH 0/6] media: Fix warnings for smatch and sparse Ricardo Ribalda
2024-04-10 21:54 ` [PATCH 1/6] media: usb: siano: Fix allocation of urbs Ricardo Ribalda
2024-04-15 10:08 ` Hans Verkuil
2024-04-15 11:47 ` Hans Verkuil
2024-04-10 21:54 ` [PATCH 2/6] media: cxd2880: Replaze kmalloc with kzalloc Ricardo Ribalda
2024-04-10 21:54 ` Ricardo Ribalda [this message]
2024-04-10 21:54 ` [PATCH 4/6] media: v4l2-ctrls-core.c: Do not use iterator outside loop Ricardo Ribalda
2024-04-10 21:54 ` [PATCH 5/6] media: adv7180: Only request valids IRQs Ricardo Ribalda
2024-04-10 21:54 ` [PATCH 6/6] media: touchscreen: sur40: convert le16 to cpu before use Ricardo Ribalda
2024-04-15 21:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410-smatch-v1-3-785d009a852b@chromium.org \
--to=ribalda@chromium.org \
--cc=Yasunari.Takiguchi@sony.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jean-christophe.trotin@foss.st.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.