All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Date: Wed, 10 Apr 2024 13:24:27 +0200	[thread overview]
Message-ID: <20240410112418.6400-33-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>

I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-rk3x.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 086fdf262e7b..8c7367f289d3 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap,
 		spin_lock_irqsave(&i2c->lock, flags);
 
 		if (timeout == 0) {
-			dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n",
-				i2c_readl(i2c, REG_IPD), i2c->state);
-
 			/* Force a STOP condition without interrupt */
 			i2c_writel(i2c, 0, REG_IEN);
 			val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK;
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Date: Wed, 10 Apr 2024 13:24:27 +0200	[thread overview]
Message-ID: <20240410112418.6400-33-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>

I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-rk3x.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 086fdf262e7b..8c7367f289d3 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap,
 		spin_lock_irqsave(&i2c->lock, flags);
 
 		if (timeout == 0) {
-			dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n",
-				i2c_readl(i2c, REG_IPD), i2c->state);
-
 			/* Force a STOP condition without interrupt */
 			i2c_writel(i2c, 0, REG_IEN);
 			val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK;
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts
Date: Wed, 10 Apr 2024 13:24:27 +0200	[thread overview]
Message-ID: <20240410112418.6400-33-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>

I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-rk3x.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 086fdf262e7b..8c7367f289d3 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap,
 		spin_lock_irqsave(&i2c->lock, flags);
 
 		if (timeout == 0) {
-			dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n",
-				i2c_readl(i2c, REG_IPD), i2c->state);
-
 			/* Force a STOP condition without interrupt */
 			i2c_writel(i2c, 0, REG_IEN);
 			val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK;
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-04-10 11:25 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 11:24 [PATCH 00/18] i2c: remove printout on handled timeouts Wolfram Sang
2024-04-10 11:24 ` Wolfram Sang
2024-04-10 11:24 ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 01/18] i2c: at91-master: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 02/18] i2c: bcm-iproc: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 03/18] i2c: bcm2835: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 04/18] i2c: cadence: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-11  7:09   ` Michal Simek
2024-04-11  7:09     ` Michal Simek
2024-04-10 11:24 ` [PATCH 05/18] i2c: davinci: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 06/18] i2c: i801: " Wolfram Sang
2024-04-10 12:21   ` Andi Shyti
2024-04-11  7:02     ` Wolfram Sang
2024-04-11  9:16       ` Andi Shyti
2024-04-24  0:11   ` Andy Shevchenko
2024-04-10 11:24 ` [PATCH 07/18] i2c: img-scb: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 08/18] i2c: ismt: " Wolfram Sang
2024-04-24  0:11   ` Andy Shevchenko
2024-04-10 11:24 ` [PATCH 09/18] i2c: nomadik: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-12  8:39   ` Linus Walleij
2024-04-12  8:39     ` Linus Walleij
2024-04-10 11:24 ` [PATCH 10/18] i2c: omap: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 11/18] i2c: qcom-geni: " Wolfram Sang
2024-04-11  3:07   ` Bjorn Andersson
2024-04-10 11:24 ` [PATCH 12/18] i2c: qup: " Wolfram Sang
2024-04-11  3:08   ` Bjorn Andersson
2024-04-10 11:24 ` Wolfram Sang [this message]
2024-04-10 11:24   ` [PATCH 13/18] i2c: rk3x: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-11 18:59   ` Heiko Stuebner
2024-04-11 18:59     ` Heiko Stuebner
2024-04-11 18:59     ` Heiko Stuebner
2024-04-12 21:12   ` Dragan Simic
2024-04-12 21:12     ` Dragan Simic
2024-04-12 21:12     ` Dragan Simic
2024-04-13  6:38     ` Wolfram Sang
2024-04-13  6:38       ` Wolfram Sang
2024-04-13  6:38       ` Wolfram Sang
2024-04-13  6:44       ` Dragan Simic
2024-04-13  6:44         ` Dragan Simic
2024-04-13  6:44         ` Dragan Simic
2024-04-13  7:10         ` Wolfram Sang
2024-04-13  7:10           ` Wolfram Sang
2024-04-13  7:10           ` Wolfram Sang
2024-04-13  8:07           ` Dragan Simic
2024-04-13  8:07             ` Dragan Simic
2024-04-13  8:07             ` Dragan Simic
2024-04-13  7:58         ` Heiko Stübner
2024-04-13  7:58           ` Heiko Stübner
2024-04-13  7:58           ` Heiko Stübner
2024-04-13  8:12           ` Dragan Simic
2024-04-13  8:12             ` Dragan Simic
2024-04-13  8:12             ` Dragan Simic
2024-04-13 14:35           ` Wolfram Sang
2024-04-13 14:35             ` Wolfram Sang
2024-04-13 14:35             ` Wolfram Sang
2024-04-16 19:02             ` Andi Shyti
2024-04-16 19:02               ` Andi Shyti
2024-04-16 19:02               ` Andi Shyti
2024-04-10 11:24 ` [PATCH 14/18] i2c: sh_mobile: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 15/18] i2c: st: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 16/18] i2c: tegra: " Wolfram Sang
2024-04-10 11:24 ` [PATCH 17/18] i2c: uniphier-f: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-10 11:24 ` [PATCH 18/18] i2c: uniphier: " Wolfram Sang
2024-04-10 11:24   ` Wolfram Sang
2024-04-22 22:50 ` [PATCH 00/18] i2c: " Andi Shyti
2024-04-22 22:50   ` Andi Shyti
2024-04-22 22:50   ` Andi Shyti
2024-04-24  0:08 ` Andy Shevchenko
2024-04-24  0:08   ` Andy Shevchenko
2024-04-24  9:00   ` Wolfram Sang
2024-04-24  9:00     ` Wolfram Sang
2024-04-24  9:00     ` Wolfram Sang
2024-04-24 12:41     ` Andy Shevchenko
2024-04-24 12:41       ` Andy Shevchenko
2024-04-24 12:41       ` Andy Shevchenko
2024-04-24 12:44       ` Andy Shevchenko
2024-04-24 12:44         ` Andy Shevchenko
2024-04-24 12:44         ` Andy Shevchenko
2024-04-27 18:03         ` Wolfram Sang
2024-04-27 18:03           ` Wolfram Sang
2024-04-27 18:03           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410112418.6400-33-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.