All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Jassi Brar <jassisinghbrar@gmail.com>,
	Hari Nagalla <hnagalla@ti.com>, Nick Saulnier <nsaulnier@ti.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Andrew Davis <afd@ti.com>
Subject: [PATCH v2 07/13] mailbox: omap: Use devm_pm_runtime_enable() helper
Date: Wed, 10 Apr 2024 08:59:36 -0500	[thread overview]
Message-ID: <20240410135942.61667-8-afd@ti.com> (raw)
In-Reply-To: <20240410135942.61667-1-afd@ti.com>

Use device life-cycle managed runtime enable function to simplify probe
and exit paths.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/mailbox/omap-mailbox.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
index ea467931faf46..4f956c7b4072c 100644
--- a/drivers/mailbox/omap-mailbox.c
+++ b/drivers/mailbox/omap-mailbox.c
@@ -726,11 +726,11 @@ static int omap_mbox_probe(struct platform_device *pdev)
 		return ret;
 
 	platform_set_drvdata(pdev, mdev);
-	pm_runtime_enable(mdev->dev);
+	devm_pm_runtime_enable(mdev->dev);
 
 	ret = pm_runtime_resume_and_get(mdev->dev);
 	if (ret < 0)
-		goto unregister;
+		return ret;
 
 	/*
 	 * just print the raw revision register, the format is not
@@ -741,26 +741,14 @@ static int omap_mbox_probe(struct platform_device *pdev)
 
 	ret = pm_runtime_put_sync(mdev->dev);
 	if (ret < 0 && ret != -ENOSYS)
-		goto unregister;
+		return ret;
 
 	devm_kfree(&pdev->dev, finfoblk);
 	return 0;
-
-unregister:
-	pm_runtime_disable(mdev->dev);
-	return ret;
-}
-
-static void omap_mbox_remove(struct platform_device *pdev)
-{
-	struct omap_mbox_device *mdev = platform_get_drvdata(pdev);
-
-	pm_runtime_disable(mdev->dev);
 }
 
 static struct platform_driver omap_mbox_driver = {
 	.probe	= omap_mbox_probe,
-	.remove_new = omap_mbox_remove,
 	.driver	= {
 		.name = "omap-mailbox",
 		.pm = &omap_mbox_pm_ops,
-- 
2.39.2


  parent reply	other threads:[~2024-04-10 13:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 13:59 [PATCH v2 00/13] OMAP mailbox FIFO removal Andrew Davis
2024-04-10 13:59 ` [PATCH v2 01/13] mailbox: omap: Remove unused omap_mbox_{enable,disable}_irq() functions Andrew Davis
2024-04-10 13:59 ` [PATCH v2 02/13] mailbox: omap: Remove unused omap_mbox_request_channel() function Andrew Davis
2024-04-10 13:59 ` [PATCH v2 03/13] mailbox: omap: Move omap_mbox_irq_t into driver Andrew Davis
2024-04-10 13:59 ` [PATCH v2 04/13] mailbox: omap: Move fifo size check to point of use Andrew Davis
2024-04-10 13:59 ` [PATCH v2 05/13] mailbox: omap: Remove unneeded header omap-mailbox.h Andrew Davis
2024-04-10 13:59 ` [PATCH v2 06/13] mailbox: omap: Remove device class Andrew Davis
2024-04-10 13:59 ` Andrew Davis [this message]
2024-04-10 13:59 ` [PATCH v2 08/13] mailbox: omap: Merge mailbox child node setup loops Andrew Davis
2024-04-10 13:59 ` [PATCH v2 09/13] mailbox: omap: Use function local struct mbox_controller Andrew Davis
2024-04-10 13:59 ` [PATCH v2 10/13] mailbox: omap: Use mbox_controller channel list directly Andrew Davis
2024-04-10 13:59 ` [PATCH v2 11/13] mailbox: omap: Remove mbox_chan_to_omap_mbox() Andrew Davis
2024-04-10 13:59 ` [PATCH v2 12/13] mailbox: omap: Reverse FIFO busy check logic Andrew Davis
2024-04-10 13:59 ` [PATCH v2 13/13] mailbox: omap: Remove kernel FIFO message queuing Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410135942.61667-8-afd@ti.com \
    --to=afd@ti.com \
    --cc=andersson@kernel.org \
    --cc=hnagalla@ti.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=nsaulnier@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.