All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 02/13] hw/vfio/pci: Replace sprintf() by snprintf()
Date: Thu, 11 Apr 2024 12:15:38 +0200	[thread overview]
Message-ID: <20240411101550.99392-3-philmd@linaro.org> (raw)
In-Reply-To: <20240411101550.99392-1-philmd@linaro.org>

sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience. Use snprintf() instead.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/vfio/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 64780d1b79..cc545bcfbe 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2444,7 +2444,7 @@ bool vfio_pci_host_match(PCIHostDeviceAddress *addr, const char *name)
 {
     char tmp[13];
 
-    sprintf(tmp, "%04x:%02x:%02x.%1x", addr->domain,
+    snprintf(tmp, sizeof(tmp), "%04x:%02x:%02x.%1x", addr->domain,
             addr->bus, addr->slot, addr->function);
 
     return (strcmp(tmp, name) == 0);
-- 
2.41.0



  parent reply	other threads:[~2024-04-11 10:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 10:15 [PATCH v2 00/13] misc: Remove sprintf() due to macOS deprecation Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 01/13] ui/console-vc: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-04-11 10:21   ` Marc-André Lureau
2024-04-11 19:27   ` Richard Henderson
2024-04-11 10:15 ` Philippe Mathieu-Daudé [this message]
2024-04-11 19:42   ` [PATCH v2 02/13] hw/vfio/pci: " Richard Henderson
2024-04-11 10:15 ` [PATCH v2 03/13] hw/ppc/spapr: " Philippe Mathieu-Daudé
2024-04-11 19:47   ` Richard Henderson
2024-04-15  6:44   ` Harsh Prateek Bora
2024-04-11 10:15 ` [PATCH v2 04/13] hw/mips/malta: Add re-usable rng_seed_hex_new() method Philippe Mathieu-Daudé
2024-04-11 20:07   ` Richard Henderson
2024-04-11 20:31     ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 05/13] hw/mips/malta: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 06/13] system/qtest: Replace sprintf() by g_string_append_printf() Philippe Mathieu-Daudé
2024-04-11 20:13   ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 07/13] util/hexdump: Rename @offset argument in qemu_hexdump_line() Philippe Mathieu-Daudé
2024-04-11 20:34   ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 08/13] util/hexdump: Have qemu_hexdump_line() return heap allocated buffer Philippe Mathieu-Daudé
2024-04-11 20:47   ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 09/13] util/hexdump: Replace sprintf() by g_string_append_printf() Philippe Mathieu-Daudé
2024-04-11 20:43   ` Philippe Mathieu-Daudé
2024-04-11 20:50     ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 10/13] hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf() Philippe Mathieu-Daudé
2024-04-11 20:53   ` Richard Henderson
2024-04-11 10:15 ` [PATCH v2 11/13] hw/ide/atapi: " Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 12/13] hw/dma/pl330: " Philippe Mathieu-Daudé
2024-04-11 10:15 ` [PATCH v2 13/13] backends/tpm: " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240411101550.99392-3-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.