From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Umang Jain <umang.jain@ideasonboard.com>,
Tommaso Merciai <tomm.merciai@gmail.com>
Subject: [PATCH v6 4/6] media: imx335: Use integer values for size registers
Date: Fri, 12 Apr 2024 21:30:37 +0530 [thread overview]
Message-ID: <20240412160039.276743-5-umang.jain@ideasonboard.com> (raw)
In-Reply-To: <20240412160039.276743-1-umang.jain@ideasonboard.com>
Consider integer values for registers that are related to various
sizes in the register map. This helps in improving the overall
readability.
No functional changes intended in this patch.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
drivers/media/i2c/imx335.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index ee22304f827e..7548518359bc 100644
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -251,12 +251,12 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
{ IMX335_REG_MODE_SELECT, 0x01 },
{ IMX335_REG_MASTER_MODE, 0x00 },
{ IMX335_REG_WINMODE, 0x04 },
- { IMX335_REG_HTRIMMING_START, 0x0180 },
- { IMX335_REG_HNUM, 0x0a20 },
- { IMX335_REG_Y_OUT_SIZE, 0x0794 },
- { IMX335_REG_AREA3_ST_ADR_1, 0x00b0 },
- { IMX335_REG_AREA3_WIDTH_1, 0x0f58 },
- { IMX335_REG_OPB_SIZE_V, 0x00 },
+ { IMX335_REG_HTRIMMING_START, 384 },
+ { IMX335_REG_HNUM, 2592 },
+ { IMX335_REG_Y_OUT_SIZE, 1940 },
+ { IMX335_REG_AREA3_ST_ADR_1, 176 },
+ { IMX335_REG_AREA3_WIDTH_1, 3928 },
+ { IMX335_REG_OPB_SIZE_V, 0 },
{ IMX335_REG_XVS_XHS_DRV, 0x00 },
{ CCI_REG8(0x3288), 0x21 },
{ CCI_REG8(0x328a), 0x02 },
--
2.43.0
next prev parent reply other threads:[~2024-04-12 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 16:00 [PATCH v6 0/6] media: imx335: 2/4 lane ops and improvements Umang Jain
2024-04-12 16:00 ` [PATCH v6 1/6] media: imx335: Support 2 or 4 lane operation modes Umang Jain
2024-04-12 16:00 ` [PATCH v6 2/6] media: imx335: Parse fwnode properties Umang Jain
2024-04-12 16:00 ` [PATCH v6 3/6] media: imx335: Use V4L2 CCI for accessing sensor registers Umang Jain
2024-04-12 21:23 ` Kieran Bingham
2024-04-12 16:00 ` Umang Jain [this message]
2024-04-12 16:00 ` [PATCH v6 5/6] media: imx335: Fix active area height discrepency Umang Jain
2024-04-12 16:00 ` [PATCH v6 6/6] media: imx335: Limit analogue gain value Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412160039.276743-5-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=eagle.alexander923@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.