From: Krzysztof Kozlowski <krzk@kernel.org> To: "Lee Jones" <lee@kernel.org>, "Daniel Thompson" <daniel.thompson@linaro.org>, "Jingoo Han" <jingoohan1@gmail.com>, "Helge Deller" <deller@gmx.de>, "Bruno Prémont" <bonbons@linux-vserver.org>, "Jiri Kosina" <jikos@kernel.org>, "Benjamin Tissoires" <bentiss@kernel.org>, "Alexander Shiyan" <shc_work@mail.ru>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Shawn Guo" <shawnguo@kernel.org>, "Fabio Estevam" <festevam@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH 01/18] backlight: Constify lcd_ops Date: Sun, 14 Apr 2024 18:35:59 +0200 [thread overview] Message-ID: <20240414-video-backlight-lcd-ops-v1-1-9b37fcbf546a@kernel.org> (raw) In-Reply-To: <20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org> 'struct lcd_ops' passed in lcd_device_register() is not modified by core backlight code, so it can be made const for code safety. This allows drivers to also define the structure as const. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/video/backlight/lcd.c | 4 ++-- include/linux/lcd.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index ba4771cbd781..ceec90ca758b 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c @@ -191,7 +191,7 @@ static const struct class lcd_class = { * or a pointer to the newly allocated device. */ struct lcd_device *lcd_device_register(const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops) + void *devdata, const struct lcd_ops *ops) { struct lcd_device *new_ld; int rc; @@ -279,7 +279,7 @@ static int devm_lcd_device_match(struct device *dev, void *res, void *data) */ struct lcd_device *devm_lcd_device_register(struct device *dev, const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops) + void *devdata, const struct lcd_ops *ops) { struct lcd_device **ptr, *lcd; diff --git a/include/linux/lcd.h b/include/linux/lcd.h index 238fb1dfed98..68703a51dc53 100644 --- a/include/linux/lcd.h +++ b/include/linux/lcd.h @@ -61,7 +61,7 @@ struct lcd_device { points to something in the body of that driver, it is also invalid. */ struct mutex ops_lock; /* If this is NULL, the backing module is unloaded */ - struct lcd_ops *ops; + const struct lcd_ops *ops; /* Serialise access to set_power method */ struct mutex update_lock; /* The framebuffer notifier block */ @@ -102,10 +102,10 @@ static inline void lcd_set_power(struct lcd_device *ld, int power) } extern struct lcd_device *lcd_device_register(const char *name, - struct device *parent, void *devdata, struct lcd_ops *ops); + struct device *parent, void *devdata, const struct lcd_ops *ops); extern struct lcd_device *devm_lcd_device_register(struct device *dev, const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops); + void *devdata, const struct lcd_ops *ops); extern void lcd_device_unregister(struct lcd_device *ld); extern void devm_lcd_device_unregister(struct device *dev, struct lcd_device *ld); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: "Lee Jones" <lee@kernel.org>, "Daniel Thompson" <daniel.thompson@linaro.org>, "Jingoo Han" <jingoohan1@gmail.com>, "Helge Deller" <deller@gmx.de>, "Bruno Prémont" <bonbons@linux-vserver.org>, "Jiri Kosina" <jikos@kernel.org>, "Benjamin Tissoires" <bentiss@kernel.org>, "Alexander Shiyan" <shc_work@mail.ru>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Shawn Guo" <shawnguo@kernel.org>, "Fabio Estevam" <festevam@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH 01/18] backlight: Constify lcd_ops Date: Sun, 14 Apr 2024 18:35:59 +0200 [thread overview] Message-ID: <20240414-video-backlight-lcd-ops-v1-1-9b37fcbf546a@kernel.org> (raw) In-Reply-To: <20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org> 'struct lcd_ops' passed in lcd_device_register() is not modified by core backlight code, so it can be made const for code safety. This allows drivers to also define the structure as const. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/video/backlight/lcd.c | 4 ++-- include/linux/lcd.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index ba4771cbd781..ceec90ca758b 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c @@ -191,7 +191,7 @@ static const struct class lcd_class = { * or a pointer to the newly allocated device. */ struct lcd_device *lcd_device_register(const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops) + void *devdata, const struct lcd_ops *ops) { struct lcd_device *new_ld; int rc; @@ -279,7 +279,7 @@ static int devm_lcd_device_match(struct device *dev, void *res, void *data) */ struct lcd_device *devm_lcd_device_register(struct device *dev, const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops) + void *devdata, const struct lcd_ops *ops) { struct lcd_device **ptr, *lcd; diff --git a/include/linux/lcd.h b/include/linux/lcd.h index 238fb1dfed98..68703a51dc53 100644 --- a/include/linux/lcd.h +++ b/include/linux/lcd.h @@ -61,7 +61,7 @@ struct lcd_device { points to something in the body of that driver, it is also invalid. */ struct mutex ops_lock; /* If this is NULL, the backing module is unloaded */ - struct lcd_ops *ops; + const struct lcd_ops *ops; /* Serialise access to set_power method */ struct mutex update_lock; /* The framebuffer notifier block */ @@ -102,10 +102,10 @@ static inline void lcd_set_power(struct lcd_device *ld, int power) } extern struct lcd_device *lcd_device_register(const char *name, - struct device *parent, void *devdata, struct lcd_ops *ops); + struct device *parent, void *devdata, const struct lcd_ops *ops); extern struct lcd_device *devm_lcd_device_register(struct device *dev, const char *name, struct device *parent, - void *devdata, struct lcd_ops *ops); + void *devdata, const struct lcd_ops *ops); extern void lcd_device_unregister(struct lcd_device *ld); extern void devm_lcd_device_unregister(struct device *dev, struct lcd_device *ld); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-14 16:36 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-14 16:35 [PATCH 00/18] backlight: Constify lcd_ops Krzysztof Kozlowski 2024-04-14 16:35 ` Krzysztof Kozlowski 2024-04-14 16:35 ` Krzysztof Kozlowski [this message] 2024-04-14 16:35 ` [PATCH 01/18] " Krzysztof Kozlowski 2024-04-15 12:46 ` Daniel Thompson 2024-04-15 12:46 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 02/18] backlight: ams369fg06: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:47 ` Daniel Thompson 2024-04-15 12:47 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 03/18] backlight: corgi_lcd: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:48 ` Daniel Thompson 2024-04-15 12:48 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 04/18] backlight: hx8357: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:49 ` Daniel Thompson 2024-04-15 12:49 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 05/18] backlight: ili922x: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:49 ` Daniel Thompson 2024-04-15 12:49 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 06/18] backlight: ili9320: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:49 ` Daniel Thompson 2024-04-15 12:49 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 07/18] backlight: jornada720_lcd: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:52 ` Daniel Thompson 2024-04-15 12:52 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 08/18] backlight: l4f00242t03: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:53 ` Daniel Thompson 2024-04-15 12:53 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 09/18] backlight: lms283gf05: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:54 ` Daniel Thompson 2024-04-15 12:54 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 10/18] backlight: lms501kf03: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:54 ` Daniel Thompson 2024-04-15 12:54 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 11/18] backlight: ltv350qv: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:54 ` Daniel Thompson 2024-04-15 12:54 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 12/18] backlight: otm3225a: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:54 ` Daniel Thompson 2024-04-15 12:54 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 13/18] backlight: platform_lcd: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:55 ` Daniel Thompson 2024-04-15 12:55 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 14/18] backlight: tdo24m: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 12:55 ` Daniel Thompson 2024-04-15 12:55 ` Daniel Thompson 2024-04-14 16:36 ` [PATCH 15/18] HID: picoLCD: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-16 8:07 ` Bruno Prémont 2024-04-16 8:07 ` Bruno Prémont 2024-04-14 16:36 ` [PATCH 16/18] fbdev: clps711x: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-14 16:36 ` [PATCH 17/18] fbdev: imx: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-14 16:36 ` [PATCH 18/18] fbdev: omap: lcd_ams_delta: " Krzysztof Kozlowski 2024-04-14 16:36 ` Krzysztof Kozlowski 2024-04-15 6:56 ` [PATCH 00/18] backlight: " Thomas Zimmermann 2024-04-15 6:56 ` Thomas Zimmermann 2024-04-15 7:48 ` Krzysztof Kozlowski 2024-04-15 7:48 ` Krzysztof Kozlowski 2024-04-16 12:17 ` Lee Jones 2024-04-16 12:17 ` Lee Jones 2024-04-15 12:58 ` Daniel Thompson 2024-04-15 12:58 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240414-video-backlight-lcd-ops-v1-1-9b37fcbf546a@kernel.org \ --to=krzk@kernel.org \ --cc=bentiss@kernel.org \ --cc=bonbons@linux-vserver.org \ --cc=daniel.thompson@linaro.org \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=festevam@gmail.com \ --cc=imx@lists.linux.dev \ --cc=jikos@kernel.org \ --cc=jingoohan1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=shc_work@mail.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.