All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, Christian Brauner <brauner@kernel.org>
Subject: [git pull] fix lockdep false positives around sysfs/overlayfs interactions
Date: Sun, 14 Apr 2024 12:09:25 +0100	[thread overview]
Message-ID: <20240414110925.GS2118490@ZenIV> (raw)

syzbot has uncovered a class of lockdep false positives for
setups with sysfs being one of the backing layers in overlayfs.
The root cause is that of->mutex allocated when opening
a sysfs file read-only (which overlayfs might do) is confused
with of->mutex of a file opened writable (held in write to sysfs
file, which overlayfs won't do).

Assigning them separate lockdep classes fixes that bunch and it's
obviously safe.

The following changes since commit fec50db7033ea478773b159e0e2efb135270e3b7:

  Linux 6.9-rc3 (2024-04-07 13:22:46 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git tags/pull-sysfs-annotation-fix

for you to fetch changes up to 16b52bbee4823b01ab7fe3919373c981a38f3797:

  kernfs: annotate different lockdep class for of->mutex of writable files (2024-04-14 06:55:46 -0400)

----------------------------------------------------------------
	Get rid of lockdep false positives around sysfs/overlayfs

----------------------------------------------------------------
Amir Goldstein (1):
      kernfs: annotate different lockdep class for of->mutex of writable files

 fs/kernfs/file.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

             reply	other threads:[~2024-04-14 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-14 11:09 Al Viro [this message]
2024-04-14 18:47 ` [git pull] fix lockdep false positives around sysfs/overlayfs interactions pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240414110925.GS2118490@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.