All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	 Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,  owen <qwt9588@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	 Marek Vasut <marex@denx.de>,
	Adrien Grassein <adrien.grassein@gmail.com>,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	 Sam Ravnborg <sam@ravnborg.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Vinod Koul <vkoul@kernel.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	 Vinay Simha BN <simhavcs@gmail.com>,
	 Christopher Vollo <chris@renewoutreach.org>,
	 Jessica Zhang <quic_jesszhan@quicinc.com>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: [PATCH v3 1/9] drm/bridge: anx7625: Don't log an error when DSI host can't be found
Date: Mon, 15 Apr 2024 17:49:29 -0400	[thread overview]
Message-ID: <20240415-anx7625-defer-log-no-dsi-host-v3-1-619a28148e5c@collabora.com> (raw)
In-Reply-To: <20240415-anx7625-defer-log-no-dsi-host-v3-0-619a28148e5c@collabora.com>

Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.

Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 9d96d28d6fe8..02bf45005307 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -2066,10 +2066,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx)
 	};
 
 	host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node);
-	if (!host) {
-		DRM_DEV_ERROR(dev, "fail to find dsi host.\n");
-		return -EPROBE_DEFER;
-	}
+	if (!host)
+		return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n");
 
 	dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
 	if (IS_ERR(dsi)) {

-- 
2.44.0


  reply	other threads:[~2024-04-15 21:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 21:49 [PATCH v3 0/9] drm: Switch from dev_err to dev_err_probe for missing DSI host error path Nícolas F. R. A. Prado
2024-04-15 21:49 ` Nícolas F. R. A. Prado [this message]
2024-04-15 21:49 ` [PATCH v3 2/9] drm/bridge: icn6211: Don't log an error when DSI host can't be found Nícolas F. R. A. Prado
2024-04-15 21:49 ` [PATCH v3 3/9] drm/bridge: lt8912b: " Nícolas F. R. A. Prado
2024-04-15 21:49 ` [PATCH v3 4/9] drm/bridge: lt9611: " Nícolas F. R. A. Prado
2024-04-16  1:18   ` Dmitry Baryshkov
2024-04-15 21:49 ` [PATCH v3 5/9] drm/bridge: lt9611uxc: " Nícolas F. R. A. Prado
2024-04-16  1:18   ` Dmitry Baryshkov
2024-04-15 21:49 ` [PATCH v3 6/9] drm/bridge: tc358775: " Nícolas F. R. A. Prado
2024-04-15 21:49 ` [PATCH v3 7/9] drm/bridge: dpc3433: " Nícolas F. R. A. Prado
2024-04-15 21:49 ` [PATCH v3 8/9] drm/panel: novatek-nt35950: " Nícolas F. R. A. Prado
2024-04-16 17:43   ` Neil Armstrong
2024-04-15 21:49 ` [PATCH v3 9/9] drm/panel: truly-nt35597: " Nícolas F. R. A. Prado
2024-04-16 13:26 ` [PATCH v3 0/9] drm: Switch from dev_err to dev_err_probe for missing DSI host error path Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415-anx7625-defer-log-no-dsi-host-v3-1-619a28148e5c@collabora.com \
    --to=nfraprado@collabora.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=adrien.grassein@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=chris@renewoutreach.org \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=qwt9588@gmail.com \
    --cc=rfoss@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=simhavcs@gmail.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.