All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	 Martin KaFai Lau <martin.lau@linux.dev>,
	linux-arch@vger.kernel.org,  linux-kbuild@vger.kernel.org,
	bpf@vger.kernel.org,  Andrii Nakryiko <andrii@kernel.org>,
	Jiri Olsa <olsajiri@gmail.com>
Subject: [PATCH v4 2/3] vmlinux: Avoid weak reference to notes section
Date: Mon, 15 Apr 2024 18:20:44 +0200	[thread overview]
Message-ID: <20240415162041.2491523-7-ardb+git@google.com> (raw)
In-Reply-To: <20240415162041.2491523-5-ardb+git@google.com>

From: Ard Biesheuvel <ardb@kernel.org>

Weak references are references that are permitted to remain unsatisfied
in the final link. This means they cannot be implemented using place
relative relocations, resulting in GOT entries when using position
independent code generation.

The notes section should always exist, so the weak annotations can be
omitted.

Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 kernel/ksysfs.c | 4 ++--
 lib/buildid.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
index 495b69a71a5d..07fb5987b42b 100644
--- a/kernel/ksysfs.c
+++ b/kernel/ksysfs.c
@@ -228,8 +228,8 @@ KERNEL_ATTR_RW(rcu_normal);
 /*
  * Make /sys/kernel/notes give the raw contents of our kernel .notes section.
  */
-extern const void __start_notes __weak;
-extern const void __stop_notes __weak;
+extern const void __start_notes;
+extern const void __stop_notes;
 #define	notes_size (&__stop_notes - &__start_notes)
 
 static ssize_t notes_read(struct file *filp, struct kobject *kobj,
diff --git a/lib/buildid.c b/lib/buildid.c
index 898301b49eb6..7954dd92e36c 100644
--- a/lib/buildid.c
+++ b/lib/buildid.c
@@ -182,8 +182,8 @@ unsigned char vmlinux_build_id[BUILD_ID_SIZE_MAX] __ro_after_init;
  */
 void __init init_vmlinux_build_id(void)
 {
-	extern const void __start_notes __weak;
-	extern const void __stop_notes __weak;
+	extern const void __start_notes;
+	extern const void __stop_notes;
 	unsigned int size = &__stop_notes - &__start_notes;
 
 	build_id_parse_buf(&__start_notes, vmlinux_build_id, size);
-- 
2.44.0.683.g7961c838ac-goog


  parent reply	other threads:[~2024-04-15 16:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 16:20 [PATCH v4 0/3] kbuild: Avoid weak external linkage where possible Ard Biesheuvel
2024-04-15 16:20 ` [PATCH v4 1/3] kallsyms: Avoid weak references for kallsyms symbols Ard Biesheuvel
2024-04-23 13:44   ` Masahiro Yamada
2024-04-15 16:20 ` Ard Biesheuvel [this message]
2024-04-20 13:42   ` [PATCH v4 2/3] vmlinux: Avoid weak reference to notes section Masahiro Yamada
2024-04-15 16:20 ` [PATCH v4 3/3] btf: Avoid weak external references Ard Biesheuvel
2024-04-16 14:40 ` [PATCH v4 0/3] kbuild: Avoid weak external linkage where possible patchwork-bot+netdevbpf
2024-04-19  7:57   ` Ard Biesheuvel
2024-04-20 12:31     ` Masahiro Yamada
2024-04-20 12:35       ` Ard Biesheuvel
2024-04-20 13:41         ` Masahiro Yamada
2024-04-20 13:56           ` Ard Biesheuvel
2024-04-20 13:59             ` Ard Biesheuvel
2024-04-20 14:05               ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415162041.2491523-7-ardb+git@google.com \
    --to=ardb+git@google.com \
    --cc=andrii@kernel.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bpf@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=masahiroy@kernel.org \
    --cc=olsajiri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.