From: Andrey Albershteyn <aalbersh@redhat.com>
To: cem@kernel.org, linux-xfs@vger.kernel.org
Cc: Andrey Albershteyn <aalbersh@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: [PATCH v2 1/4] xfs_db: fix leak in flist_find_ftyp()
Date: Tue, 16 Apr 2024 22:23:59 +0200 [thread overview]
Message-ID: <20240416202402.724492-2-aalbersh@redhat.com> (raw)
In-Reply-To: <20240416202402.724492-1-aalbersh@redhat.com>
When count is zero fl reference is lost. Fix it by freeing the list.
Fixes: a0d79cb37a36 ("xfs_db: make flist_find_ftyp() to check for field existance on disk")
Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
db/flist.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/db/flist.c b/db/flist.c
index c81d229ab99c..0a6cc5fcee43 100644
--- a/db/flist.c
+++ b/db/flist.c
@@ -424,8 +424,10 @@ flist_find_ftyp(
if (f->ftyp == type)
return fl;
count = fcount(f, obj, startoff);
- if (!count)
+ if (!count) {
+ flist_free(fl);
continue;
+ }
fa = &ftattrtab[f->ftyp];
if (fa->subfld) {
flist_t *nfl;
--
2.42.0
next prev parent reply other threads:[~2024-04-16 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:23 [PATCH v2 0/4] xfsprogs random fixes found by Coverity scan Andrey Albershteyn
2024-04-16 20:23 ` Andrey Albershteyn [this message]
2024-04-16 20:24 ` [PATCH v2 2/4] xfs_repair: make duration take time_t Andrey Albershteyn
2024-04-16 21:00 ` Darrick J. Wong
2024-04-16 20:24 ` [PATCH v2 3/4] xfs_scrub: don't call phase_end if phase_rusage was not initialized Andrey Albershteyn
2024-04-16 20:24 ` [PATCH v2 4/4] xfs_fsr: convert fsrallfs to use time_t instead of int Andrey Albershteyn
2024-04-16 20:59 ` Darrick J. Wong
2024-04-16 20:51 ` [PATCH v2 0/4] xfsprogs random fixes found by Coverity scan Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416202402.724492-2-aalbersh@redhat.com \
--to=aalbersh@redhat.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.