All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 05/12] xen/arm: Conditional compilation of kernel_info.shm_mem member
Date: Thu, 18 Apr 2024 08:36:45 +0100	[thread overview]
Message-ID: <20240418073652.3622828-6-luca.fancellu@arm.com> (raw)
In-Reply-To: <20240418073652.3622828-1-luca.fancellu@arm.com>

The user of shm_mem member of the 'struct kernel_info' is only
the code managing the static shared memory feature, which can be
compiled out using CONFIG_STATIC_SHM, so in case the feature is
not requested, that member won't be used and will waste memory
space.

To address this issue, protect the member with the Kconfig parameter
and modify the signature of the only function using it to remove
any reference to the member from outside the static-shmem module.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>
---
v2:
 - add Michal R-by
 - Removed the signature modification of make_resv_memory_node from
   this patch
v1:
 - new patch
---
---
 xen/arch/arm/include/asm/kernel.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h
index d46f29ee6ce5..eb3cb7809ccf 100644
--- a/xen/arch/arm/include/asm/kernel.h
+++ b/xen/arch/arm/include/asm/kernel.h
@@ -39,7 +39,9 @@ struct kernel_info {
     void *fdt; /* flat device tree */
     paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */
     struct meminfo mem;
+#ifdef CONFIG_STATIC_SHM
     struct meminfo shm_mem;
+#endif
 
     /* kernel entry point */
     paddr_t entry;
@@ -80,10 +82,16 @@ struct kernel_info {
 
 #define kernel_info_get_mem(kinfo) (&(kinfo)->mem.common)
 
+#ifdef CONFIG_STATIC_SHM
+#define KERNEL_INFO_SHM_MEM_INIT .shm_mem.common.max_banks = NR_MEM_BANKS,
+#else
+#define KERNEL_INFO_SHM_MEM_INIT
+#endif
+
 #define KERNEL_INFO_INIT                        \
 {                                               \
     .mem.common.max_banks = NR_MEM_BANKS,       \
-    .shm_mem.common.max_banks = NR_MEM_BANKS,   \
+    KERNEL_INFO_SHM_MEM_INIT                    \
 }
 
 /*
-- 
2.34.1



  parent reply	other threads:[~2024-04-18  7:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  7:36 [PATCH v3 00/12] Static shared memory followup v2 - pt1 Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 01/12] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 02/12] xen/arm: avoid repetitive checking in process_shm_node Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 03/12] xen/arm: Pass struct kernel_info parameter to make_{resv,shm}_memory_node Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 04/12] xen/arm: Introduce a generic way to access memory bank structures Luca Fancellu
2024-04-18  7:36 ` Luca Fancellu [this message]
2024-04-18  7:36 ` [PATCH v3 06/12] xen/arm: Avoid code duplication in find_unallocated_memory Luca Fancellu
2024-04-18  8:33   ` Michal Orzel
2024-04-18  7:36 ` [PATCH v3 07/12] xen/arm: Avoid code duplication in check_reserved_regions_overlap Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 08/12] xen/arm: Introduce helper for static memory pages Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 09/12] xen/arm: Reduce struct membank size on static shared memory Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 10/12] xen/arm: remove shm holes from extended regions Luca Fancellu
2024-04-18 12:47   ` Michal Orzel
2024-04-18  7:36 ` [PATCH v3 11/12] xen/arm: fix duplicate /reserved-memory node in Dom0 Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes Luca Fancellu
2024-04-22  7:55   ` Michal Orzel
2024-04-22  8:07     ` Luca Fancellu
2024-04-22  9:26       ` Michal Orzel
2024-04-22 10:24         ` Julien Grall
2024-04-22 10:39           ` Luca Fancellu
2024-04-22 10:45             ` Julien Grall
2024-04-24 10:19           ` Julien Grall
2024-04-24 10:25             ` Luca Fancellu
2024-04-22 11:02   ` [PATCH v3.2 " Luca Fancellu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418073652.3622828-6-luca.fancellu@arm.com \
    --to=luca.fancellu@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.