All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 08/12] xen/arm: Introduce helper for static memory pages
Date: Thu, 18 Apr 2024 08:36:48 +0100	[thread overview]
Message-ID: <20240418073652.3622828-9-luca.fancellu@arm.com> (raw)
In-Reply-To: <20240418073652.3622828-1-luca.fancellu@arm.com>

Introduce a new helper function in the static-memory module
that can be called to manage static memory banks, this is
done to reuse the code when other modules would like to
manage static memory banks that are not part of the
reserved_mem structure, this is done because the static
shared memory banks will be removed from reserved_mem.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>
---
v2:
 - Add Michal R-by
 - Changed commit msg
v1:
 - new patch
---
---
 xen/arch/arm/include/asm/static-memory.h | 13 +++++++++++++
 xen/arch/arm/static-memory.c             | 12 +-----------
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/xen/arch/arm/include/asm/static-memory.h b/xen/arch/arm/include/asm/static-memory.h
index 3e3efd70c38d..804166e541ef 100644
--- a/xen/arch/arm/include/asm/static-memory.h
+++ b/xen/arch/arm/include/asm/static-memory.h
@@ -3,10 +3,23 @@
 #ifndef __ASM_STATIC_MEMORY_H_
 #define __ASM_STATIC_MEMORY_H_
 
+#include <xen/pfn.h>
 #include <asm/kernel.h>
 
 #ifdef CONFIG_STATIC_MEMORY
 
+static inline void init_staticmem_bank(const struct membank *bank)
+{
+    mfn_t bank_start = _mfn(PFN_UP(bank->start));
+    unsigned long bank_pages = PFN_DOWN(bank->size);
+    mfn_t bank_end = mfn_add(bank_start, bank_pages);
+
+    if ( mfn_x(bank_end) <= mfn_x(bank_start) )
+        return;
+
+    unprepare_staticmem_pages(mfn_to_page(bank_start), bank_pages, false);
+}
+
 void allocate_static_memory(struct domain *d, struct kernel_info *kinfo,
                             const struct dt_device_node *node);
 void assign_static_memory_11(struct domain *d, struct kernel_info *kinfo,
diff --git a/xen/arch/arm/static-memory.c b/xen/arch/arm/static-memory.c
index 34bd12696a53..d4585c5a0633 100644
--- a/xen/arch/arm/static-memory.c
+++ b/xen/arch/arm/static-memory.c
@@ -265,17 +265,7 @@ void __init init_staticmem_pages(void)
     for ( bank = 0 ; bank < reserved_mem->nr_banks; bank++ )
     {
         if ( reserved_mem->bank[bank].type == MEMBANK_STATIC_DOMAIN )
-        {
-            mfn_t bank_start = _mfn(PFN_UP(reserved_mem->bank[bank].start));
-            unsigned long bank_pages = PFN_DOWN(reserved_mem->bank[bank].size);
-            mfn_t bank_end = mfn_add(bank_start, bank_pages);
-
-            if ( mfn_x(bank_end) <= mfn_x(bank_start) )
-                return;
-
-            unprepare_staticmem_pages(mfn_to_page(bank_start),
-                                      bank_pages, false);
-        }
+            init_staticmem_bank(&reserved_mem->bank[bank]);
     }
 }
 
-- 
2.34.1



  parent reply	other threads:[~2024-04-18  7:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  7:36 [PATCH v3 00/12] Static shared memory followup v2 - pt1 Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 01/12] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 02/12] xen/arm: avoid repetitive checking in process_shm_node Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 03/12] xen/arm: Pass struct kernel_info parameter to make_{resv,shm}_memory_node Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 04/12] xen/arm: Introduce a generic way to access memory bank structures Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 05/12] xen/arm: Conditional compilation of kernel_info.shm_mem member Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 06/12] xen/arm: Avoid code duplication in find_unallocated_memory Luca Fancellu
2024-04-18  8:33   ` Michal Orzel
2024-04-18  7:36 ` [PATCH v3 07/12] xen/arm: Avoid code duplication in check_reserved_regions_overlap Luca Fancellu
2024-04-18  7:36 ` Luca Fancellu [this message]
2024-04-18  7:36 ` [PATCH v3 09/12] xen/arm: Reduce struct membank size on static shared memory Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 10/12] xen/arm: remove shm holes from extended regions Luca Fancellu
2024-04-18 12:47   ` Michal Orzel
2024-04-18  7:36 ` [PATCH v3 11/12] xen/arm: fix duplicate /reserved-memory node in Dom0 Luca Fancellu
2024-04-18  7:36 ` [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes Luca Fancellu
2024-04-22  7:55   ` Michal Orzel
2024-04-22  8:07     ` Luca Fancellu
2024-04-22  9:26       ` Michal Orzel
2024-04-22 10:24         ` Julien Grall
2024-04-22 10:39           ` Luca Fancellu
2024-04-22 10:45             ` Julien Grall
2024-04-24 10:19           ` Julien Grall
2024-04-24 10:25             ` Luca Fancellu
2024-04-22 11:02   ` [PATCH v3.2 " Luca Fancellu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418073652.3622828-9-luca.fancellu@arm.com \
    --to=luca.fancellu@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.