From: Wander Lairson Costa <wander@redhat.com>
To: Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
linux-kselftest@vger.kernel.org (open list:KERNEL UNIT TESTING
FRAMEWORK (KUnit)),
kunit-dev@googlegroups.com (open list:KERNEL UNIT TESTING
FRAMEWORK (KUnit)), linux-kernel@vger.kernel.org (open list)
Cc: Wander Lairson Costa <wander@redhat.com>
Subject: [PATCH 1/2] kunit: unregister the device on error
Date: Thu, 18 Apr 2024 10:17:52 -0300 [thread overview]
Message-ID: <20240418131754.58217-2-wander@redhat.com> (raw)
In-Reply-To: <20240418131754.58217-1-wander@redhat.com>
kunit_init_device() should unregister the device on bus register error.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
lib/kunit/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/kunit/device.c b/lib/kunit/device.c
index abc603730b8e..25c81ed465fb 100644
--- a/lib/kunit/device.c
+++ b/lib/kunit/device.c
@@ -51,7 +51,7 @@ int kunit_bus_init(void)
error = bus_register(&kunit_bus_type);
if (error)
- bus_unregister(&kunit_bus_type);
+ root_device_unregister(kunit_bus_device);
return error;
}
--
2.44.0
next prev parent reply other threads:[~2024-04-18 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:17 [PATCH 0/2] kunit: fix minor error path mistakes Wander Lairson Costa
2024-04-18 13:17 ` Wander Lairson Costa [this message]
2024-04-18 15:00 ` [PATCH 1/2] kunit: unregister the device on error Markus Elfring
2024-04-18 15:21 ` Wander Lairson Costa
2024-04-18 13:17 ` [PATCH 2/2] kunit: avoid memory leak on device register error Wander Lairson Costa
2024-04-18 15:24 ` Markus Elfring
2024-04-18 17:18 ` Wander Lairson Costa
2024-04-18 18:08 ` [ " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418131754.58217-2-wander@redhat.com \
--to=wander@redhat.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.