All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongbo Li <lihongbo22@huawei.com>
To: <xiang@kernel.org>, <chao@kernel.org>
Cc: <huyue2@coolpad.com>, <jefflexu@linux.alibaba.com>,
	<dhavale@google.com>, <linux-erofs@lists.ozlabs.org>,
	<linux-kernel@vger.kernel.org>, <lihongbo22@huawei.com>
Subject: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
Date: Wed, 24 Apr 2024 16:42:47 +0800	[thread overview]
Message-ID: <20240424084247.759432-1-lihongbo22@huawei.com> (raw)

When prepare_ondemand_read failed, wrong error message is printed.
The prepare_read is also implemented in cachefiles, so we amend it.

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
 fs/erofs/fscache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 8aff1a724805..62da538d91cb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
 		if (WARN_ON(len == 0))
 			source = NETFS_INVALID_READ;
 		if (source != NETFS_READ_FROM_CACHE) {
-			erofs_err(NULL, "prepare_read failed (source %d)", source);
+			erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
 			return -EIO;
 		}
 
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Hongbo Li via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: <xiang@kernel.org>, <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, huyue2@coolpad.com,
	lihongbo22@huawei.com, linux-erofs@lists.ozlabs.org
Subject: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed
Date: Wed, 24 Apr 2024 16:42:47 +0800	[thread overview]
Message-ID: <20240424084247.759432-1-lihongbo22@huawei.com> (raw)

When prepare_ondemand_read failed, wrong error message is printed.
The prepare_read is also implemented in cachefiles, so we amend it.

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
 fs/erofs/fscache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 8aff1a724805..62da538d91cb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
 		if (WARN_ON(len == 0))
 			source = NETFS_INVALID_READ;
 		if (source != NETFS_READ_FROM_CACHE) {
-			erofs_err(NULL, "prepare_read failed (source %d)", source);
+			erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
 			return -EIO;
 		}
 
-- 
2.34.1


             reply	other threads:[~2024-04-24  8:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24  8:42 Hongbo Li [this message]
2024-04-24  8:42 ` [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed Hongbo Li via Linux-erofs
2024-04-24 11:21 ` Jingbo Xu
2024-04-24 11:21   ` Jingbo Xu
2024-04-28  6:23 ` Chao Yu
2024-04-28  6:23   ` Chao Yu
     [not found] <20240424023945.420828-1-lihongbo22@huawei.com>
2024-04-24  3:29 ` Gao Xiang
2024-04-24  3:29   ` Gao Xiang
2024-04-24  8:44   ` Hongbo Li
2024-04-24  8:44     ` Hongbo Li via Linux-erofs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424084247.759432-1-lihongbo22@huawei.com \
    --to=lihongbo22@huawei.com \
    --cc=chao@kernel.org \
    --cc=dhavale@google.com \
    --cc=huyue2@coolpad.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.