All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jason Wang <jasowang@redhat.com>,
	 Dmitry Fleytman <dmitry.fleytman@gmail.com>,
	 Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>,
	 "Michael S. Tsirkin" <mst@redhat.com>,
	Luigi Rizzo <rizzo@iet.unipi.it>,
	 Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
	 Vincenzo Maffione <v.maffione@gmail.com>,
	 Andrew Melnychenko <andrew@daynix.com>,
	 Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v10 17/18] ebpf: Refactor tun_rss_steering_prog()
Date: Sun, 28 Apr 2024 16:01:00 +0900	[thread overview]
Message-ID: <20240428-rss-v10-17-73cbaa91aeb6@daynix.com> (raw)
In-Reply-To: <20240428-rss-v10-0-73cbaa91aeb6@daynix.com>

This saves branches and makes later BPF program changes easier.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tools/ebpf/rss.bpf.c | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/tools/ebpf/rss.bpf.c b/tools/ebpf/rss.bpf.c
index 77434435ac15..c989cb3cd82c 100644
--- a/tools/ebpf/rss.bpf.c
+++ b/tools/ebpf/rss.bpf.c
@@ -547,27 +547,23 @@ int tun_rss_steering_prog(struct __sk_buff *skb)
     config = bpf_map_lookup_elem(&tap_rss_map_configurations, &key);
     toe = bpf_map_lookup_elem(&tap_rss_map_toeplitz_key, &key);
 
-    if (config && toe) {
-        if (!config->redirect) {
-            return config->default_queue;
-        }
+    if (!config || !toe) {
+        return 0;
+    }
 
-        if (calculate_rss_hash(skb, config, toe, &hash)) {
-            __u32 table_idx = hash % config->indirections_len;
-            __u16 *queue = 0;
+    if (config->redirect && calculate_rss_hash(skb, config, toe, &hash)) {
+        __u32 table_idx = hash % config->indirections_len;
+        __u16 *queue = 0;
 
-            queue = bpf_map_lookup_elem(&tap_rss_map_indirection_table,
-                                        &table_idx);
+        queue = bpf_map_lookup_elem(&tap_rss_map_indirection_table,
+                                    &table_idx);
 
-            if (queue) {
-                return *queue;
-            }
+        if (queue) {
+            return *queue;
         }
-
-        return config->default_queue;
     }
 
-    return 0;
+    return config->default_queue;
 }
 
 char _license[] SEC("license") = "GPL v2";

-- 
2.44.0



  parent reply	other threads:[~2024-04-28  7:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28  7:00 [PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 01/18] tap: Remove tap_probe_vnet_hdr_len() Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 02/18] tap: Remove qemu_using_vnet_hdr() Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 03/18] net: Move virtio-net header length assertion Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 04/18] net: Remove receive_raw() Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 05/18] tap: Call tap_receive_iov() from tap_receive() Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 06/18] tap: Shrink zeroed virtio-net header Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 07/18] virtio-net: Do not propagate ebpf-rss-fds errors Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 08/18] virtio-net: Add only one queue pair when realizing Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 09/18] virtio-net: Copy header only when necessary Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 10/18] virtio-net: Shrink header byte swapping buffer Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 11/18] virtio-net: Disable RSS on reset Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 12/18] virtio-net: Unify the logic to update NIC state for RSS Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 13/18] virtio-net: Always set populate_hash Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 14/18] virtio-net: Do not write hashes to peer buffer Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 15/18] ebpf: Fix RSS error handling Akihiko Odaki
2024-04-28  7:00 ` [PATCH v10 16/18] ebpf: Return 0 when configuration fails Akihiko Odaki
2024-04-28  7:01 ` Akihiko Odaki [this message]
2024-04-28  7:01 ` [PATCH v10 18/18] ebpf: Add a separate target for skeleton Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240428-rss-v10-17-73cbaa91aeb6@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=andrew@daynix.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=v.maffione@gmail.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.