From: "André Draszik" <andre.draszik@linaro.org> To: Peter Griffin <peter.griffin@linaro.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>, "Will McVicker" <willmcvicker@google.com>, "Sam Protsenko" <semen.protsenko@linaro.org>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "André Draszik" <andre.draszik@linaro.org> Subject: [PATCH v2 4/4] arm64: dts: exynos: gs101: specify empty clocks for remaining pinctrl Date: Tue, 30 Apr 2024 10:49:49 +0100 [thread overview] Message-ID: <20240430-samsung-pinctrl-busclock-dts-v2-4-14fc988139dd@linaro.org> (raw) In-Reply-To: <20240430-samsung-pinctrl-busclock-dts-v2-0-14fc988139dd@linaro.org> The pinctrl instances hsi1, gsactrl, and gsacore need a clock for register access to work. Since we haven't implemented the relevant CMUs for the clocks required by these instances just add empty clocks for now so as to make the DT pass the validation checks. Once the clocks are implmented in the gs101 clock driver, these should be updated then. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v2: use empty clock instead of placeholder --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index f8fcbbb06e7b..c8a5eb8c7d45 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -1309,6 +1309,9 @@ usbdrd31_dwc3: usb@0 { pinctrl_hsi1: pinctrl@11840000 { compatible = "google,gs101-pinctrl"; reg = <0x11840000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; interrupts = <GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH 0>; }; @@ -1380,11 +1383,17 @@ wakeup-interrupt-controller { pinctrl_gsactrl: pinctrl@17940000 { compatible = "google,gs101-pinctrl"; reg = <0x17940000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; pinctrl_gsacore: pinctrl@17a80000 { compatible = "google,gs101-pinctrl"; reg = <0x17a80000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; cmu_top: clock-controller@1e080000 { -- 2.44.0.769.g3c40516874-goog
WARNING: multiple messages have this Message-ID (diff)
From: "André Draszik" <andre.draszik@linaro.org> To: Peter Griffin <peter.griffin@linaro.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>, "Will McVicker" <willmcvicker@google.com>, "Sam Protsenko" <semen.protsenko@linaro.org>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "André Draszik" <andre.draszik@linaro.org> Subject: [PATCH v2 4/4] arm64: dts: exynos: gs101: specify empty clocks for remaining pinctrl Date: Tue, 30 Apr 2024 10:49:49 +0100 [thread overview] Message-ID: <20240430-samsung-pinctrl-busclock-dts-v2-4-14fc988139dd@linaro.org> (raw) In-Reply-To: <20240430-samsung-pinctrl-busclock-dts-v2-0-14fc988139dd@linaro.org> The pinctrl instances hsi1, gsactrl, and gsacore need a clock for register access to work. Since we haven't implemented the relevant CMUs for the clocks required by these instances just add empty clocks for now so as to make the DT pass the validation checks. Once the clocks are implmented in the gs101 clock driver, these should be updated then. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- v2: use empty clock instead of placeholder --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index f8fcbbb06e7b..c8a5eb8c7d45 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -1309,6 +1309,9 @@ usbdrd31_dwc3: usb@0 { pinctrl_hsi1: pinctrl@11840000 { compatible = "google,gs101-pinctrl"; reg = <0x11840000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; interrupts = <GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH 0>; }; @@ -1380,11 +1383,17 @@ wakeup-interrupt-controller { pinctrl_gsactrl: pinctrl@17940000 { compatible = "google,gs101-pinctrl"; reg = <0x17940000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; pinctrl_gsacore: pinctrl@17a80000 { compatible = "google,gs101-pinctrl"; reg = <0x17a80000 0x00001000>; + /* TODO: update once support for this CMU exists */ + clocks = <0>; + clock-names = "pclk"; }; cmu_top: clock-controller@1e080000 { -- 2.44.0.769.g3c40516874-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-30 9:49 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-30 9:49 [PATCH v2 0/4] hook up pin controller clocks on Google Tensor gs101 André Draszik 2024-04-30 9:49 ` André Draszik 2024-04-30 9:49 ` [PATCH v2 1/4] arm64: dts: exynos: gs101: specify bus clock for pinctrl (far) alive André Draszik 2024-04-30 9:49 ` André Draszik 2024-05-02 6:49 ` Tudor Ambarus 2024-05-02 6:49 ` Tudor Ambarus 2024-04-30 9:49 ` [PATCH v2 2/4] arm64: dts: exynos: gs101: specify bus clock for pinctrl_peric[01] André Draszik 2024-04-30 9:49 ` André Draszik 2024-05-02 6:49 ` Tudor Ambarus 2024-05-02 6:49 ` Tudor Ambarus 2024-04-30 9:49 ` [PATCH v2 3/4] arm64: dts: exynos: gs101: specify bus clock for pinctrl_hsi2 André Draszik 2024-04-30 9:49 ` André Draszik 2024-05-02 6:50 ` Tudor Ambarus 2024-05-02 6:50 ` Tudor Ambarus 2024-04-30 9:49 ` André Draszik [this message] 2024-04-30 9:49 ` [PATCH v2 4/4] arm64: dts: exynos: gs101: specify empty clocks for remaining pinctrl André Draszik 2024-05-02 6:51 ` Tudor Ambarus 2024-05-02 6:51 ` Tudor Ambarus 2024-05-02 10:44 ` André Draszik 2024-05-02 10:44 ` André Draszik 2024-05-03 8:36 ` Krzysztof Kozlowski 2024-05-03 8:36 ` Krzysztof Kozlowski 2024-05-03 8:37 ` [PATCH v2 0/4] hook up pin controller clocks on Google Tensor gs101 Krzysztof Kozlowski 2024-05-03 8:37 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240430-samsung-pinctrl-busclock-dts-v2-4-14fc988139dd@linaro.org \ --to=andre.draszik@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=robh@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=tudor.ambarus@linaro.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.