From: Sascha Hauer <s.hauer@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH v2 0/3] mtd: nand: mxc_nand: Convert to exec_op Date: Wed, 08 May 2024 13:08:26 +0200 [thread overview] Message-ID: <20240508-mtd-nand-mxc-nand-exec-op-v2-0-6b7366b7831f@pengutronix.de> (raw) This series converts the mxc_nand driver over to exec_op which gets us rid of a bunch of legacy code. The motivation for this series is a board that has a NAND chip connected that needs 4bit ECC whereas the i.MX27 hardware only supports 1Bit Hamming ECC. With this series the driver now supports software BCH ECC. After discussion with Miquel I have now changed the way the data is written in software BCH ECC mode. The controller normally interleaves user data with OOB data in a NAND page. In this version I reversed the interleaving before writing a page and after reading a page. This way the data on the NAND chip is arranged in the way the NAND layer expects it and commands like NAND_CMD_RNDOUT work as expected. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Changes in v2: - Enable hw ecc only when needed and leave it disabled otherwise - Use untangled data/oob layout for software BCH ECC - Link to v1: https://lore.kernel.org/r/20240417-mtd-nand-mxc-nand-exec-op-v1-0-d12564fe54e9@pengutronix.de --- Sascha Hauer (3): mtd: nand: mxc_nand: separate page read from ecc calc mtd: nand: mxc_nand: implement exec_op mtd: nand: mxc_nand: support software ECC drivers/mtd/nand/raw/mxc_nand.c | 651 ++++++++++++++++++---------------------- 1 file changed, 296 insertions(+), 355 deletions(-) --- base-commit: fec50db7033ea478773b159e0e2efb135270e3b7 change-id: 20240417-mtd-nand-mxc-nand-exec-op-38b3b80c4377 Best regards, -- Sascha Hauer <s.hauer@pengutronix.de>
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH v2 0/3] mtd: nand: mxc_nand: Convert to exec_op Date: Wed, 08 May 2024 13:08:26 +0200 [thread overview] Message-ID: <20240508-mtd-nand-mxc-nand-exec-op-v2-0-6b7366b7831f@pengutronix.de> (raw) This series converts the mxc_nand driver over to exec_op which gets us rid of a bunch of legacy code. The motivation for this series is a board that has a NAND chip connected that needs 4bit ECC whereas the i.MX27 hardware only supports 1Bit Hamming ECC. With this series the driver now supports software BCH ECC. After discussion with Miquel I have now changed the way the data is written in software BCH ECC mode. The controller normally interleaves user data with OOB data in a NAND page. In this version I reversed the interleaving before writing a page and after reading a page. This way the data on the NAND chip is arranged in the way the NAND layer expects it and commands like NAND_CMD_RNDOUT work as expected. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Changes in v2: - Enable hw ecc only when needed and leave it disabled otherwise - Use untangled data/oob layout for software BCH ECC - Link to v1: https://lore.kernel.org/r/20240417-mtd-nand-mxc-nand-exec-op-v1-0-d12564fe54e9@pengutronix.de --- Sascha Hauer (3): mtd: nand: mxc_nand: separate page read from ecc calc mtd: nand: mxc_nand: implement exec_op mtd: nand: mxc_nand: support software ECC drivers/mtd/nand/raw/mxc_nand.c | 651 ++++++++++++++++++---------------------- 1 file changed, 296 insertions(+), 355 deletions(-) --- base-commit: fec50db7033ea478773b159e0e2efb135270e3b7 change-id: 20240417-mtd-nand-mxc-nand-exec-op-38b3b80c4377 Best regards, -- Sascha Hauer <s.hauer@pengutronix.de> ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2024-05-08 11:08 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-08 11:08 Sascha Hauer [this message] 2024-05-08 11:08 ` [PATCH v2 0/3] mtd: nand: mxc_nand: Convert to exec_op Sascha Hauer 2024-05-08 11:08 ` [PATCH v2 1/3] mtd: nand: mxc_nand: separate page read from ecc calc Sascha Hauer 2024-05-08 11:08 ` Sascha Hauer 2024-05-08 11:08 ` [PATCH v2 2/3] mtd: nand: mxc_nand: implement exec_op Sascha Hauer 2024-05-08 11:08 ` Sascha Hauer 2024-05-13 7:19 ` Miquel Raynal 2024-05-13 7:19 ` Miquel Raynal 2024-05-13 7:32 ` Miquel Raynal 2024-05-13 7:32 ` Miquel Raynal 2024-05-13 9:08 ` Sascha Hauer 2024-05-13 9:08 ` Sascha Hauer 2024-05-13 12:55 ` Miquel Raynal 2024-05-13 12:55 ` Miquel Raynal 2024-05-14 9:18 ` Sascha Hauer 2024-05-14 9:18 ` Sascha Hauer 2024-05-14 10:16 ` Miquel Raynal 2024-05-14 10:16 ` Miquel Raynal 2024-05-08 11:08 ` [PATCH v2 3/3] mtd: nand: mxc_nand: support software ECC Sascha Hauer 2024-05-08 11:08 ` Sascha Hauer 2024-05-13 7:42 ` Miquel Raynal 2024-05-13 7:42 ` Miquel Raynal 2024-05-13 9:19 ` Sascha Hauer 2024-05-13 9:19 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240508-mtd-nand-mxc-nand-exec-op-v2-0-6b7366b7831f@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.