All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: [PATCH liburing 1/1] tests: remove test_link_fail_ordering()
Date: Fri,  7 May 2021 17:42:41 +0100	[thread overview]
Message-ID: <2038218a804134079c8883293f6d89a1723ac563.1620405748.git.asml.silence@gmail.com> (raw)

Apparently old kernels were posting CQEs of a link failed during
submission in a strange order, kill the test.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 test/link.c | 53 -----------------------------------------------------
 1 file changed, 53 deletions(-)

diff --git a/test/link.c b/test/link.c
index fadd0b5..c89d6b2 100644
--- a/test/link.c
+++ b/test/link.c
@@ -429,53 +429,6 @@ err:
 	return 1;
 }
 
-static int test_link_fail_ordering(struct io_uring *ring)
-{
-	struct io_uring_cqe *cqe;
-	struct io_uring_sqe *sqe;
-	int ret, i, nr_compl;
-
-	sqe = io_uring_get_sqe(ring);
-	io_uring_prep_nop(sqe);
-	sqe->flags |= IOSQE_IO_LINK;
-	sqe->user_data = 0;
-
-	sqe = io_uring_get_sqe(ring);
-	io_uring_prep_write(sqe, -1, NULL, 100, 0);
-	sqe->flags |= IOSQE_IO_LINK;
-	sqe->user_data = 1;
-
-	sqe = io_uring_get_sqe(ring);
-	io_uring_prep_nop(sqe);
-	sqe->flags |= IOSQE_IO_LINK;
-	sqe->user_data = 2;
-
-	nr_compl = ret = io_uring_submit(ring);
-	/* at least the first nop should have been submitted */
-	if (ret < 1) {
-		fprintf(stderr, "sqe submit failed: %d\n", ret);
-		goto err;
-	}
-
-	for (i = 0; i < nr_compl; i++) {
-		ret = io_uring_wait_cqe(ring, &cqe);
-		if (ret) {
-			fprintf(stderr, "wait completion %d\n", ret);
-			goto err;
-		}
-		if (cqe->user_data != i) {
-			fprintf(stderr, "wrong CQE order, got %i, expected %i\n",
-					(int)cqe->user_data, i);
-			goto err;
-		}
-		io_uring_cqe_seen(ring, cqe);
-	}
-
-	return 0;
-err:
-	return 1;
-}
-
 int main(int argc, char *argv[])
 {
 	struct io_uring ring, poll_ring;
@@ -539,11 +492,5 @@ int main(int argc, char *argv[])
 		return ret;
 	}
 
-	ret = test_link_fail_ordering(&ring);
-	if (ret) {
-		fprintf(stderr, "test_link_fail_ordering last failed\n");
-		return ret;
-	}
-
 	return 0;
 }
-- 
2.31.1


             reply	other threads:[~2021-05-07 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 16:42 Pavel Begunkov [this message]
2021-05-07 16:48 ` [PATCH liburing 1/1] tests: remove test_link_fail_ordering() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2038218a804134079c8883293f6d89a1723ac563.1620405748.git.asml.silence@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.