All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Takashi Iwai <tiwai@suse.de>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: [5.14 regression] "ASoC: intel: atom: Fix reference to PCM buffer address" breaks Intel SST audio
Date: Thu, 19 Aug 2021 16:42:49 +0200	[thread overview]
Message-ID: <2048c6aa-2187-46bd-6772-36a4fb3c5aeb@redhat.com> (raw)

Hi All,

After rebasing a set of bytcr_rt5640 patches, on top of asoc/for-next
I noticed that playing back audio would only generate random-noise / buzzing
(I did not try recording any audio). 

After poking at this for a while I've found the culprit:

2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM buffer address")

If I revert that single commit then audio on Intel Bay Trail and
Cherry Trail devices works fine again with 5.14.

This is with a Fedora 34 userspace using pipewire as audiodaemon

I'm not sure what is going on here, but since the old code
changed by the broken commit has worked fine for ages and
given where we are in the devel-cycle I think it might be best
to just revert 2e6b836312a4 again.

Regards,

Hans


             reply	other threads:[~2021-08-19 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 14:42 Hans de Goede [this message]
2021-08-19 14:45 ` [5.14 regression] "ASoC: intel: atom: Fix reference to PCM buffer address" breaks Intel SST audio Hans de Goede
2021-08-19 14:52   ` Takashi Iwai
2021-08-19 15:11     ` Hans de Goede
2021-08-19 15:18       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2048c6aa-2187-46bd-6772-36a4fb3c5aeb@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.