All of lore.kernel.org
 help / color / mirror / Atom feed
From: Son Luong Ngoc <sluongng@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Son Luong Ngoc <sluongng@gmail.com>
Subject: Broken Git-diff on master
Date: Wed, 18 Mar 2020 21:41:12 +0100	[thread overview]
Message-ID: <20BFEDB4-738A-4DD7-9316-8DE73999C633@gmail.com> (raw)

Hey folks,

I am testing out the latest changes in master be8661a3286c67a5d4088f4226cbd7f8b76544b0 and observe the following

> mkdir test
> cd test
> echo a > a
> echo b > b
> git diff a b | cat
diff --git a/a b/b
index 7898192..6178079 100644
--- a/a
+++ b/b
@@ -1 +1 @@
-a
+b
> git init
> git diff a b | cat
> GIT_TRACE2_PERF=1 git diff a b | cat
21:38:36.615653 common-main.c:48             | d0 | main                     | version      |     |           |           |              | 2.26.0.rc2.27.gbe8661a328
21:38:36.616258 common-main.c:49             | d0 | main                     | start        |     |  0.004075 |           |              | git diff a b
21:38:36.616307 git.c:440                    | d0 | main                     | cmd_name     |     |           |           |              | diff (diff)
21:38:36.616696 repository.c:130             | d0 | main                     | def_repo     | r1  |           |           |              | worktree:/Users/sluongngoc/work/some-dir/test
21:38:36.617589 read-cache.c:2303            | d0 | main                     | region_enter | r1  |  0.005408 |           | index        | label:do_read_index .git/index
21:38:36.617615 read-cache.c:2308            | d0 | main                     | region_leave | r1  |  0.005435 |  0.000027 | index        | label:do_read_index .git/index
21:38:36.617656 git.c:674                    | d0 | main                     | exit         |     |  0.005476 |           |              | code:0
21:38:36.617668 trace2/tr2_tgt_perf.c:213    | d0 | main                     | atexit       |     |  0.005489 |           |              | code:0

> git version
git version 2.26.0.rc2.27.gbe8661a328

I think git-diff is broken. Hope that this get address before 2.26.0 come out.

Cheers,
Son Luong.

             reply	other threads:[~2020-03-18 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 20:41 Son Luong Ngoc [this message]
2020-03-18 20:52 ` Broken Git-diff on master Son Luong Ngoc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20BFEDB4-738A-4DD7-9316-8DE73999C633@gmail.com \
    --to=sluongng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.