All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: select ARCH_WANT_OPTIONAL_GPIOLIB
Date: Thu, 21 Feb 2013 11:44:51 +0100	[thread overview]
Message-ID: <2173132.bncoOm6QsM@wuerfel> (raw)
In-Reply-To: <CACxGe6tVk4na2yLi-6r1fTv5QqzgePbo6K+ZtEt-VOy25DQxVQ@mail.gmail.com>

An architecture should not unconditionally enable 'GENERIC_GPIO'
without providing an implementation. In case of arm64, selecting
ARCH_WANT_OPTIONAL_GPIOLIB is the right solution, because it
lets us enable GPIOLIB when configuring the kernel, and that
implicitly turns on GENERIC_GPIO.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
On Thursday 21 February 2013 10:36:41 Grant Likely wrote:
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index ab4aa54..3fab0db 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -3,6 +3,7 @@ config ARM64
> >         select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
> >         select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
> >         select ARCH_WANT_FRAME_POINTERS
> > +       select ARCH_WANT_OPTIONAL_GPIOLIB
> >         select ARM_AMBA
> >         select ARM_ARCH_TIMER
> >         select CLONE_BACKWARDS
> > @@ -92,9 +93,6 @@ config SWIOTLB
> >  config IOMMU_HELPER
> >         def_bool SWIOTLB
> >
> > -config GENERIC_GPIO
> > -       def_bool y
> > -
> >  source "init/Kconfig"
> >
> >  source "kernel/Kconfig.freezer"
> 
> I've not asked Linus to pull the GPIO tree yet because of this issue.
> Can someone please test this on aarch64 and send me a properly
> formatted patch?

It was wrong, the new version below is good though. Tested with defconfig
and allyesconfig on arm64. I found a few more trivial issues with arm64
allyesconfig that I fixed up as well. I'll send separate patches
for those.

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index ab4aa54..38d3f34 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -3,6 +3,7 @@ config ARM64
 	select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
 	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
 	select ARCH_WANT_FRAME_POINTERS
+	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_AMBA
 	select ARM_ARCH_TIMER
 	select CLONE_BACKWARDS
@@ -93,7 +94,7 @@ config IOMMU_HELPER
 	def_bool SWIOTLB
 
 config GENERIC_GPIO
-	def_bool y
+	bool
 
 source "init/Kconfig"
 

  reply	other threads:[~2013-02-21 10:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 11:14 arm64 defconfig breakage (gpio) in next-20130218 Mark Rutland
2013-02-21  9:31 ` Shawn Guo
2013-02-21 10:02   ` Arnd Bergmann
2013-02-21 10:36     ` Grant Likely
2013-02-21 10:44       ` Arnd Bergmann [this message]
2013-02-21 21:35         ` [PATCH] arm64: select ARCH_WANT_OPTIONAL_GPIOLIB Linus Walleij
2013-02-22 14:29           ` Grant Likely
     [not found]       ` <1636745.vSza8MrtIn@wuerfel>
2013-02-21 10:46         ` Catalin Marinas
2013-02-22  9:39           ` Mark Rutland
2013-02-21 10:37     ` arm64 defconfig breakage (gpio) in next-20130218 Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2173132.bncoOm6QsM@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.