All of lore.kernel.org
 help / color / mirror / Atom feed
From: nathan binkert <nate@binkert.org>
To: kvm@vger.kernel.org
Subject: [PATCH] KVM: Make kvm header compile under g++.
Date: Fri, 27 Mar 2009 21:53:05 -0700	[thread overview]
Message-ID: <217accd40903272153m650b0f1ata7bc899eb4b92be0@mail.gmail.com> (raw)

Two things needed fixing: 1) g++ does not allow a named structure type
within an anonymous union and 2) Avoid name clash between two padding
fields within the same struct by giving them different names as is
done elsewhere in the header.


Signed-off-by: Nathan Binkert <nate@binkert.org>
---
 include/linux/kvm.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index ee755e2..2e3a734 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -119,7 +119,7 @@ struct kvm_run {
 			__u32 error_code;
 		} ex;
 		/* KVM_EXIT_IO */
-		struct kvm_io {
+		struct {
 #define KVM_EXIT_IO_IN  0
 #define KVM_EXIT_IO_OUT 1
 			__u8 direction;
@@ -224,10 +224,10 @@ struct kvm_interrupt {
 /* for KVM_GET_DIRTY_LOG */
 struct kvm_dirty_log {
 	__u32 slot;
-	__u32 padding;
+	__u32 padding1;
 	union {
 		void __user *dirty_bitmap; /* one bit per page */
-		__u64 padding;
+		__u64 padding2;
 	};
 };

-- 
1.6.1.2

             reply	other threads:[~2009-03-28  4:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28  4:53 nathan binkert [this message]
2009-04-06 18:57 ` [PATCH] KVM: Make kvm header compile under g++ nathan binkert
2009-04-07 10:16   ` Avi Kivity
2009-04-07 16:44     ` nathan binkert
2009-04-07 17:11       ` Avi Kivity
2009-04-07 17:25         ` nathan binkert
2009-04-09 16:10           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=217accd40903272153m650b0f1ata7bc899eb4b92be0@mail.gmail.com \
    --to=nate@binkert.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.