From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Marcos.Matsunaga@oracle.com,
Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
Subject: Re: [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/
Date: Tue, 18 Oct 2016 16:50:31 +0100 [thread overview]
Message-ID: <22534.17607.320720.470301@mariner.uk.xensource.com> (raw)
In-Reply-To: <1476802588-28894-3-git-send-email-konrad.wilk@oracle.com>
Konrad Rzeszutek Wilk writes ("[PATCH 2/2] s/HttpProxy/DebianMirrorProxy/"):
> From: Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
...
> When constructing Debian related items we should be using the
> DebianMirrorProxy instead of all catch HttpProxy.
I don't think this is right, because apt-cachers and the like are only
required to support apt's uses, and not wgets of bits of installer.
But:
> Or alternatively support the case where are no HttProxy at all.
This is right. So I think the patch below is better.
Ian.
From 85741f132e62e0cdaef66860d417fa80e9df7a13 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Tue, 18 Oct 2016 16:46:20 +0100
Subject: [OSSTEST PATCH] mgi-common: Support empty (unset) HttpProxy properly
mg_update_proxy ends up being set to the empty string so the {...:+-x}
form is needed to expand only non-empty values to `-x'.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
---
mgi-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mgi-common b/mgi-common
index 8a2c2d9..5081521 100644
--- a/mgi-common
+++ b/mgi-common
@@ -30,7 +30,7 @@ fetch () {
cd $mg_update_org_pwd && getconfig HttpProxy
)}
curl -s -H 'Pragma: no-cache' \
- ${mg_update_proxy+-x} ${mg_update_proxy} \
+ ${mg_update_proxy:+-x} ${mg_update_proxy} \
$1
}
--
2.9.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-18 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 14:56 [PATCH v1] Documentation and various fixes to osstest Konrad Rzeszutek Wilk
2016-10-18 14:56 ` [PATCH 1/2] README: Also mention other requirements Konrad Rzeszutek Wilk
2016-10-18 15:51 ` Ian Jackson
2016-10-18 14:56 ` [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ Konrad Rzeszutek Wilk
2016-10-18 15:50 ` Ian Jackson [this message]
2016-10-26 13:56 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22534.17607.320720.470301@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Marcos.Matsunaga@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@osstest.dumpdata.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.