From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Marcos.Matsunaga@oracle.com
Subject: Re: [PATCH 1/3] DhcpWatch: Print what is wrong with the line.
Date: Wed, 26 Oct 2016 16:10:23 +0100 [thread overview]
Message-ID: <22544.51039.224555.50233@mariner.uk.xensource.com> (raw)
In-Reply-To: <1477505649-84103-2-git-send-email-konrad.wilk@oracle.com>
Konrad Rzeszutek Wilk writes ("[PATCH 1/3] DhcpWatch: Print what is wrong with the line."):
> If the user forgot to include 'dhcp3' on the parameter
> line point out the error to the user.
How about this ?
From 693471df9e9a2a491a576ae644d02751906a63cf Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Wed, 26 Oct 2016 14:14:07 -0400
Subject: [OSSTEST PATCH] DhcpWatch: Print what is wrong with the line.
If the user forgot to include 'dhcp3' on the parameter
line point out the error to the user.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
v2: Still print out the arguments to the constructor, hopefully
non-confusingly.
---
Osstest/DhcpWatch/leases.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Osstest/DhcpWatch/leases.pm b/Osstest/DhcpWatch/leases.pm
index b74ebf0..98c22b9 100644
--- a/Osstest/DhcpWatch/leases.pm
+++ b/Osstest/DhcpWatch/leases.pm
@@ -40,7 +40,8 @@ BEGIN {
sub new {
my ($class, $ho, $meth, $format, $source) = @_;
- die "$format (@_) ?" unless $format eq 'dhcp3';
+ die "'$format' is missing dhcp3 in it! (args: @_) ?"
+ unless $format eq 'dhcp3';
return bless {
Format => $format,
Source => $source,
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-26 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 18:14 [PATCH OSSTEST] Various fixes when using standalone Konrad Rzeszutek Wilk
2016-10-26 18:14 ` [PATCH 1/3] DhcpWatch: Print what is wrong with the line Konrad Rzeszutek Wilk
2016-10-26 15:10 ` Ian Jackson [this message]
2016-10-26 15:15 ` Konrad Rzeszutek Wilk
2016-10-26 18:14 ` [PATCH 2/3] standalong-reset: Use the $suite when recreating soft links Konrad Rzeszutek Wilk
2016-10-26 18:14 ` [PATCH 3/3] README: Mention the / requirement in Tftp[Dir|Tmp]Dir Konrad Rzeszutek Wilk
2016-10-26 15:12 ` Ian Jackson
2016-10-26 15:16 ` Konrad Rzeszutek Wilk
2016-10-26 15:38 ` Ian Jackson
2016-10-26 18:51 ` [PATCH] standalone-reset: Check for TftpPxeDir Konrad Rzeszutek Wilk
2016-10-26 15:48 ` Ian Jackson
2016-10-26 15:52 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22544.51039.224555.50233@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Marcos.Matsunaga@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.