From: Jerry Hoemann <jerry.hoemann@hpe.com> To: dan.j.williams@intel.com Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org Subject: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru. Date: Fri, 30 Jun 2017 10:09:36 -0600 [thread overview] Message-ID: <293ee143dcabb386ca06b384a384171c256a2ecc.1498810220.git.jerry.hoemann@hpe.com> (raw) In-Reply-To: <cover.1498810220.git.jerry.hoemann@hpe.com> In-Reply-To: <cover.1498810220.git.jerry.hoemann@hpe.com> Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com> --- drivers/acpi/nfit/core.c | 8 ++++++++ include/linux/libnvdimm.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index b46fca2..5e4c137 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -253,6 +253,8 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, cmd_name = nvdimm_bus_cmd_name(cmd); cmd_mask = nd_desc->cmd_mask; dsm_mask = cmd_mask; + if (cmd == ND_CMD_CALL) + dsm_mask = nd_desc->bus_dsm_mask; desc = nd_cmd_bus_desc(cmd); uuid = to_nfit_uuid(NFIT_DEV_BUS); handle = adev->handle; @@ -1613,6 +1615,7 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) struct nvdimm_bus_descriptor *nd_desc = &acpi_desc->nd_desc; const u8 *uuid = to_nfit_uuid(NFIT_DEV_BUS); struct acpi_device *adev; + unsigned long dsm_mask; int i; nd_desc->cmd_mask = acpi_desc->bus_cmd_force_en; @@ -1624,6 +1627,11 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) set_bit(i, &nd_desc->cmd_mask); set_bit(ND_CMD_CALL, &nd_desc->cmd_mask); + + dsm_mask = 0x3bf; + for_each_set_bit(i, &dsm_mask, BITS_PER_LONG) + if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) + set_bit(i, &nd_desc->bus_dsm_mask); } static ssize_t range_index_show(struct device *dev, diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h index 6c80701..f8b8f43 100644 --- a/include/linux/libnvdimm.h +++ b/include/linux/libnvdimm.h @@ -54,6 +54,7 @@ typedef int (*ndctl_fn)(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm_bus_descriptor { const struct attribute_group **attr_groups; + unsigned long bus_dsm_mask; unsigned long cmd_mask; struct module *module; char *provider_name; -- 1.8.5.6 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jerry Hoemann <jerry.hoemann@hpe.com> To: dan.j.williams@intel.com Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Jerry Hoemann <jerry.hoemann@hpe.com> Subject: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru. Date: Fri, 30 Jun 2017 10:09:36 -0600 [thread overview] Message-ID: <293ee143dcabb386ca06b384a384171c256a2ecc.1498810220.git.jerry.hoemann@hpe.com> (raw) In-Reply-To: <cover.1498810220.git.jerry.hoemann@hpe.com> In-Reply-To: <cover.1498810220.git.jerry.hoemann@hpe.com> Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com> --- drivers/acpi/nfit/core.c | 8 ++++++++ include/linux/libnvdimm.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index b46fca2..5e4c137 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -253,6 +253,8 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, cmd_name = nvdimm_bus_cmd_name(cmd); cmd_mask = nd_desc->cmd_mask; dsm_mask = cmd_mask; + if (cmd == ND_CMD_CALL) + dsm_mask = nd_desc->bus_dsm_mask; desc = nd_cmd_bus_desc(cmd); uuid = to_nfit_uuid(NFIT_DEV_BUS); handle = adev->handle; @@ -1613,6 +1615,7 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) struct nvdimm_bus_descriptor *nd_desc = &acpi_desc->nd_desc; const u8 *uuid = to_nfit_uuid(NFIT_DEV_BUS); struct acpi_device *adev; + unsigned long dsm_mask; int i; nd_desc->cmd_mask = acpi_desc->bus_cmd_force_en; @@ -1624,6 +1627,11 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) set_bit(i, &nd_desc->cmd_mask); set_bit(ND_CMD_CALL, &nd_desc->cmd_mask); + + dsm_mask = 0x3bf; + for_each_set_bit(i, &dsm_mask, BITS_PER_LONG) + if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) + set_bit(i, &nd_desc->bus_dsm_mask); } static ssize_t range_index_show(struct device *dev, diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h index 6c80701..f8b8f43 100644 --- a/include/linux/libnvdimm.h +++ b/include/linux/libnvdimm.h @@ -54,6 +54,7 @@ typedef int (*ndctl_fn)(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm_bus_descriptor { const struct attribute_group **attr_groups; + unsigned long bus_dsm_mask; unsigned long cmd_mask; struct module *module; char *provider_name; -- 1.8.5.6
next prev parent reply other threads:[~2017-06-30 16:08 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-30 16:09 [PATCH v3 0/7] Enable DSM pass thru for root functions Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-06-30 16:09 ` [PATCH v4 1/6] libnvdimm: passthru functions clear to send Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-06-30 16:09 ` [PATCH v4 2/6] acpi, nfit: Enable DSM pass thru for root functions Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann [this message] 2017-06-30 16:09 ` [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru Jerry Hoemann 2017-07-01 3:55 ` Dan Williams 2017-07-01 3:55 ` Dan Williams 2017-07-01 19:58 ` Jerry Hoemann 2017-07-01 19:58 ` Jerry Hoemann 2017-07-01 20:08 ` Dan Williams 2017-07-01 20:08 ` Dan Williams 2017-07-01 20:10 ` Dan Williams 2017-07-01 20:10 ` Dan Williams 2017-07-01 20:38 ` Jerry Hoemann 2017-07-01 20:38 ` Jerry Hoemann 2017-07-01 20:46 ` Dan Williams 2017-07-01 20:46 ` Dan Williams 2017-07-04 20:08 ` Jerry Hoemann 2017-07-04 20:08 ` Jerry Hoemann 2017-07-04 20:37 ` Dan Williams 2017-07-04 20:37 ` Dan Williams 2017-07-05 15:26 ` Linda Knippers 2017-07-05 15:26 ` Linda Knippers 2017-07-05 16:24 ` Jerry Hoemann 2017-07-05 16:24 ` Jerry Hoemann 2017-07-05 16:35 ` Dan Williams 2017-07-05 16:35 ` Dan Williams 2017-07-05 23:14 ` Jerry Hoemann 2017-07-05 23:14 ` Jerry Hoemann 2017-07-06 5:25 ` Dan Williams 2017-07-06 5:25 ` Dan Williams 2017-06-30 16:09 ` [PATCH v4 4/6] acpi, nfit: Show bus_dsm_mask in sysfs Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-06-30 16:09 ` [PATCH v4 5/6] libnvdimm: New ACPI 6.2 DSM functions Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-06-30 16:09 ` [PATCH v4 6/6] nfit allow override of root dsm mask Jerry Hoemann 2017-06-30 16:09 ` Jerry Hoemann 2017-07-01 3:49 ` Dan Williams 2017-07-01 3:49 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=293ee143dcabb386ca06b384a384171c256a2ecc.1498810220.git.jerry.hoemann@hpe.com \ --to=jerry.hoemann@hpe.com \ --cc=dan.j.williams@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.