Re: [Bug] usb: dwc2: Add functions to set and clear force mode

From: John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
To: Caesar Wang
	<caesar.upstream-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: "Huang, Tao" <huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Heiko Stuebner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Doug Anderson"
	<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Felipe Balbi" <balbi-l0cyMroinI0@public.gmane.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	吴良峰 <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	CaesarWang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: Re: [Bug] usb: dwc2: Add functions to set and clear force mode
Date: Wed, 3 Feb 2016 00:03:40 +0000	[thread overview]
Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC431FDB@US01WEMBX2.internal.synopsys.com> (raw)
In-Reply-To: 56B01A0C.3070801@gmail.com

On 2/1/2016 6:53 PM, Caesar Wang wrote:
> John,
> 
> I will suggest the msleep(25) delay should  put in 
> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()'
> 

Hi Caesar,

Are you saying that just msleep(25) in that function like this solves
your issue?

diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 39a0fa8..e8a9688 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg)
                         __func__, hsotg->dr_mode);
                break;
        }
+
+       msleep(25);
 }
 


Although that is still not ideal, it's better than the alternative.

Regards,
John
