All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: linux-pm@vger.kernel.org, edubezval@gmail.com
Cc: linaro-kernel@lists.linaro.org, rui.zhang@intel.com,
	amit.daniel@samsung.com, javi.merino@arm.com,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 20/26] thermal: cpu_cooling: find max level during device registration
Date: Thu,  4 Dec 2014 09:42:02 +0530	[thread overview]
Message-ID: <2deba357b8ab9cead52eba262a294b0b33e29691.1417664938.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1417664938.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1417664938.git.viresh.kumar@linaro.org>

CPU frequency tables don't update after the driver is registered and so we don't
need to iterate over them to find total number of states every time
cpufreq_get_max_state() is called. Do it once at boot time.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/thermal/cpu_cooling.c | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 2c4c485..d34cc5b 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -52,6 +52,8 @@
  *	cooling	devices.
  * @cpufreq_val: integer value representing the absolute value of the clipped
  *	frequency.
+ * @max_level: maximum cooling level. One less than total number of valid
+ *	cpufreq frequencies.
  * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
  *
  * This structure is required for keeping information of each registered
@@ -62,6 +64,7 @@ struct cpufreq_cooling_device {
 	struct thermal_cooling_device *cool_dev;
 	unsigned int cpufreq_state;
 	unsigned int cpufreq_val;
+	unsigned int max_level;
 	struct cpumask allowed_cpus;
 	struct list_head node;
 };
@@ -283,19 +286,9 @@ static int cpufreq_get_max_state(struct thermal_cooling_device *cdev,
 				 unsigned long *state)
 {
 	struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;
-	struct cpumask *mask = &cpufreq_device->allowed_cpus;
-	unsigned int cpu;
-	unsigned int count = 0;
-	int ret;
-
-	cpu = cpumask_any(mask);
-
-	ret = get_property(cpu, 0, &count, GET_MAXL);
-
-	if (count > 0)
-		*state = count;
 
-	return ret;
+	*state = cpufreq_device->max_level;
+	return 0;
 }
 
 /**
@@ -385,9 +378,11 @@ __cpufreq_cooling_register(struct device_node *np,
 	struct thermal_cooling_device *cool_dev;
 	struct cpufreq_cooling_device *cpufreq_dev;
 	char dev_name[THERMAL_NAME_LENGTH];
+	struct cpufreq_frequency_table *pos, *table;
 	int ret;
 
-	if (!cpufreq_frequency_get_table(cpumask_first(clip_cpus))) {
+	table = cpufreq_frequency_get_table(cpumask_first(clip_cpus));
+	if (!table) {
 		pr_debug("%s: CPUFreq table not found\n", __func__);
 		return ERR_PTR(-EPROBE_DEFER);
 	}
@@ -404,6 +399,13 @@ __cpufreq_cooling_register(struct device_node *np,
 		goto free_cdev;
 	}
 
+	/* Find max levels */
+	cpufreq_for_each_valid_entry(pos, table)
+		cpufreq_dev->max_level++;
+
+	/* max_level is an index, not a counter */
+	cpufreq_dev->max_level--;
+
 	cpumask_copy(&cpufreq_dev->allowed_cpus, clip_cpus);
 
 	ret = get_idr(&cpufreq_idr, &cpufreq_dev->id);
-- 
2.0.3.693.g996b0fd


  parent reply	other threads:[~2014-12-04  4:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  4:11 [PATCH V2 00/26] thermal: cpu_cooling: Fixes and cleanups Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 01/26] thermal: cpu_cooling: check for the readiness of cpufreq layer Viresh Kumar
2014-12-04  4:11   ` Viresh Kumar
2014-12-04 14:08   ` Eduardo Valentin
2014-12-04 14:08     ` Eduardo Valentin
2014-12-04  4:11 ` [PATCH V2 02/26] thermal: db8500: pass cpu_present_mask to cpufreq_cooling_register() Viresh Kumar
2014-12-31  8:11   ` Linus Walleij
2014-12-04  4:11 ` [PATCH V2 03/26] thermal: imx: " Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 04/26] thermal: exynos: " Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 05/26] thermal: cpu_cooling: random comment fixups Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 06/26] thermal: cpu_cooling: fix doc comment over struct cpufreq_cooling_device Viresh Kumar
2014-12-04 10:32   ` Javi Merino
2014-12-04 10:36     ` Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 07/26] thermal: cpu_cooling: Add comment to clarify relation between cooling state and frequency Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 08/26] thermal: cpu_cooling: Pass variable instead of its type to sizeof() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 09/26] thermal: cpu_cooling: no need to set cpufreq_state to zero Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 10/26] thermal: cpu_cooling: no need to set cpufreq_dev to NULL Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 11/26] thermal: cpu_cooling: no need to initialze 'ret' Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 12/26] thermal: cpu_cooling: propagate error returned by idr_alloc() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 13/26] thermal: cpu_cooling: Don't match min/max frequencies for all CPUs on cooling register Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 14/26] thermal: cpu_cooling: don't iterate over all allowed_cpus to update cpufreq policy Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 15/26] thermal: cpu_cooling: Don't check is_cpufreq_valid() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 16/26] thermal: cpu_cooling: do error handling at the bottom in __cpufreq_cooling_register() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 17/26] thermal: cpu_cooling: initialize 'cpufreq_val' on registration Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 18/26] thermal: cpu_cooling: Merge cpufreq_apply_cooling() into cpufreq_set_cur_state() Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 19/26] thermal: cpu_cooling: remove unnecessary wrapper get_cpu_frequency() Viresh Kumar
2014-12-04  4:12 ` Viresh Kumar [this message]
2014-12-04  4:12 ` [PATCH V2 21/26] thermal: cpu_cooling: get_property() doesn't need to support GET_MAXL anymore Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 22/26] thermal: cpu_cooling: use cpufreq_dev_list instead of cpufreq_dev_count Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 23/26] thermal: cpu_cooling: Pass 'cpufreq_dev' to get_property() Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 24/26] thermal: cpu_cooling: Store frequencies in descending order Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 25/26] thermal: cpu_cooling: Use cpufreq_dev->freq_table for finding level/freq Viresh Kumar
2014-12-04 10:52   ` Javi Merino
2014-12-04 10:56     ` Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 26/26] thermal: cpu_cooling: update copyright tags Viresh Kumar
2014-12-08 20:01 ` [PATCH V2 00/26] thermal: cpu_cooling: Fixes and cleanups Eduardo Valentin
2014-12-09  1:47   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2deba357b8ab9cead52eba262a294b0b33e29691.1417664938.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=amit.daniel@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=javi.merino@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.