From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel@pengutronix.de
Subject: [PATCH] Input: amimouse - Mark driver struct with __refdata to prevent section mismatch
Date: Fri, 29 Mar 2024 22:54:38 +0100 [thread overview]
Message-ID: <2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.de> (raw)
As described in the added code comment, a reference to .exit.text is ok
for drivers registered via module_platform_driver_probe(). Make this
explicit to prevent the following section mismatch warning
WARNING: modpost: drivers/input/mouse/amimouse: section mismatch in reference: amimouse_driver+0x8 (section: .data) -> amimouse_remove (section: .exit.text)
that triggers on an allmodconfig W=1 build.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/input/mouse/amimouse.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/amimouse.c b/drivers/input/mouse/amimouse.c
index cda0c3ff5a28..2fbbaeb76d70 100644
--- a/drivers/input/mouse/amimouse.c
+++ b/drivers/input/mouse/amimouse.c
@@ -132,7 +132,13 @@ static void __exit amimouse_remove(struct platform_device *pdev)
input_unregister_device(dev);
}
-static struct platform_driver amimouse_driver = {
+/*
+ * amimouse_remove() lives in .exit.text. For drivers registered via
+ * module_platform_driver_probe() this is ok because they cannot get unbound at
+ * runtime. So mark the driver struct with __refdata to prevent modpost
+ * triggering a section mismatch warning.
+ */
+static struct platform_driver amimouse_driver __refdata = {
.remove_new = __exit_p(amimouse_remove),
.driver = {
.name = "amiga-mouse",
base-commit: a6bd6c9333397f5a0e2667d4d82fef8c970108f2
--
2.43.0
next reply other threads:[~2024-03-29 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 21:54 Uwe Kleine-König [this message]
2024-03-29 21:54 ` [PATCH] parport: amiga: Mark driver struct with __refdata to prevent section mismatch Uwe Kleine-König
2024-04-15 14:37 ` Uwe Kleine-König
2024-04-29 20:30 ` Uwe Kleine-König
2024-03-29 21:54 ` [PATCH] serial: ami: " Uwe Kleine-König
2024-03-29 21:54 ` [PATCH] virt: sev-guest: " Uwe Kleine-König
2024-03-30 0:16 ` Kuppuswamy Sathyanarayanan
2024-04-15 14:39 ` Uwe Kleine-König
2024-04-29 20:32 ` Uwe Kleine-König
2024-04-15 21:53 ` Tom Lendacky
2024-03-29 21:54 ` [PATCH] OSS: dmasound/paula: " Uwe Kleine-König
2024-04-01 11:47 ` Takashi Iwai
2024-03-29 21:54 ` [PATCH] serial: pmac_zilog: Drop usage of platform_driver_probe() Uwe Kleine-König
2024-03-29 21:54 ` Uwe Kleine-König
2024-04-03 5:15 ` Michael Ellerman
2024-04-03 5:15 ` Michael Ellerman
2024-04-15 14:34 ` [PATCH] Input: amimouse - Mark driver struct with __refdata to prevent section mismatch Uwe Kleine-König
2024-04-29 20:29 ` Uwe Kleine-König
2024-04-30 20:59 ` Dmitry Torokhov
2024-04-30 20:58 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.