From: Arnd Bergmann <arnd@arndb.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
arm@kernel.org
Subject: Re: [PATCH ] ARM: pxa: fix section mismatch warning for pxa_timer_nodt_init
Date: Sun, 07 Sep 2014 23:06:05 +0200 [thread overview]
Message-ID: <3188925.pjYA4K7kjn@wuerfel> (raw)
In-Reply-To: <12220413.BdRleC0Xf5@wuerfel>
On Saturday 26 July 2014 20:50:36 Arnd Bergmann wrote:
> commit a38b1f60b5245a3 ("ARM: pxa: Add non device-tree timer link to
> clocksource") introduced a harmless section mismatch warning for
> all pxa platforms, by introducing a new pxa_timer_init() function
> that is not marked __init but that calls pxa_timer_nodt_init(),
> which is. The function is only called at init time, so it is safe
> to also annotate it this way.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Apparently this is not merged yet, should we take it through arm-soc?
diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
index 630fa916bbc6..04b013fbc98f 100644
--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL(get_clock_tick_rate);
/*
* For non device-tree builds, keep legacy timer init
*/
-void pxa_timer_init(void)
+void __init pxa_timer_init(void)
{
pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
get_clock_tick_rate());
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
Cc: Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH ] ARM: pxa: fix section mismatch warning for pxa_timer_nodt_init
Date: Sun, 07 Sep 2014 23:06:05 +0200 [thread overview]
Message-ID: <3188925.pjYA4K7kjn@wuerfel> (raw)
In-Reply-To: <12220413.BdRleC0Xf5@wuerfel>
On Saturday 26 July 2014 20:50:36 Arnd Bergmann wrote:
> commit a38b1f60b5245a3 ("ARM: pxa: Add non device-tree timer link to
> clocksource") introduced a harmless section mismatch warning for
> all pxa platforms, by introducing a new pxa_timer_init() function
> that is not marked __init but that calls pxa_timer_nodt_init(),
> which is. The function is only called at init time, so it is safe
> to also annotate it this way.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
Apparently this is not merged yet, should we take it through arm-soc?
diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
index 630fa916bbc6..04b013fbc98f 100644
--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL(get_clock_tick_rate);
/*
* For non device-tree builds, keep legacy timer init
*/
-void pxa_timer_init(void)
+void __init pxa_timer_init(void)
{
pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
get_clock_tick_rate());
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH ] ARM: pxa: fix section mismatch warning for pxa_timer_nodt_init
Date: Sun, 07 Sep 2014 23:06:05 +0200 [thread overview]
Message-ID: <3188925.pjYA4K7kjn@wuerfel> (raw)
In-Reply-To: <12220413.BdRleC0Xf5@wuerfel>
On Saturday 26 July 2014 20:50:36 Arnd Bergmann wrote:
> commit a38b1f60b5245a3 ("ARM: pxa: Add non device-tree timer link to
> clocksource") introduced a harmless section mismatch warning for
> all pxa platforms, by introducing a new pxa_timer_init() function
> that is not marked __init but that calls pxa_timer_nodt_init(),
> which is. The function is only called at init time, so it is safe
> to also annotate it this way.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Apparently this is not merged yet, should we take it through arm-soc?
diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
index 630fa916bbc6..04b013fbc98f 100644
--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL(get_clock_tick_rate);
/*
* For non device-tree builds, keep legacy timer init
*/
-void pxa_timer_init(void)
+void __init pxa_timer_init(void)
{
pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
get_clock_tick_rate());
next prev parent reply other threads:[~2014-09-07 21:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 16:52 [PATCH v3 1/4] clocksource: move PXA timer to clocksource framework Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` [PATCH v3 2/4] clocksource: add device-tree support for PXA timer Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` [PATCH v3 3/4] arm: pxa: add CLKSRC_OF dependency Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` [PATCH v3 4/4] arm: pxa: add non device-tree timer link to clocksource Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-14 16:52 ` Robert Jarzmik
2014-07-21 14:37 ` Daniel Lezcano
2014-07-21 14:37 ` Daniel Lezcano
2014-07-21 14:37 ` Daniel Lezcano
2014-07-21 18:15 ` Robert Jarzmik
2014-07-21 18:15 ` Robert Jarzmik
2014-07-21 18:15 ` Robert Jarzmik
2014-07-26 18:50 ` [PATCH ] ARM: pxa: fix section mismatch warning for pxa_timer_nodt_init Arnd Bergmann
2014-07-26 18:50 ` Arnd Bergmann
2014-07-26 21:17 ` Robert Jarzmik
2014-07-26 21:17 ` Robert Jarzmik
2014-07-26 21:17 ` Robert Jarzmik
2014-07-28 5:39 ` Daniel Lezcano
2014-07-28 5:39 ` Daniel Lezcano
2014-07-28 5:39 ` Daniel Lezcano
2014-09-07 21:06 ` Arnd Bergmann [this message]
2014-09-07 21:06 ` Arnd Bergmann
2014-09-07 21:06 ` Arnd Bergmann
2014-09-08 2:21 ` Re : " robert.jarzmik
2014-09-08 2:21 ` robert.jarzmik at free.fr
2014-09-26 7:52 ` [PATCH v3 4/4] arm: pxa: add non device-tree timer link to clocksource Daniel Lezcano
2014-09-26 7:52 ` Daniel Lezcano
2014-09-26 17:08 ` Robert Jarzmik
2014-09-26 17:08 ` Robert Jarzmik
2014-09-26 17:08 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3188925.pjYA4K7kjn@wuerfel \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.