All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
	keyrings@vger.kernel.org
Subject: [PATCH 2/2] crypto: ECDH - fix typo of P-192 b value
Date: Wed, 11 Jul 2018 18:36:23 +0000	[thread overview]
Message-ID: <31905154.JqEMqoRUPu@positron.chronox.de> (raw)
In-Reply-To: <20180711041059.GA13331@sol.localdomain>

Fix the b value to be compliant with FIPS 186-4 D.1.2.1. This fix is
required to make sure the SP800-56A public key test passes for P-192.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 crypto/ecc_curve_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/ecc_curve_defs.h b/crypto/ecc_curve_defs.h
index 94e883a9403f..336ab1805639 100644
--- a/crypto/ecc_curve_defs.h
+++ b/crypto/ecc_curve_defs.h
@@ -27,7 +27,7 @@ static u64 nist_p192_p[] = { 0xFFFFFFFFFFFFFFFFull, 0xFFFFFFFFFFFFFFFEull,
 static u64 nist_p192_n[] = { 0x146BC9B1B4D22831ull, 0xFFFFFFFF99DEF836ull,
 				0xFFFFFFFFFFFFFFFFull };
 static u64 nist_p192_a[] = { 0xFFFFFFFFFFFFFFFCull, 0xFFFFFFFFFFFFFFFEull,
-				0xFFFFFFFFFFFFFFFEull };
+				0xFFFFFFFFFFFFFFFFull };
 static u64 nist_p192_b[] = { 0xFEB8DEECC146B9B1ull, 0x0FA7E9AB72243049ull,
 				0x64210519E59C80E7ull };
 static struct ecc_curve nist_p192 = {
-- 
2.17.1





  parent reply	other threads:[~2018-07-11 18:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 10:17 [RFC PATCH] crypto: DH - add public key verification test Stephan Müller
2018-06-26 15:13 ` Stephan Mueller
2018-06-27  6:15 ` [PATCH v2] " Stephan Müller
2018-07-08 16:44   ` Herbert Xu
2018-07-11  4:10   ` Eric Biggers
2018-07-11 18:35     ` [PATCH 1/2] crypto: DH - update test for public key verification Stephan Müller
2018-07-20  5:54       ` Herbert Xu
2018-07-11 18:36     ` Stephan Müller [this message]
2018-07-20  5:55       ` [PATCH 2/2] crypto: ECDH - fix typo of P-192 b value Herbert Xu
2018-07-11 15:47   ` [PATCH v2] crypto: DH - add public key verification test Stephan Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31905154.JqEMqoRUPu@positron.chronox.de \
    --to=smueller@chronox.de \
    --cc=ebiggers3@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.