All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 1/3] drm/i915: don't pretend we support ASLE ALS, PFIT, or PFMB
Date: Fri, 12 Apr 2013 15:20:56 +0300	[thread overview]
Message-ID: <3241f0249b1be4b0950821e9695e273e8b702e09.1365769168.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1365769168.git.jani.nikula@intel.com>
In-Reply-To: <cover.1365769168.git.jani.nikula@intel.com>

In theory, this should prevent the BIOS from requesting them from us, and
this should be the right thing.

In practice, this is not always the case, and might surprise the BIOS.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_opregion.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 4d33874..a622fd0 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -282,9 +282,7 @@ void intel_opregion_enable_asle(struct drm_device *dev)
 		if (IS_MOBILE(dev))
 			intel_enable_asle(dev);
 
-		iowrite32(ASLE_ALS_EN | ASLE_BLC_EN | ASLE_PFIT_EN |
-			  ASLE_PFMB_EN,
-			  &asle->tche);
+		iowrite32(ASLE_BLC_EN, &asle->tche);
 		iowrite32(1, &asle->ardy);
 	}
 }
-- 
1.7.9.5

  reply	other threads:[~2013-04-12 12:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 12:20 [PATCH 0/3] drm/i915: opregion cleanup Jani Nikula
2013-04-12 12:20 ` Jani Nikula [this message]
2013-04-12 12:20 ` [PATCH 2/3] drm/i915/opregion: don't pretend we did something when we didn't Jani Nikula
2013-04-12 12:20 ` [PATCH 3/3] drm/i915: drop code duplication in favor of asle interrupt handler Jani Nikula
2013-04-24 18:23   ` Damien Lespiau
     [not found]     ` <39ef9d9d21a2211333ce011881e240304c3baec1.1366830005.git.jani.nikula@intel.com>
2013-04-24 19:18       ` [PATCH v2 " Jani Nikula
2013-04-24 19:34         ` Jani Nikula
2013-04-25 13:09         ` Damien Lespiau
2013-04-25 13:41           ` Daniel Vetter
2013-04-24 18:24 ` [PATCH 0/3] drm/i915: opregion cleanup Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3241f0249b1be4b0950821e9695e273e8b702e09.1365769168.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.