[PATCH 1/3] kvm: remove redundant reserved page check

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Zhang Yi <yi.z.zhang@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, pbonzini@redhat.com,
	dan.j.williams@intel.com, jack@suse.cz, hch@lst.de,
	yu.c.zhang@intel.com
Cc: linux-mm@kvack.org, yi.z.zhang@intel.com, rkrcmar@redhat.com
Subject: [PATCH 1/3] kvm: remove redundant reserved page check
Date: Wed,  4 Jul 2018 23:30:11 +0800	[thread overview]
Message-ID: <3266d45a10db6d22e3978eacbe2683d43aec3100.1530716899.git.yi.z.zhang@linux.intel.com> (raw)
In-Reply-To: <cover.1530716899.git.yi.z.zhang@linux.intel.com>

PageReserved() is already checked inside kvm_is_reserved_pfn(),
remove it from kvm_set_pfn_dirty().

Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
Signed-off-by: Zhang Yu <yu.c.zhang@linux.intel.com>
---
 virt/kvm/kvm_main.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index c7b2e92..afb2e6e 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1673,12 +1673,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
 
 void kvm_set_pfn_dirty(kvm_pfn_t pfn)
 {
-	if (!kvm_is_reserved_pfn(pfn)) {
-		struct page *page = pfn_to_page(pfn);
-
-		if (!PageReserved(page))
-			SetPageDirty(page);
-	}
+	if (!kvm_is_reserved_pfn(pfn))
+		SetPageDirty(pfn_to_page(pfn));
 }
 EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
 
-- 
2.7.4

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)

From: Zhang Yi <yi.z.zhang@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, pbonzini@redhat.com,
	dan.j.williams@intel.com, jack@suse.cz, hch@lst.de,
	yu.c.zhang@intel.com
Cc: linux-mm@kvack.org, rkrcmar@redhat.com, yi.z.zhang@intel.com,
	Zhang Yi <yi.z.zhang@linux.intel.com>
Subject: [PATCH 1/3] kvm: remove redundant reserved page check
Date: Wed,  4 Jul 2018 23:30:11 +0800	[thread overview]
Message-ID: <3266d45a10db6d22e3978eacbe2683d43aec3100.1530716899.git.yi.z.zhang@linux.intel.com> (raw)
In-Reply-To: <cover.1530716899.git.yi.z.zhang@linux.intel.com>

PageReserved() is already checked inside kvm_is_reserved_pfn(),
remove it from kvm_set_pfn_dirty().

Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
Signed-off-by: Zhang Yu <yu.c.zhang@linux.intel.com>
---
 virt/kvm/kvm_main.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index c7b2e92..afb2e6e 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1673,12 +1673,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
 
 void kvm_set_pfn_dirty(kvm_pfn_t pfn)
 {
-	if (!kvm_is_reserved_pfn(pfn)) {
-		struct page *page = pfn_to_page(pfn);
-
-		if (!PageReserved(page))
-			SetPageDirty(page);
-	}
+	if (!kvm_is_reserved_pfn(pfn))
+		SetPageDirty(pfn_to_page(pfn));
 }
 EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
 
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)

From: Zhang Yi <yi.z.zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	jack-AlSwsSmVLrQ@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	yu.c.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	yi.z.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 1/3] kvm: remove redundant reserved page check
Date: Wed,  4 Jul 2018 23:30:11 +0800	[thread overview]
Message-ID: <3266d45a10db6d22e3978eacbe2683d43aec3100.1530716899.git.yi.z.zhang@linux.intel.com> (raw)
In-Reply-To: <cover.1530716899.git.yi.z.zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

PageReserved() is already checked inside kvm_is_reserved_pfn(),
remove it from kvm_set_pfn_dirty().

Signed-off-by: Zhang Yi <yi.z.zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Zhang Yu <yu.c.zhang-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 virt/kvm/kvm_main.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index c7b2e92..afb2e6e 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1673,12 +1673,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
 
 void kvm_set_pfn_dirty(kvm_pfn_t pfn)
 {
-	if (!kvm_is_reserved_pfn(pfn)) {
-		struct page *page = pfn_to_page(pfn);
-
-		if (!PageReserved(page))
-			SetPageDirty(page);
-	}
+	if (!kvm_is_reserved_pfn(pfn))
+		SetPageDirty(pfn_to_page(pfn));
 }
 EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
 
-- 
2.7.4

next prev parent reply	other threads:[~2018-07-04  6:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 15:30 [PATCH 0/3] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-07-04 15:30 ` Zhang Yi
2018-07-04 15:30 ` Zhang Yi
2018-07-04 15:30 ` Zhang Yi [this message]
2018-07-04 15:30   ` [PATCH 1/3] kvm: remove redundant reserved page check Zhang Yi
2018-07-04 15:30   ` Zhang Yi
2018-07-04 15:30 ` [PATCH 2/3] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-07-04 15:30   ` Zhang Yi
2018-07-04 15:30   ` Zhang Yi
2018-07-04 14:50   ` Dan Williams
2018-07-04 14:50     ` Dan Williams
2018-07-04 14:50     ` Dan Williams
2018-07-05 13:20     ` zhangyi6
2018-07-05 13:20       ` zhangyi6
2018-07-05 13:20       ` zhangyi6
2018-07-05 13:20       ` zhangyi6
2018-07-04 15:30 ` [PATCH 3/3] kvm: add a function to check if page is from NVDIMM pmem Zhang Yi
2018-07-04 15:30   ` Zhang Yi
2018-07-04 15:30   ` Zhang Yi
2018-07-04 14:50   ` Dan Williams
2018-07-04 14:50     ` Dan Williams
2018-07-04 14:50     ` Dan Williams
2018-07-04 15:27     ` Paolo Bonzini
2018-07-04 15:27       ` Paolo Bonzini
2018-07-04 15:27       ` Paolo Bonzini
2018-07-04 15:25   ` Paolo Bonzini
2018-07-04 15:25     ` Paolo Bonzini
2018-07-04 15:25     ` Paolo Bonzini
2018-07-05 13:19     ` Zhang,Yi
2018-07-05 13:19       ` Zhang,Yi
2018-07-05 13:19       ` Zhang,Yi
2018-07-05 13:19       ` Zhang,Yi
2018-07-09 12:36       ` Jan Kara
2018-07-09 12:36         ` Jan Kara
2018-07-09 12:36         ` Jan Kara
2018-07-09 12:36         ` Jan Kara

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:c7b2e92 dfblob:c7b2e92 dfblob:c7b2e92 dfblob:afb2e6e
dfblob:afb2e6e dfblob:afb2e6e
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3266d45a10db6d22e3978eacbe2683d43aec3100.1530716899.git.yi.z.zhang@linux.intel.com \
    --to=yi.z.zhang@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=yi.z.zhang@intel.com \
    --cc=yu.c.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.