Re: [PATCH v5 2/6] staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t

From: Guenter Roeck <linux@roeck-us.net>
To: Oliver Crumrine <ozlinux@hotmail.com>
Cc: gregkh@linuxfoundation.org, colin.i.king@gmail.com,
	sumitraartsy@gmail.com, u.kleine-koenig@pengutronix.de,
	geert@linux-m68k.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v5 2/6] staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t
Date: Sun, 29 Oct 2023 10:17:21 -0700	[thread overview]
Message-ID: <32e9ad3c-191e-4dd1-b1cc-07f7b93c3f28@roeck-us.net> (raw)
In-Reply-To: <PH7PR11MB7643DEB4401AA83A0578087CBCE0A@PH7PR11MB7643.namprd11.prod.outlook.com>

On Mon, Aug 28, 2023 at 11:39:07AM -0400, Oliver Crumrine wrote:
> Remove typedef in enum cvmx_helper_interface_mode_t, and rename all instances
> to cvmx_helper_interface_mode
> 
> Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>

In linux-next:

Building mips:cavium_octeon_defconfig ... failed
--------------
Error log:
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_get_stats':
drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
  204 |         struct cvmx_pip_port_status rx_status;
      |                                     ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: error: storage size of 'tx_status' isn't known
  205 |         struct cvmx_pko_port_status tx_status;
      |                                     ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: warning: unused variable 'tx_status' [-Wunused-variable]
drivers/staging/octeon/ethernet.c:204:37: warning: unused variable 'rx_status' [-Wunused-variable]
  204 |         struct cvmx_pip_port_status rx_status;
      |                                     ^~~~~~~~~
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_probe':
drivers/staging/octeon/ethernet.c:801:22: error: variable 'imode' has initializer but incomplete type
  801 |                 enum cvmx_helper_interface_mode imode =
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/octeon/ethernet.c:801:49: error: storage size of 'imode' isn't known
  801 |                 enum cvmx_helper_interface_mode imode =
      |                                                 ^~~~~
drivers/staging/octeon/ethernet.c:801:49: warning: unused variable 'imode' [-Wunused-variable]

Bisect points to this patch. Bisect log attached.

As usual, my apologies for the noise if this has already been reported
and/or fixed.

Guenter

---
# bad: [66f1e1ea3548378ff6387b1ce0b40955d54e86aa] Add linux-next specific files for 20231027
# good: [05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1] Linux 6.6-rc7
git bisect start 'HEAD' 'v6.6-rc7'
# good: [5ba945807e7caa7aeb2111b8259f7474919c067b] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
git bisect good 5ba945807e7caa7aeb2111b8259f7474919c067b
# good: [dd91766be714f0b06fe9dbba660e37623d8200d4] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git
git bisect good dd91766be714f0b06fe9dbba660e37623d8200d4
# good: [06915762e0427a51262d17147ccd28659635452e] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git
git bisect good 06915762e0427a51262d17147ccd28659635452e
# bad: [642f5501bdbd0030056348abd970708e8c3bd67b] Merge branch 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git bisect bad 642f5501bdbd0030056348abd970708e8c3bd67b
# good: [ec6cf0d999ec6efbad23438bc24312377a3f4391] Merge branch 'tty-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
git bisect good ec6cf0d999ec6efbad23438bc24312377a3f4391
# good: [c306097335a2d271f64ce8346bd4d1cbe2b30557] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git
git bisect good c306097335a2d271f64ce8346bd4d1cbe2b30557
# bad: [b25c17e5c2497d13857772d411142daa20c70e59] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
git bisect bad b25c17e5c2497d13857772d411142daa20c70e59
# bad: [d50f64b5520311cacf38b8c2c240c5955c815d10] staging: rtl8192e: Resolve circular locking with rx_pkt_pending_timer
git bisect bad d50f64b5520311cacf38b8c2c240c5955c815d10
# good: [87f8e11d5147992fe0b8c232e656be96f778408e] staging: rtl8192e: Replace control subframe types with IEEE80211_STYPE_*
git bisect good 87f8e11d5147992fe0b8c232e656be96f778408e
# bad: [7458fdf8a778b14ad814c9c13695d0c85b210afa] Staging: rtl8192e: Rename variable Time
git bisect bad 7458fdf8a778b14ad814c9c13695d0c85b210afa
# bad: [8d26aa90458f82b952dcaa64e7c4afed9c862d68] staging: octeon: remove typedef in struct cvmx_pko_lock_t
git bisect bad 8d26aa90458f82b952dcaa64e7c4afed9c862d68
# good: [571fa9b51375eee059846c780dce05f04528b065] staging: vme_user: fix check unnecessary blank lines in vme_fake.c
git bisect good 571fa9b51375eee059846c780dce05f04528b065
# good: [7bebd832177670e6cce1783cf144f989cd3cf4b5] staging: octeon: remove typedef in enum cvmx_spi_mode_t
git bisect good 7bebd832177670e6cce1783cf144f989cd3cf4b5
# bad: [28fae776c69bdac005fa77a7e0daa64725d0f4f8] staging: octeon: remove typedef in enum cvmx_pow_wait_t
git bisect bad 28fae776c69bdac005fa77a7e0daa64725d0f4f8
# bad: [a13f7e45823cd29af716ed6be1f53a344e0b9268] staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t
git bisect bad a13f7e45823cd29af716ed6be1f53a344e0b9268
# first bad commit: [a13f7e45823cd29af716ed6be1f53a344e0b9268] staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t