All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Airlie <airlied@linux.ie>,
	Liviu Dudau <liviu.dudau@arm.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select
Date: Fri, 01 Jan 2016 15:38:53 +0100	[thread overview]
Message-ID: <3381082.HCMeGm07UJ@wuerfel> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>

The hdlcd driver has no build-time dependency on the SCPI clock
and the bogus 'select' causes a warning when SCPI is disabled:

warning: (DRM_HDLCD) selects COMMON_CLK_SCPI which has unmet direct dependencies (COMMON_CLK && (ARM_SCPI_PROTOCOL || COMPILE_TEST))

This removes the select statement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found two more bugs in the same driver, so this is now a patch series

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 2f4d3b7fb871..81ea7802ca50 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -9,7 +9,6 @@ config DRM_HDLCD
 	tristate "ARM HDLCD"
 	depends on DRM_ARM
 	depends on COMMON_CLK
-	select COMMON_CLK_SCPI
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	help


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select
Date: Fri, 01 Jan 2016 15:38:53 +0100	[thread overview]
Message-ID: <3381082.HCMeGm07UJ@wuerfel> (raw)
In-Reply-To: <4194408.X82ccDjh5X@wuerfel>

The hdlcd driver has no build-time dependency on the SCPI clock
and the bogus 'select' causes a warning when SCPI is disabled:

warning: (DRM_HDLCD) selects COMMON_CLK_SCPI which has unmet direct dependencies (COMMON_CLK && (ARM_SCPI_PROTOCOL || COMPILE_TEST))

This removes the select statement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found two more bugs in the same driver, so this is now a patch series

diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 2f4d3b7fb871..81ea7802ca50 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -9,7 +9,6 @@ config DRM_HDLCD
 	tristate "ARM HDLCD"
 	depends on DRM_ARM
 	depends on COMMON_CLK
-	select COMMON_CLK_SCPI
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	help

  reply	other threads:[~2016-01-01 14:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 14:09 [PATCH] drm: arm-hdlcd: remove DMA_CMA select Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:09 ` Arnd Bergmann
2016-01-01 14:38 ` Arnd Bergmann [this message]
2016-01-01 14:38   ` [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Arnd Bergmann
2016-01-04  8:26   ` Thierry Reding
2016-01-04  8:26     ` Thierry Reding
2016-01-04  8:26     ` Thierry Reding
2016-01-01 14:39 ` [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Arnd Bergmann
2016-01-01 14:39   ` Arnd Bergmann
2016-01-01 14:39   ` Arnd Bergmann
2016-01-04  8:24   ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-01 22:04 ` [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann
2016-01-01 22:04   ` Arnd Bergmann
2016-01-04  8:24   ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:24     ` Thierry Reding
2016-01-04  8:39     ` Arnd Bergmann
2016-01-04  8:39       ` Arnd Bergmann
2016-01-04  8:39       ` Arnd Bergmann
2016-01-11 11:12       ` Liviu Dudau
2016-01-11 11:12         ` Liviu Dudau
2016-01-11 12:18         ` Arnd Bergmann
2016-01-11 12:18           ` Arnd Bergmann
2016-01-11 12:26           ` Liviu Dudau
2016-01-11 12:26             ` Liviu Dudau
2016-01-11 12:26             ` Liviu Dudau
2016-01-11 13:49             ` Arnd Bergmann
2016-01-11 13:49               ` Arnd Bergmann
2016-01-11 13:49               ` Arnd Bergmann
2016-01-11 14:14               ` Liviu Dudau
2016-01-11 14:14                 ` Liviu Dudau
2016-01-11 14:14                 ` Liviu Dudau
2016-01-04  8:27 ` [PATCH] drm: arm-hdlcd: remove DMA_CMA select Thierry Reding
2016-01-04  8:27   ` Thierry Reding
2016-01-04  8:27   ` Thierry Reding
2016-01-11 10:37 ` Liviu Dudau
2016-01-11 10:37   ` Liviu Dudau
2016-01-11 10:37   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3381082.HCMeGm07UJ@wuerfel \
    --to=arnd@arndb.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.