From: Pavel Begunkov <asml.silence@gmail.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] target/file: don't zero iter before iov_iter_bvec
Date: Sat, 9 Jan 2021 15:53:27 +0000 [thread overview]
Message-ID: <34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com> (raw)
iov_iter_bvec() initialises iterators well, no need to pre-zero it
beforehand as done in fd_execute_rw_aio(). Compilers can't optimise it
out and generate extra code for that (confirmed with assembly).
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
drivers/target/target_core_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index cce455929778..5a66854def95 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -267,7 +267,7 @@ fd_execute_rw_aio(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
struct fd_dev *fd_dev = FD_DEV(dev);
struct file *file = fd_dev->fd_file;
struct target_core_file_cmd *aio_cmd;
- struct iov_iter iter = {};
+ struct iov_iter iter;
struct scatterlist *sg;
ssize_t len = 0;
int ret = 0, i;
--
2.24.0
next reply other threads:[~2021-01-09 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 15:53 Pavel Begunkov [this message]
2021-01-09 20:09 ` [PATCH] target/file: don't zero iter before iov_iter_bvec Chaitanya Kulkarni
2021-01-09 20:37 ` Pavel Begunkov
2021-01-09 20:52 ` Chaitanya Kulkarni
2021-01-09 21:25 ` Pavel Begunkov
2021-01-11 2:06 ` Chaitanya Kulkarni
2021-01-11 2:28 ` Pavel Begunkov
2021-01-11 5:23 ` Chaitanya Kulkarni
2021-01-11 5:31 ` Pavel Begunkov
2021-01-11 2:49 ` Bart Van Assche
2021-01-13 5:34 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.