From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: hcd: add OTG ID signal sensing Date: Tue, 16 Dec 2014 23:16:31 +0000 [thread overview] Message-ID: <3663198.HSrURZGche@wasted.cogentembedded.com> (raw) On the Renesas R8A7791 SoC based boards there's MAX3355 USB OTG chip and mini-AB USB connector corresponding to USB port 0 driven either by EHCI/OHCI or Renesas USBHS gadget controller. And we'd like the host/gadget drivers to work based on the cable type connected. An 'extcon' driver for MAX3355 has been written, so we only need to bind to it via device tree which I'm doing in this patch. I wasn't able to find a solution better than checking the cable type at the host driver probe time and refusing to drive a host if B-cable is connected. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. It needs the recent 'extcon' core in order to properly handle probe deferral. drivers/usb/core/hcd.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) Index: usb/drivers/usb/core/hcd.c =================================--- usb.orig/drivers/usb/core/hcd.c +++ usb/drivers/usb/core/hcd.c @@ -42,6 +42,7 @@ #include <linux/pm_runtime.h> #include <linux/types.h> +#include <linux/extcon.h> #include <linux/phy/phy.h> #include <linux/usb.h> #include <linux/usb/hcd.h> @@ -2632,6 +2633,23 @@ int usb_add_hcd(struct usb_hcd *hcd, int retval; struct usb_device *rhdev; + if (IS_ENABLED(CONFIG_EXTCON) && + of_property_read_bool(hcd->self.controller->of_node, "extcon")) { + struct extcon_dev *edev; + + edev = extcon_get_edev_by_phandle(hcd->self.controller, 0); + if (IS_ERR(edev)) + return PTR_ERR(edev); + + retval = extcon_get_cable_state(edev, "USB-HOST"); + if (!retval) { + dev_err(hcd->self.controller, + "OTG B-cable plugged in, host driver won't load\n"); + return -EINVAL; + } else if (retval < 0) + return retval; + } + if (IS_ENABLED(CONFIG_USB_PHY) && !hcd->usb_phy) { struct usb_phy *phy = usb_get_phy_dev(hcd->self.controller, 0);
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: hcd: add OTG ID signal sensing Date: Wed, 17 Dec 2014 02:16:31 +0300 [thread overview] Message-ID: <3663198.HSrURZGche@wasted.cogentembedded.com> (raw) On the Renesas R8A7791 SoC based boards there's MAX3355 USB OTG chip and mini-AB USB connector corresponding to USB port 0 driven either by EHCI/OHCI or Renesas USBHS gadget controller. And we'd like the host/gadget drivers to work based on the cable type connected. An 'extcon' driver for MAX3355 has been written, so we only need to bind to it via device tree which I'm doing in this patch. I wasn't able to find a solution better than checking the cable type at the host driver probe time and refusing to drive a host if B-cable is connected. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. It needs the recent 'extcon' core in order to properly handle probe deferral. drivers/usb/core/hcd.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) Index: usb/drivers/usb/core/hcd.c =================================================================== --- usb.orig/drivers/usb/core/hcd.c +++ usb/drivers/usb/core/hcd.c @@ -42,6 +42,7 @@ #include <linux/pm_runtime.h> #include <linux/types.h> +#include <linux/extcon.h> #include <linux/phy/phy.h> #include <linux/usb.h> #include <linux/usb/hcd.h> @@ -2632,6 +2633,23 @@ int usb_add_hcd(struct usb_hcd *hcd, int retval; struct usb_device *rhdev; + if (IS_ENABLED(CONFIG_EXTCON) && + of_property_read_bool(hcd->self.controller->of_node, "extcon")) { + struct extcon_dev *edev; + + edev = extcon_get_edev_by_phandle(hcd->self.controller, 0); + if (IS_ERR(edev)) + return PTR_ERR(edev); + + retval = extcon_get_cable_state(edev, "USB-HOST"); + if (!retval) { + dev_err(hcd->self.controller, + "OTG B-cable plugged in, host driver won't load\n"); + return -EINVAL; + } else if (retval < 0) + return retval; + } + if (IS_ENABLED(CONFIG_USB_PHY) && !hcd->usb_phy) { struct usb_phy *phy = usb_get_phy_dev(hcd->self.controller, 0);
next reply other threads:[~2014-12-16 23:16 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-16 23:16 Sergei Shtylyov [this message] 2014-12-16 23:16 ` [PATCH] usb: hcd: add OTG ID signal sensing Sergei Shtylyov 2014-12-17 2:08 ` Peter Chen 2014-12-17 2:08 ` Peter Chen 2014-12-17 11:35 ` Sergei Shtylyov 2014-12-17 11:35 ` Sergei Shtylyov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3663198.HSrURZGche@wasted.cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.