All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Han-Wen Nienhuys <hanwenn@gmail.com>,
	Han-Wen Nienhuys <hanwen@google.com>
Subject: [PATCH v2 09/11] t7064: use update-ref -d to remove upstream branch
Date: Thu, 22 Jul 2021 21:28:45 +0000	[thread overview]
Message-ID: <3685ba90f60ef95892a22c8549c9a3c0717d6662.1626989327.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1052.v2.git.git.1626989327.gitgitgadget@gmail.com>

From: Han-Wen Nienhuys <hanwen@google.com>

The previous code tested this by writing $ZERO_OID explicitly in the packed-refs
file. This is a type of corruption that doesn't reflect realistic use-cases. In
addition, even the ref-store test-tool refuses to write invalid OIDs.
(update-ref interprets $ZERO_OID is deleting the ref).

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 t/t7064-wtstatus-pv2.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/t/t7064-wtstatus-pv2.sh b/t/t7064-wtstatus-pv2.sh
index 4613882caff..eeb0534163d 100755
--- a/t/t7064-wtstatus-pv2.sh
+++ b/t/t7064-wtstatus-pv2.sh
@@ -373,10 +373,7 @@ test_expect_success 'verify upstream fields in branch header' '
 
 		## Test upstream-gone case. Fake this by pointing
 		## origin/initial-branch at a non-existing commit.
-		OLD=$(git rev-parse origin/initial-branch) &&
-		NEW=$ZERO_OID &&
-		mv .git/packed-refs .git/old-packed-refs &&
-		sed "s/$OLD/$NEW/g" <.git/old-packed-refs >.git/packed-refs &&
+		git update-ref -d refs/remotes/origin/initial-branch &&
 
 		HUF=$(git rev-parse HEAD) &&
 
-- 
gitgitgadget


  parent reply	other threads:[~2021-07-22 21:29 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 18:07 [PATCH 0/6] Fix direct filesystem access in various test files Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 1/6] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 2/6] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 3/6] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 4/6] t7509: " Han-Wen Nienhuys via GitGitGadget
2021-07-19 21:35   ` Junio C Hamano
2021-07-19 18:07 ` [PATCH 5/6] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-07-19 18:07 ` [PATCH 6/6] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28 ` [PATCH v2 00/11] Fix direct filesystem access in various test files Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 01/11] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 02/11] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 03/11] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 04/11] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 05/11] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 06/11] t1405: use 'git reflog exists' to check reflog existence Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:15     ` Junio C Hamano
2021-07-22 21:28   ` [PATCH v2 07/11] t1405: mark test for 'git pack-refs' as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:28     ` Junio C Hamano
2021-07-22 21:28   ` [PATCH v2 08/11] t1410: mark test " Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:32     ` Junio C Hamano
2021-07-22 21:28   ` Han-Wen Nienhuys via GitGitGadget [this message]
2021-07-23 17:37     ` [PATCH v2 09/11] t7064: use update-ref -d to remove upstream branch Junio C Hamano
2021-07-22 21:28   ` [PATCH v2 10/11] t6500: use "ls -1" to snapshot ref database state Han-Wen Nienhuys via GitGitGadget
2021-07-22 21:28   ` [PATCH v2 11/11] t6001: avoid direct file system access Han-Wen Nienhuys via GitGitGadget
2021-07-23 17:40     ` Junio C Hamano
2021-07-23 17:44   ` [PATCH v2 00/11] Fix direct filesystem access in various test files Junio C Hamano
2021-08-02 13:38     ` Han-Wen Nienhuys
2021-08-02 16:27       ` Junio C Hamano
2021-08-02 16:28       ` Junio C Hamano
2021-08-02 16:53         ` Han-Wen Nienhuys
2021-08-02 16:53   ` [PATCH v3 " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 01/11] t6050: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 02/11] t1503: mark symlink test as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 03/11] t6120: use git-update-ref rather than filesystem access Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 04/11] t3320: use git-symbolic-ref " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 05/11] t2402: use ref-store test helper to create broken symlink Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 06/11] t1405: use 'git reflog exists' to check reflog existence Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 07/11] t1405: mark test for 'git pack-refs' as REFFILES Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 08/11] t1410: mark test " Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 09/11] t7064: use update-ref -d to remove upstream branch Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 10/11] t6500: use "ls -1" to snapshot ref database state Han-Wen Nienhuys via GitGitGadget
2021-08-02 16:53     ` [PATCH v3 11/11] t6001: avoid direct file system access Han-Wen Nienhuys via GitGitGadget
2021-08-02 20:07     ` [PATCH v3 00/11] Fix direct filesystem access in various test files Junio C Hamano
2021-08-02 21:32       ` Junio C Hamano
2021-08-03  9:37         ` Han-Wen Nienhuys
2021-07-22 22:24 ` [PATCH 0/6] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3685ba90f60ef95892a22c8549c9a3c0717d6662.1626989327.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hanwen@google.com \
    --cc=hanwenn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.