All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
	xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
	consulting@bugseng.com, Julien Grall <julien@xen.org>
Subject: [XEN PATCH 04/10] xen/device_tree: address violations of MISRA C Rule 20.7
Date: Mon, 18 Mar 2024 12:53:47 +0100	[thread overview]
Message-ID: <3845d2a318bdaab242a7fd67473b05198db1b111.1710762555.git.nicola.vetrini@bugseng.com> (raw)
In-Reply-To: <cover.1710762555.git.nicola.vetrini@bugseng.com>

MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
This patch uniforms the way these macros use parentheses, skipping the
already deviated cases of the lhs of an assignment. In principle, all
three could have the parentheses on the macro argument in the lhs added.
---
 xen/include/xen/device_tree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 6fe2fa8b2123..e6287305a7b5 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -250,7 +250,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches);
     for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next )
 
 #define dt_for_each_device_node(dt, dn)                     \
-    for ( dn = dt; (dn) != NULL; dn = (dn)->allnext )
+    for ( dn = (dt); (dn) != NULL; dn = (dn)->allnext )
 
 #define dt_for_each_child_node(dt, dn)                      \
     for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling )
-- 
2.34.1



  parent reply	other threads:[~2024-03-18 11:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 11:53 [XEN PATCH 00/10] address some violations of MISRA C Rule 20.7 Nicola Vetrini
2024-03-18 11:53 ` [XEN PATCH 01/10] x86/cpufeature: add parentheses to comply with " Nicola Vetrini
2024-03-18 16:42   ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 02/10] AMD/IOMMU: guest: address violations of MISRA C " Nicola Vetrini
2024-03-18 16:43   ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 03/10] xen/xsm: add parentheses to comply with " Nicola Vetrini
2024-03-19  3:32   ` Stefano Stabellini
2024-03-18 11:53 ` Nicola Vetrini [this message]
2024-03-19  3:33   ` [XEN PATCH 04/10] xen/device_tree: address violations of " Stefano Stabellini
2024-03-18 11:53 ` [XEN PATCH 05/10] EFI: " Nicola Vetrini
2024-03-18 16:47   ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 06/10] xen/arm: smmu: " Nicola Vetrini
2024-03-19  3:32   ` Stefano Stabellini
2024-03-18 11:53 ` [XEN PATCH 07/10] xen/efi: efibind: " Nicola Vetrini
2024-03-18 16:49   ` Jan Beulich
2024-03-18 17:03     ` Nicola Vetrini
2024-03-18 11:53 ` [XEN PATCH 08/10] xen/notifier: " Nicola Vetrini
2024-03-18 16:50   ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 09/10] xen/wait: " Nicola Vetrini
2024-03-18 16:51   ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 10/10] xen/sched: " Nicola Vetrini
2024-03-18 12:00   ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3845d2a318bdaab242a7fd67473b05198db1b111.1710762555.git.nicola.vetrini@bugseng.com \
    --to=nicola.vetrini@bugseng.com \
    --cc=ayan.kumar.halder@amd.com \
    --cc=consulting@bugseng.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xenia.ragiadakou@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.